From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id A69753858D39 for ; Sun, 30 Apr 2023 19:12:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A69753858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64115eef620so22950273b3a.1 for ; Sun, 30 Apr 2023 12:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682881920; x=1685473920; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=riFOVOaekBtQjqhrCiSMXuWxP0XFl1Sy0tMK69LZvd4=; b=Eg5j44kE8jzMFzbUWD7edYyRnYCg2PwQrlMufYRNSW2gSud+1XK1cGOXW24yDxwRiU g5uoK96uGMfvuBgoEqWcxh1gCMgmh4EM+p0hhPGP7UJBlPTHOCILnnxx0ppNS9XwPfyR Z/fYXwmpG2xtaqLsPy2+uVthoE1KplOkKcUFRdA+46mUYa4bYJ7G55hB/t9L+SgWbnN4 IWWBBezG6BJx7qXzrXJC3rfWVBlfuFJDFpPsGbAludN4rQ6DXANJrp7xuXtMu2+Bv9Ty /OSbPKKQ5Gn8DSLyesihbBa8TpBVMllc0S+sg0dum1ICS/2POETS9XDNW63Xx1lZDzd3 OM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682881920; x=1685473920; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=riFOVOaekBtQjqhrCiSMXuWxP0XFl1Sy0tMK69LZvd4=; b=YmzROPbWifU0nYgtp38NV2rTG7kfspaL7w8ePlI+odMx58wIeDjHmQtqnad2XIO/qe NMolr7d8osYneT49Vtr1+j3SR2Jd8GldID1tYGpAgSBnWjXm0TbQjnHPlJImqA3wQmsV WW3OCMeCtSvPZiXHXmH1P5nyV2WMhHBcnCJNmqo0Ry6JipHnwsfAIlGOno6b7T/RunQb S7kJe8flGWdjoHen+EmV057mrcEx84NsDPH8v2N5a/se37ccu9Ikx2Y98o1CO+Knuj0P umJ7xyOU4H0fPSGWoArN12tzFJhB+LxlWLgU0HO9zuYIHRx/eHSE/kbB8tOQIDg0q/ir Juww== X-Gm-Message-State: AC+VfDwnz47iiXB/PkIkN3D22t6cTughhsTH1ARzfwABz20whrcgEnvD LgIWCJlYroEW3+FQ1ExrnZY= X-Google-Smtp-Source: ACHHUZ6GoeLROFou94Gwy61+Yxgqq3ZiV+sWULwurbExoQs+lsLg/0a/lBebbu9v16Q42+n+DTLaKQ== X-Received: by 2002:a17:90a:bb17:b0:24d:d7fd:86bd with SMTP id u23-20020a17090abb1700b0024dd7fd86bdmr6084126pjr.5.1682881920141; Sun, 30 Apr 2023 12:12:00 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id x9-20020a63f709000000b0050f56964426sm16283566pgh.54.2023.04.30.12.11.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Apr 2023 12:11:59 -0700 (PDT) Message-ID: <9d1afa76-d68e-fa5d-98a9-76d9cd5a1123@gmail.com> Date: Sun, 30 Apr 2023 13:11:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] PHIOPT: Allow moving of some builtin calls Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230428170213.677572-1-apinski@marvell.com> <20230428170213.677572-2-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230428170213.677572-2-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/28/23 11:02, Andrew Pinski via Gcc-patches wrote: > While moving working on moving > cond_removal_in_builtin_zero_pattern to match, I noticed > that functions were not allowed to move as we reject all > non-assignments. > This changes to allowing a few calls which are known not > to throw/trap. Right now it is restricted to ones > which cond_removal_in_builtin_zero_pattern handles but > adding more is just adding it to the switch statement. > > gcc/ChangeLog: > > * tree-ssa-phiopt.cc (empty_bb_or_one_feeding_into_p): > Allow some builtin/internal function calls which > are known not to trap/throw. > (phiopt_worker::match_simplify_replacement): > Use name instead of getting the lhs again. OK jeff