From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-518285-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 90067 invoked by alias); 27 Jan 2020 09:47:27 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 90053 invoked by uid 89); 27 Jan 2020 09:47:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jan 2020 09:47:26 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 225A3AD39;	Mon, 27 Jan 2020 09:47:24 +0000 (UTC)
Subject: Re: [PATCH] Make target_clones resolver fn static.
To: law@redhat.com, Richard Biener <richard.guenther@gmail.com>, "H.J. Lu" <hjl.tools@gmail.com>
Cc: Alexander Monakov <amonakov@ispras.ru>, Uros Bizjak <ubizjak@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
References: <eb85e847-a0d5-ed3a-534d-f67738c8281f@suse.cz> <CAFiYyc0duhXUwHZ027pCx-gbkuU9N7VcvNCDts2yMa0AvK+5JQ@mail.gmail.com> <CAMe9rOpRBNHdgcmz2haiTwyJQ2S9A9Yi1in57sHLMiUbkK+pSw@mail.gmail.com> <alpine.LNX.2.20.13.2001201635130.7204@monopod.intra.ispras.ru> <CAMe9rOqbo7H8-aGB+ua-eey43uJqqJRdtoan+G5cMhZps3_yhQ@mail.gmail.com> <alpine.LNX.2.20.13.2001201712580.7204@monopod.intra.ispras.ru> <CAMe9rOr=x5N=6uzVfh2+EzTWsHm7=90-dEjBKNHdbF2B9Zs0bw@mail.gmail.com> <alpine.LNX.2.20.13.2001201736410.7204@monopod.intra.ispras.ru> <CAMe9rOrvHuaD4XDwAZckSMMB_bW7H0eXd26BcHXqpHDoxnFQKQ@mail.gmail.com> <CAFiYyc1G696raL3RY3YVuZuz80PtDGt4yKxzHXbEtvNYm_bEkA@mail.gmail.com> <3c501d14-8048-5e9e-4276-fe02e4937487@suse.cz> <efa2fbc7fa32370b327ed02e90c7b80964cd96f3.camel@redhat.com>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
Message-ID: <9d26dcc9-f6b7-ad60-fcd1-ba40592ad5d8@suse.cz>
Date: Mon, 27 Jan 2020 11:05:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <efa2fbc7fa32370b327ed02e90c7b80964cd96f3.camel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg01730.txt.bz2

On 1/26/20 6:35 PM, Jeff Law wrote:
> On Tue, 2020-01-21 at 13:48 +0100, Martin Liška wrote:
>>  From a3faaced989869867671ceadd89b56fabde225ff Mon Sep 17 00:00:00 2001
>> From: Martin Liska <mliska@suse.cz>
>> Date: Thu, 16 Jan 2020 10:38:41 +0100
>> Subject: [PATCH] Make target_clones resolver fn static.
>>
>> gcc/ChangeLog:
>>
>> 2020-01-17  Martin Liska  <mliska@suse.cz>
>>
>> 	PR target/93274
>> 	* config/i386/i386-features.c (make_resolver_func):
>> 	Align the code with ppc64 target implementaion.
>> 	We do not need to have gnu_indirect_function
>> 	as a global function.  Drop TREE_PUBLIC on
>> 	ifunc symbol.
>> 	* config/rs6000/rs6000.c (make_resolver_func): Drop
>> 	TREE_PUBLIC on ifunc symbol.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2020-01-17  Martin Liska  <mliska@suse.cz>
>>
>> 	PR target/93274
>> 	* gcc.target/i386/pr81213.c: Adjust to not expect
>> 	a global unique name.
>> 	* gcc.target/i386/pr81213-2.c: New test.
> Not strictly a regression, but given the codegen impact, I think this
> should go in.  OK

Thanks for the approval, but I'm going to install only the first part and leave
the second part for GCC 11.

Martin

> 
> jeff
>