From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCH for c++/88538 - braced-init-list in template-argument-list
Date: Tue, 08 Jan 2019 02:53:00 -0000 [thread overview]
Message-ID: <9d2c4ab0-f374-c802-855c-6706516f7557@redhat.com> (raw)
In-Reply-To: <20190107235642.GI28316@redhat.com>
On 1/7/19 6:56 PM, Marek Polacek wrote:
> At the risk of seeming overly eager, I thought it would be reasonable to
> go with the following: enabling braced-init-list as a template-argument.
> As the discussion on the reflector clearly indicates, this was the intent
> from the get-go.
>
> I know, it's not a regression. But I restricted the change to C++20, and it
> should strictly allow code that wasn't accepted before -- when a template
> argument starts with {. Perhaps we could even drop the C++20 check.
>
> What's your preference?
Let's keep the C++20 check for now at least. I'd suggest moving the
change further down, with this code:
> if (cxx_dialect <= cxx14)
> argument = cp_parser_constant_expression (parser);
> else
> {
> /* With C++17 generalized non-type template arguments we need to handle
> lvalue constant expressions, too. */
> argument = cp_parser_assignment_expression (parser);
> require_potential_constant_expression (argument);
> }
Jason
next prev parent reply other threads:[~2019-01-08 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:56 Marek Polacek
2019-01-08 2:53 ` Jason Merrill [this message]
2019-01-08 15:42 ` Marek Polacek
2019-01-08 20:46 ` Jason Merrill
2019-01-08 22:35 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d2c4ab0-f374-c802-855c-6706516f7557@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).