From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id D8F3C398CC24 for ; Wed, 5 Jun 2024 13:51:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8F3C398CC24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D8F3C398CC24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717595517; cv=none; b=k6mzOcijKtv6IMJeoGW6/BFv67391JRFzHAR5XTcPkzFeCZY21fjm+R4RyvuImI4FgkdpSlpNRHXE8voJ/DeL7HD52mLA/kFDs/i2bjBoMU9PRg5El5gr5qynHZT0RVn/faAvs1lSWlVFJd4LXY92i7ONY9DgXSzB3KJOVaRcPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717595517; c=relaxed/simple; bh=EXDqto7ezJAKkBnZqjL9g2UwSqYJnxzQxktZt4gHqAU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=OIB7E7m0ckDCBGTtkmSe/jGAWJdrGIkxp301sSKb1y+y7GMyVo3jN4MP8q4vpTI0Ki8PMXYYPgRrmSEsfkDN0GsR0Z5p2G8GS9S1mRq6vAlyoIPHTIIkyyk+TT3qCjQ8R8H4QC34SiW/RgkiKwz5qeFAfQiGBqMWl6kmDRKpkVI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4213b94b8b5so32165545e9.0 for ; Wed, 05 Jun 2024 06:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717595514; x=1718200314; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Owi4lnDo9dddDxyq1CYhfjFst2H1kmTJQzqwUW5di4s=; b=FJw0qa05qzat1+y31cZwFYK9QPcWeOBhIXzVncQ376gyExji62dzE2KZrkG+P5VxJs I9pRX0vpoVtVTT6AcdUP1M83GoiiR07yAjiineOBEFcR9XOLt17CmXR3EhApkp1HRLEK iFu7bBkiyvPwitHgx8D6SvlekF9EkuP9z5fYwLRuzoSOReNJ3VDbvNMOFGcdhDGSu5r8 MjN+QNPFfcGwAqkQtFNGwMO7Bs+Jb5+zq90nBPrJBr8vCFYq3HOyySFX68s7nNGheSK5 5ihRlomsufb3oyKoxUIU0fJtHGkAoZiYCtGXQxEwKlL4iarawzFLS+LLrRmSTVApj8Ak SAFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717595514; x=1718200314; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Owi4lnDo9dddDxyq1CYhfjFst2H1kmTJQzqwUW5di4s=; b=PEQz7SnN41nIsTbl5+Oi88a5CyLMHxHXdimKDPFV5jgxCdmeBB6V/f6ZsW2ctplVgN zwwk+Bl7VpZuX4ocap/mB4W8wfIK9p2PczB8oQp+P4m6o1nJkJBncsSQuEdRRoo5EUV5 aRjo5cC/8rJGGLCf1cEVg5+ctvTpPaVFIJD6obldCVvxbArzzF16oRcNk/X7qosGbnaM VNzKgwR1h23RHPsYj0VXH1IuQcv4lU6eP3aRStZC3HcndcX3WK/nOW4y5d6OHT9/xdNa NDnFn8iLHM7WCrrfOR2qD5yfWhVPIW+VYtBiSbsJCcgEfsWtdR73e/shzgvtGltIOP2q WpiA== X-Gm-Message-State: AOJu0YzWUHrrt+zhmn+Bf7jlNQ6uTMfRjoh3V19UK3qkfQBdjIP+ulqK McqvrzBHrycQTPNXKxbugE00WzeQNLFSDaLzBXbw5T6NFZFc4vfW X-Google-Smtp-Source: AGHT+IEXlysRPrePZjEn3lMUpwMa2IN2wdKChJkGV4KUiUg9zZn8cFSk1mhBMgY42fZX4JO9CSD2/g== X-Received: by 2002:a5d:4527:0:b0:354:fb81:19d7 with SMTP id ffacd0b85a97d-35e8ef77e28mr1937455f8f.44.1717595514245; Wed, 05 Jun 2024 06:51:54 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd0667366sm14524907f8f.111.2024.06.05.06.51.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 06:51:53 -0700 (PDT) Message-ID: <9d50b3a6-02fd-4b22-babb-b3f20408bfea@gmail.com> Date: Wed, 5 Jun 2024 07:51:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 0/2] fix RISC-V zcmp popretz [PR113715] Content-Language: en-US To: Kito Cheng , Fei Gao Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com References: <20240605015024.7845-1-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/5/24 12:36 AM, Kito Cheng wrote: > Thanks for fixing this issue, and I am wondering doest it possible to > fix that without introduce target hook? I ask that because...GCC 14 > also has this bug, but I am not sure it's OK to introduce new target > hook for release branch? or would you suggest we just revert patch to > fix that on GCC 14? The question I would ask is why is the target hook needed. ie, what problem needs to be solved and how does a new target hook help. Jeff