From: Denys Vlasenko <dvlasenk@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>, gcc-patches@gcc.gnu.org
Cc: Andrew Pinski <pinskia@gmail.com>, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]]
Date: Thu, 06 Oct 2016 18:43:00 -0000 [thread overview]
Message-ID: <9d999546-480a-52e8-1785-42086d7fae66@redhat.com> (raw)
In-Reply-To: <aea23d76-56d7-99db-7131-cf2554ac0e5c@redhat.com>
On 10/06/2016 11:47 AM, Bernd Schmidt wrote:
> On 09/30/2016 07:54 PM, Denys Vlasenko wrote:
>> +struct target_flag_state {
>> + /* Each falign-foo can generate up to two levels of alignment:
>> + -falign-foo=N,M[,N2,M2] */
>> + struct align_flags x_align_loops[2];
>> + struct align_flags x_align_jumps[2];
>> + struct align_flags x_align_labels[2];
>> + struct align_flags x_align_functions[2];
>
>> +#define align_loops (this_target_flag_state->x_align_loops)
>> +#define align_jumps (this_target_flag_state->x_align_jumps)
>> +#define align_labels (this_target_flag_state->x_align_labels)
>
> In addition to the points already raised, this also breaks ports
> which access variables like align_jumps and expect them to be integers.
>rs6000 is one such port.
Ouch... I did forget to search for these! Will send an updated patch.
next prev parent reply other threads:[~2016-10-06 18:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 17:55 [PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 4 Denys Vlasenko
2016-09-30 17:55 ` [PATCH 1/3] Remove support for obsolete x86 -malign-foo options Denys Vlasenko
2016-09-30 17:58 ` [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] Denys Vlasenko
2016-10-06 9:47 ` Bernd Schmidt
2016-10-06 18:43 ` Denys Vlasenko [this message]
2016-09-30 18:05 ` [PATCH 2/3] Temporary remove "at least 8 byte alignment" code from x86 Denys Vlasenko
2016-10-12 20:53 [PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 4 Denys Vlasenko
2016-10-12 20:53 ` [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] Denys Vlasenko
2017-04-17 15:57 [PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 7 Denys Vlasenko
2017-04-17 16:20 ` [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] Denys Vlasenko
2017-04-17 20:02 ` Sandra Loosemore
2017-04-18 18:30 ` Denys Vlasenko
2017-04-18 18:30 [PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 8 Denys Vlasenko
2017-04-18 18:46 ` [PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] Denys Vlasenko
2017-04-18 19:12 ` Sandra Loosemore
2018-05-25 11:04 [PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 9 marxin
2018-05-25 11:04 ` [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]] marxin
2018-06-29 19:05 ` Jeff Law
2018-07-03 8:53 ` Martin Liška
2018-07-03 9:55 ` Segher Boessenkool
2018-07-03 10:16 ` Martin Liška
2018-07-03 10:58 ` Segher Boessenkool
2018-07-03 12:51 ` Martin Liška
2018-07-03 13:23 ` Segher Boessenkool
2018-07-03 19:12 ` Martin Liška
2018-07-04 0:20 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d999546-480a-52e8-1785-42086d7fae66@redhat.com \
--to=dvlasenk@redhat.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).