* [PATCH, obvious] rs6000: Update ELFv2 stack frame comment showing the correct ROP save location
@ 2024-06-07 20:59 Peter Bergner
0 siblings, 0 replies; only message in thread
From: Peter Bergner @ 2024-06-07 20:59 UTC (permalink / raw)
To: Segher Boessenkool, Kewen.Lin; +Cc: GCC Patches
I consider this one obvious, so I plan on pushing this soonish.
Peter
The ELFv2 stack frame layout comment in rs6000-logue.cc shows the ROP
hash save slot in the wrong location. Update the comment to show the
correct ROP hash save location in the frame.
gcc/
* config/rs6000/rs6000-logue.cc (rs6000_stack_info): Update comment.
diff --git a/gcc/config/rs6000/rs6000-logue.cc b/gcc/config/rs6000/rs6000-logue.cc
index bd5d56ba002..0ef309e043b 100644
--- a/gcc/config/rs6000/rs6000-logue.cc
+++ b/gcc/config/rs6000/rs6000-logue.cc
@@ -591,21 +591,21 @@ rs6000_savres_strategy (rs6000_stack_t *info,
+---------------------------------------+
| Parameter save area (+padding*) (P) | 32
+---------------------------------------+
- | Optional ROP hash slot (R) | 32+P
+ | Alloca space (A) | 32+P
+---------------------------------------+
- | Alloca space (A) | 32+P+R
+ | Local variable space (L) | 32+P+A
+---------------------------------------+
- | Local variable space (L) | 32+P+R+A
+ | Optional ROP hash slot (R) | 32+P+A+L
+---------------------------------------+
- | Save area for AltiVec registers (W) | 32+P+R+A+L
+ | Save area for AltiVec registers (W) | 32+P+A+L+R
+---------------------------------------+
- | AltiVec alignment padding (Y) | 32+P+R+A+L+W
+ | AltiVec alignment padding (Y) | 32+P+A+L+R+W
+---------------------------------------+
- | Save area for GP registers (G) | 32+P+R+A+L+W+Y
+ | Save area for GP registers (G) | 32+P+A+L+R+W+Y
+---------------------------------------+
- | Save area for FP registers (F) | 32+P+R+A+L+W+Y+G
+ | Save area for FP registers (F) | 32+P+A+L+R+W+Y+G
+---------------------------------------+
- old SP->| back chain to caller's caller | 32+P+R+A+L+W+Y+G+F
+ old SP->| back chain to caller's caller | 32+P+A+L+R+W+Y+G+F
+---------------------------------------+
* If the alloca area is present, the parameter save area is
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-06-07 20:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-07 20:59 [PATCH, obvious] rs6000: Update ELFv2 stack frame comment showing the correct ROP save location Peter Bergner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).