From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 655DE3858D1E for ; Fri, 30 Sep 2022 12:25:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 655DE3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28UCDg25031402; Fri, 30 Sep 2022 12:25:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=jYaJZmEfUEas77DtbyUxxcTRIgvOH6FKSGEh0IFLs1E=; b=JEJlJngKlDbUzJNgdq/ij1EbIbe2gUdMMBmbjp7UEjq8wEVGI+MAQbE72UbB3LELx2zx D9XIHVShWNGxFIlPduZ1fRPiNW3YkRUH1fzF+n33O7Frm5BiEvmGgNL/K5t0Q4wxEl2J wmvMZjkc2W1JDTgyf+TttQjGPk2Ay2Sc9m4gRyRQIeeBduuE9Qvy2xJU0JVF4OaDEjFB 44WlKlOp08CdncQvTPTnwYxLkRbzcBzU7oNI8agUhi6mG/7zmdsdGz0Uc/HLbU04F4OK Kp79TRJ7fDw+19jhaHpIB4ltZDuHNisWZn2rHvaQjpVOLFxtRjHhTm3aPTl1xlOcSTCV BA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jx098g9dd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Sep 2022 12:25:10 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28UCEBST002260; Fri, 30 Sep 2022 12:25:10 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jx098g9cp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Sep 2022 12:25:10 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 28UCLglG020269; Fri, 30 Sep 2022 12:25:08 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3jss5j83py-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Sep 2022 12:25:08 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 28UCP6Iu66060686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Sep 2022 12:25:06 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2E23E52052; Fri, 30 Sep 2022 12:25:06 +0000 (GMT) Received: from [9.197.236.39] (unknown [9.197.236.39]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6A01F5204E; Fri, 30 Sep 2022 12:25:04 +0000 (GMT) Message-ID: <9dc150c2-03ae-42cf-2ef5-16914a776c9a@linux.ibm.com> Date: Fri, 30 Sep 2022 20:25:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000/test: Adjust pr104992.c with vect_int_mod [PR106516] Content-Language: en-US To: Segher Boessenkool Cc: GCC Patches , Richard Biener , David Edelsohn , Richard Sandiford References: <1fb4035e-a15e-5031-3b2f-9ba5dfcb1786@linux.ibm.com> <20220928145518.GQ25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20220928145518.GQ25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BaHZmo0gnCpZXtu54cIfqWmnYVffeBqx X-Proofpoint-GUID: 0myMcaYi5Mu4hyCP1pvOf1kQC5LrDa-t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-30_04,2022-09-29_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209300076 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher! on 2022/9/28 22:55, Segher Boessenkool wrote: > Hi! > > On Wed, Aug 24, 2022 at 04:17:55PM +0800, Kewen.Lin wrote: >> As PR106516 shows, we can get unexpected gimple outputs for >> function thud on some target which supports modulus operation >> for vector int. This patch introduces one effective target >> vect_int_mod for it, then adjusts the test case with it. > >> +# Return 1 if the target supports vector int modulus, 0 otherwise. >> + >> +proc check_effective_target_vect_int_mod { } { >> + return [check_cached_effective_target_indexed vect_int_mod { >> + expr { [istarget powerpc*-*-*] >> + && [check_effective_target_power10_ok] }}] >> +} > > power10_ok does not mean the vmod[su][wdq] instructions will be > generated. You need to test if we have -mcpu=power10 or such, so, > check_effective_target_has_arch_pwr10 . Indeed, the context is different from those cases in gcc.target/powerpc which have -mdejagnu-cpu=power10 normally. Thanks for catching and the correction! > > _ok tests if it is okay to enable . _hw tests if the hardware > can do . has_arch_ tests if the compiler is asked to generate > code for (which is reflected in the _ARCH_* preprocessor symbols, > hence the name). > > Okay for trunk with the correct check_effective_target_* . Thanks! > Thanks, re-tested as before, committed in r13-2983. BR, Kewen