From: Kewen Lin <linkw@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: Kewen Lin <linkw@linux.ibm.com>,
aoliva@gcc.gnu.org, olegendo@gcc.gnu.org
Subject: [PATCH 15/15] sh: Fix non-robust split condition in define_insn_and_split
Date: Thu, 11 Nov 2021 05:24:59 -0600 [thread overview]
Message-ID: <9dc4a97a785e0f7e3bda0540ffd3b95edf29ce09.1636621345.git.linkw@linux.ibm.com> (raw)
In-Reply-To: <cover.1636621345.git.linkw@linux.ibm.com>
This patch is to fix some non-robust split conditions in some
define_insn_and_splits, to make each of them applied on top of
the corresponding condition for define_insn part, otherwise the
splitting could perform unexpectedly.
gcc/ChangeLog:
* config/sh/sh.md (call_pcrel, call_value_pcrel, sibcall_pcrel,
sibcall_value_pcrel): Fix split condition.
---
gcc/config/sh/sh.md | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/config/sh/sh.md b/gcc/config/sh/sh.md
index 93ee7c9a7de..1bb325c7044 100644
--- a/gcc/config/sh/sh.md
+++ b/gcc/config/sh/sh.md
@@ -6566,7 +6566,7 @@ (define_insn_and_split "call_pcrel"
(clobber (match_scratch:SI 2 "=&r"))]
"TARGET_SH2"
"#"
- "reload_completed"
+ "&& reload_completed"
[(const_int 0)]
{
rtx lab = PATTERN (gen_call_site ());
@@ -6678,7 +6678,7 @@ (define_insn_and_split "call_value_pcrel"
(clobber (match_scratch:SI 3 "=&r"))]
"TARGET_SH2"
"#"
- "reload_completed"
+ "&& reload_completed"
[(const_int 0)]
{
rtx lab = PATTERN (gen_call_site ());
@@ -6877,7 +6877,7 @@ (define_insn_and_split "sibcall_pcrel"
(return)]
"TARGET_SH2 && !TARGET_FDPIC"
"#"
- "reload_completed"
+ "&& reload_completed"
[(const_int 0)]
{
rtx lab = PATTERN (gen_call_site ());
@@ -7043,7 +7043,7 @@ (define_insn_and_split "sibcall_value_pcrel"
(return)]
"TARGET_SH2 && !TARGET_FDPIC"
"#"
- "reload_completed"
+ "&& reload_completed"
[(const_int 0)]
{
rtx lab = PATTERN (gen_call_site ());
--
2.27.0
prev parent reply other threads:[~2021-11-11 11:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 11:24 [PATCH 00/15] " Kewen Lin
2021-11-11 11:24 ` [PATCH 01/15] frv: " Kewen Lin
2021-11-11 11:24 ` [PATCH 02/15] m32c: " Kewen Lin
2021-11-11 11:24 ` [PATCH 03/15] rx: " Kewen Lin
2021-11-11 11:24 ` [PATCH 04/15] s390: " Kewen Lin
2021-11-11 11:24 ` [PATCH 05/15] v850: " Kewen Lin
2021-11-11 11:24 ` [PATCH 06/15] visium: " Kewen Lin
2021-11-16 16:57 ` Eric Botcazou
2021-11-17 6:06 ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 07/15] xtensa: " Kewen Lin
2021-11-19 22:26 ` augustine.sterling
2021-11-22 2:21 ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 08/15] alpha: " Kewen Lin
2021-11-11 11:24 ` [PATCH 09/15] arm: " Kewen Lin
2021-11-11 11:24 ` [PATCH 10/15] bfin: " Kewen Lin
2021-11-11 11:24 ` [PATCH 11/15] csky: " Kewen Lin
2021-11-11 11:24 ` [PATCH 12/15] i386: " Kewen Lin
2021-11-17 7:13 ` Uros Bizjak
2021-11-17 10:06 ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 13/15] ia64: " Kewen Lin
2021-11-11 11:24 ` [PATCH 14/15] mips: " Kewen Lin
2021-11-11 11:24 ` Kewen Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc4a97a785e0f7e3bda0540ffd3b95edf29ce09.1636621345.git.linkw@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=aoliva@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=olegendo@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).