From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] Disable tests that require fesetround() on platforms without it
Date: Tue, 3 May 2022 09:21:45 -0600 [thread overview]
Message-ID: <9de73b8a-3f70-2f6b-e0d9-0fa4298c8823@gmail.com> (raw)
In-Reply-To: <20220429234451.14068-1-palmer@rivosinc.com>
On 4/29/2022 5:44 PM, Palmer Dabbelt wrote:
> Some tests check for fenv and then proceed to use fesetround() directly,
> but some platforms (at least RISC-V soft-float) have fenv but don't
> support rounding modes. This adds a DG check that fesetround() actually
> functions, which is then used by all the tests that call fesetround()
> explicitly.
>
> gcc/testsuite/ChangeLog
>
> * lib/target-supports.exp
> (check_effective_target_fenv_setround): New function.
> * gcc.dg/torture/fp-double-convert-float-1.c: Check
> fenv_fesetround.
> * gcc.dg/torture/fp-int-convert-float128-timode-3.c: Likewise.
> * gcc.dg/torture/fp-int-convert-timode-2.c: Likewise.
> * gcc.dg/torture/fp-int-convert-timode-3.c: Likewise.
> * gcc.dg/torture/fp-int-convert-timode-4.c: Likewise.
> * gcc.dg/torture/fp-uint64-convert-double-1.c: Likewise.
> * gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise.
I think the new effective target check needs to be documented in
doc/sourcebuild.texi. With that change, this is OK.
jeff
next prev parent reply other threads:[~2022-05-03 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 23:44 Palmer Dabbelt
2022-05-03 15:21 ` Jeff Law [this message]
2022-05-13 17:28 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de73b8a-3f70-2f6b-e0d9-0fa4298c8823@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).