From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D6C9F3858C56 for ; Fri, 12 Apr 2024 04:23:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6C9F3858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6C9F3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712895790; cv=none; b=PaDLBXtqfKytKwkxJMss+N/AAjpNICZddxdioZ5zobq84XOgTdXxQKf2isFJMUyQvNM+2k9xgCJm4XTyYG5X5yVRZ72TG5a3xjpJNXy54EBnu/w8P3+wIMICqEyC/nOTKDGEdvjZlkHySKf/vl1eSe7YEERGrCKiAuXt892X6JY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712895790; c=relaxed/simple; bh=gneJckjJux7w3U37MIbpOuIY6jNZxCldGJRcDiou2dc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Wweayd1FEuWnPQC09lvmMGyfLIi5cMfmAxc3a88e5owo5n9gnapUMmCyWHNd3UeKfQdPt7fe6zdXIq0cdOKJycVUX3OdpTQwtX45E6B3NYNtBJlbHtjXau5JawFnOQjrjQqk3Gndq56KPmEo9S3H18a+9bTLsehaq15LmS375xw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43C3NU0C018130; Fri, 12 Apr 2024 04:23:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=LvrTU+svqTYPdPy8FvEUxa02xS9MiZa8erwifBWujto=; b=luH41cpkVQ/xMLW+H7uN67uFsJE9Le2pCOl3jS7B7t3xj7QONmBtKrRXZuetmOqip9SC MoyWHqU4kIjii68s4pJHAF9pcux3p5o2ZwGc8ccgkpRUCxK1RjesPgxsZ2Rt9UZUOShc NmU9YEGCoI80L8kC/WCM32oR837w4SDvogLWJBK8QGydK7VMu3usiDEdNUwsPGlmX1yJ KoTxOrGKzPzAf4LQW1IAzNis9A6a8e6NvzRaXFW8uo7e7vd4QiPs2lgdkWSBiQntRK7x UsadZJvd6i2lAe1WSpRS7sh4SsilN3AEvxoqxV077xFKw3oD/Swwj8V0w4MYDn4J9vGY DA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xev6j04p7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 04:23:07 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43C4N7to004371; Fri, 12 Apr 2024 04:23:07 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xev6j04p5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 04:23:07 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43C0cZ29022583; Fri, 12 Apr 2024 04:23:06 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xbhqpfpba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 04:23:06 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43C4N37a22676184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Apr 2024 04:23:05 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60B5158064; Fri, 12 Apr 2024 04:23:03 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF2EC5805D; Fri, 12 Apr 2024 04:23:02 +0000 (GMT) Received: from [9.61.87.235] (unknown [9.61.87.235]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 12 Apr 2024 04:23:02 +0000 (GMT) Message-ID: <9e1b8d74-8b31-41ba-a91c-6ecdf27b701a@linux.ibm.com> Date: Thu, 11 Apr 2024 23:23:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000: Add OPTION_MASK_POWER8 [PR101865] To: "Kewen.Lin" Cc: Michael Meissner , GCC Patches , David Edelsohn , Segher Boessenkool References: <5037d210-9c9b-eda9-1327-ef5b7e0ddd17@linux.ibm.com> Content-Language: en-US From: Peter Bergner In-Reply-To: <5037d210-9c9b-eda9-1327-ef5b7e0ddd17@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -yo7I4zUieE4FLjb6vJpG6-lLFgnKHns X-Proofpoint-ORIG-GUID: Pt9-ZyHXbCFF6UZmBNvv76q2uC0nRb4O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_14,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404120028 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/11/24 10:31 PM, Kewen.Lin wrote: >> The passed bootstrap and regtest on powerpc64le-linux. Ok for trunk? > > Thanks for fixing this. I guess it should go well on powerpc64-linux too, > but since it's very late stage4 now, could you also test this on BE machine? Will do, after making the changes suggested below. >> +;; This option exists only to create its MASK. It is not intended for users. >> +mdo-not-use-this-option >> +Target RejectNegative Mask(POWER8) Var(rs6000_isa_flags) WarnRemoved >> + > > I can understand the given name is to avoid users to use it, but it looks odd, personally > I'm inclined to mpower8 (or even mpower8-internal) even if it's more likely to be used but > it's a bit more meaningful (especially we already have mpower10), theoretically speaking > it's undocumented users shouldn't use it at all. Sorry, I should have mentioned this, but I originally had it -mpower8, but given it was an option we don't want users to use, Segher mentioned offline to give it a name something like the above and not -mpower8. I kind of like -mpower8-internal now that you mention it, but I'd like Segher's input here whether he prefers -mdo-not-use-this-option or -mpower8-internal or something else??? > And I think we want explicit "Undocumented" here, and WarnRemoved seems not suitable here > since it's for some option which worked before but then wasn't supported any longer, but > this one is new, may be "Warn(Don't use %qs)" instead? Oops, yes, we want Undocumented here. Thanks for catching that! Good idea on the Warn versus WarnRemoved. >> +/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O2" } */ > > Nit: -O2 looks useless and can be dropped? Ok, I'll drop it. I'll make the changes above, modulo leaving the option name unchanged until we hear from Segher on that and report back on the LE and BE testing. Thanks! Peter