* [PATCH] Fix cgraph dumping bug
@ 2014-05-09 15:53 Teresa Johnson
2014-05-09 17:50 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Teresa Johnson @ 2014-05-09 15:53 UTC (permalink / raw)
To: gcc-patches, Jan Hubicka; +Cc: David Li
Fixed a place where the wrong dump file was being used, leading to
an inconsistency and seg fault when dump_file was non-NULL but
cgraph_dump_file was NULL.
Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
Thanks,
Teresa
2014-05-09 Teresa Johnson <tejohnson@google.com>
* cgraphunit.c (analyze_functions): Use correct dump file.
Index: cgraphunit.c
===================================================================
--- cgraphunit.c (revision 210157)
+++ cgraphunit.c (working copy)
@@ -984,7 +984,7 @@ analyze_functions (void)
first_analyzed_var = varpool_first_variable ();
first_analyzed = cgraph_first_function ();
- if (changed && dump_file)
+ if (changed && cgraph_dump_file)
fprintf (cgraph_dump_file, "\n");
/* Lower representation, build callgraph edges and references
for all trivially
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix cgraph dumping bug
2014-05-09 15:53 [PATCH] Fix cgraph dumping bug Teresa Johnson
@ 2014-05-09 17:50 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2014-05-09 17:50 UTC (permalink / raw)
To: Teresa Johnson, gcc-patches, Jan Hubicka; +Cc: David Li
On May 9, 2014 5:53:06 PM CEST, Teresa Johnson <tejohnson@google.com> wrote:
>Fixed a place where the wrong dump file was being used, leading to
>an inconsistency and seg fault when dump_file was non-NULL but
>cgraph_dump_file was NULL.
>
>Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
OK.
Thanks,
Richard.
>Thanks,
>Teresa
>
>2014-05-09 Teresa Johnson <tejohnson@google.com>
>
> * cgraphunit.c (analyze_functions): Use correct dump file.
>
>Index: cgraphunit.c
>===================================================================
>--- cgraphunit.c (revision 210157)
>+++ cgraphunit.c (working copy)
>@@ -984,7 +984,7 @@ analyze_functions (void)
> first_analyzed_var = varpool_first_variable ();
> first_analyzed = cgraph_first_function ();
>
>- if (changed && dump_file)
>+ if (changed && cgraph_dump_file)
> fprintf (cgraph_dump_file, "\n");
>
> /* Lower representation, build callgraph edges and references
>for all trivially
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-09 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-09 15:53 [PATCH] Fix cgraph dumping bug Teresa Johnson
2014-05-09 17:50 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).