From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-366998-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 20014 invoked by alias); 9 May 2014 17:50:03 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 19924 invoked by uid 89); 9 May 2014 17:50:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ee0-f41.google.com
Received: from mail-ee0-f41.google.com (HELO mail-ee0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 09 May 2014 17:50:01 +0000
Received: by mail-ee0-f41.google.com with SMTP id t10so2964143eei.28        for <gcc-patches@gcc.gnu.org>; Fri, 09 May 2014 10:49:58 -0700 (PDT)
X-Received: by 10.14.177.195 with SMTP id d43mr14856241eem.105.1399657798536;        Fri, 09 May 2014 10:49:58 -0700 (PDT)
Received: from android-4c5a376a18c0e957.fritz.box (p54958917.dip0.t-ipconnect.de. [84.149.137.23])        by mx.google.com with ESMTPSA id o5sm12856164eeg.8.2014.05.09.10.49.56        for <multiple recipients>        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);        Fri, 09 May 2014 10:49:57 -0700 (PDT)
User-Agent: K-9 Mail for Android
In-Reply-To: <CAAe5K+X3VJZDc7Ru4Y30c=m_NnBLOC_OzYPLYxhaxavkQB3GMw@mail.gmail.com>
References: <CAAe5K+X3VJZDc7Ru4Y30c=m_NnBLOC_OzYPLYxhaxavkQB3GMw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PATCH] Fix cgraph dumping bug
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 09 May 2014 17:50:00 -0000
To: Teresa Johnson <tejohnson@google.com>,"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,Jan Hubicka <hubicka@ucw.cz>
CC: David Li <davidxl@google.com>
Message-ID: <9e21cd78-1f03-4c11-bca1-60a34b73e69a@email.android.com>
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00613.txt.bz2

On May 9, 2014 5:53:06 PM CEST, Teresa Johnson <tejohnson@google.com> wrote:
>Fixed a place where the wrong dump file was being used, leading to
>an inconsistency and seg fault when dump_file was non-NULL but
>cgraph_dump_file was NULL.
>
>Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?

OK.

Thanks,
Richard.

>Thanks,
>Teresa
>
>2014-05-09  Teresa Johnson  <tejohnson@google.com>
>
>        * cgraphunit.c (analyze_functions): Use correct dump file.
>
>Index: cgraphunit.c
>===================================================================
>--- cgraphunit.c        (revision 210157)
>+++ cgraphunit.c        (working copy)
>@@ -984,7 +984,7 @@ analyze_functions (void)
>       first_analyzed_var = varpool_first_variable ();
>       first_analyzed = cgraph_first_function ();
>
>-      if (changed && dump_file)
>+      if (changed && cgraph_dump_file)
>        fprintf (cgraph_dump_file, "\n");
>
>       /* Lower representation, build callgraph edges and references
>for all trivially