From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 8B16C3858D32 for ; Tue, 18 Oct 2022 19:27:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B16C3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,194,1661846400"; d="diff'?scan'208";a="84816464" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 18 Oct 2022 11:27:30 -0800 IronPort-SDR: oWl+HbCCHmhB56vtHDfs2D1FlG8EjqYgD5lizzTX3ZLhwc0wfmTeBtiLDKX1LwmMyk9exu6exW zf/BucZzrxakHD5aUSH7U/fpgOnrsSw+famgM291hs0ocauYc1rpY4vmK8lsBSvszLFGAXYVVp Nna8aCrom1bMND6LkT76CQCQL0D0gi7904wjlpZgmCsoJrDuyC+w93GBxUDGwLxmJTvB2XcGoa AIziAzNOCz0nB4bv5kXcgeM0ifnhmCfF4yI9dtMaoT35FkMlTjeqV4BdwFX5AkDHV/pYh2CsSH mqI= Content-Type: multipart/mixed; boundary="------------vqqVgOYTQ8olPDaE1ZBmnwZ0" Message-ID: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com> Date: Tue, 18 Oct 2022 21:27:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: gcc-patches , Jakub Jelinek From: Tobias Burnus Subject: [Patch] OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236] X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------vqqVgOYTQ8olPDaE1ZBmnwZ0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Found when playing around with reverse offload once I used 'omp target para= llel'. The other issue showed up when running the testsuite (which is done with -O= 2). In all cases, the ICE is in expand_GOMP_TARGET_REV of this IFN, which shoul= d be unreachable Note: ENABLE_OFFLOADING inside the compiler must evaluate to true to show u= p as ICE - otherwise, the IFN is not even generated. I did not see a good reason for DECL_CONTEXT =3D NULL, thus, I now set it t= o the same as was set for child_fn - for no good reason. Tested on x86-64 with ENABLE_OFFLOADING albeit without true offloading. OK for mainline? Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------vqqVgOYTQ8olPDaE1ZBmnwZ0 Content-Type: text/x-patch; charset="UTF-8"; name="omp-rev-off-parallel.diff" Content-Disposition: attachment; filename="omp-rev-off-parallel.diff" Content-Transfer-Encoding: base64 T3Blbk1QOiBGaXggcmV2ZXJzZSBvZmZsb2FkIEdPTVBfVEFSR0VUX1JFViBJRk4gY29ybmVy IGNhc2VzIFtQUjEwNzIzNl0KCkZvciAndGFyZ2V0IHBhcmFsbGVsJyBhbmQgc2ltaWxhcmx5 IG5lc3RlZCBkaXJlY3RpdmVzLCBjZ3JhcGhfbm9kZSdzCmNhbGxzX2RlY2xhcmVfdmFyaWFu dF9hbHQgd2FzIG5vdCBzZXQgaW4gdGhlIHBhcmVudCByZWdpb24gbm9kZSBidXQgaW4KY2Z1 bi0+ZGVjbC4gSGVuY2UsIHBhc3Nfb21wX2RldmljZV9sb3dlciBkaWQgbm90IHByb2Nlc3Mg aGFuZGxlIHRoZQppbnRlcm5hbCBmdW5jdGlvbiBHT01QX1RBUkdFVF9SRVYuIC0gU29sdXRp b24gaXMgdG8gc2V0IGl0IHRvIHRoZQpERUNMX0NPTlRFWFQsIHdoaWNoIGlzIHNldCBpbiBh ZGp1c3RfY29udGV4dF9hbmRfc2NvcGUuCgpUaGUgY2dyYXBoX25vZGU6OmNyZWF0ZV9jbG9u ZSBpc3N1ZSBpcyBleHBvc2VkIHdpdGggLU8yIGZvciB0aGUgZXhpc3RpbmcKbGliZ29tcC5m b3J0cmFuL3JldmVyc2Utb2ZmbG9hZC0xLmY5MC4KCm9tcC1vZmZsb2FkLmNjCgoJUFIgbWlk ZGxlLWVuZC8xMDcyMzYKCmdjYy9DaGFuZ2VMb2c6CgkqIG9tcC1leHBhbmQuY2MgKGV4cGFu ZF9vbXBfdGFyZ2V0KTogU2V0IGNhbGxzX2RlY2xhcmVfdmFyaWFudF9hbHQKCWluIERFQ0xf Q09OVEVYVCBhbmQgbm90IHRvIGNmdW4tPmRlY2wuCgkqIGNncmFwaGNsb25lcy5jYyAoY2dy YXBoX25vZGU6OmNyZWF0ZV9jbG9uZSk6IENvcHkgYWxzbyB0aGUKCW5vZGUncyBjYWxsc19k ZWNsYXJlX3ZhcmlhbnRfYWx0IHZhbHVlLgoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VMb2c6Cgkq IGdmb3J0cmFuLmRnL2dvbXAvdGFyZ2V0LWRldmljZS1hbmNlc3Rvci02LmY5MDogTmV3IHRl c3QuCgogZ2NjL2NncmFwaGNsb25lcy5jYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAxICsKIGdjYy9vbXAtZXhwYW5kLmNjICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAxMyArKysrKystLS0tLS0tCiAuLi4vZ2ZvcnRyYW4uZGcv Z29tcC90YXJnZXQtZGV2aWNlLWFuY2VzdG9yLTYuZjkwICAgICAgIHwgMTcgKysrKysrKysr KysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9nY2MvY2dyYXBoY2xvbmVzLmNjIGIvZ2NjL2NncmFwaGNs b25lcy5jYwppbmRleCBlYjBmYTg3YjU1NC4uYmI0YjNjNTQwN2QgMTAwNjQ0Ci0tLSBhL2dj Yy9jZ3JhcGhjbG9uZXMuY2MKKysrIGIvZ2NjL2NncmFwaGNsb25lcy5jYwpAQCAtMzc1LDYg KzM3NSw3IEBAIGNncmFwaF9ub2RlOjpjcmVhdGVfY2xvbmUgKHRyZWUgbmV3X2RlY2wsIHBy b2ZpbGVfY291bnQgcHJvZl9jb3VudCwKICAgaWYgKCFuZXdfaW5saW5lZF90bykKICAgICBw cm9mX2NvdW50ID0gY291bnQuY29tYmluZV93aXRoX2lwYV9jb3VudCAocHJvZl9jb3VudCk7 CiAgIG5ld19ub2RlLT5jb3VudCA9IHByb2ZfY291bnQ7CisgIG5ld19ub2RlLT5jYWxsc19k ZWNsYXJlX3ZhcmlhbnRfYWx0ID0gdGhpcy0+Y2FsbHNfZGVjbGFyZV92YXJpYW50X2FsdDsK IAogICAvKiBVcGRhdGUgSVBBIHByb2ZpbGUuICBMb2NhbCBwcm9maWxlcyBuZWVkIG5vIHVw ZGF0aW5nIGluIG9yaWdpbmFsLiAgKi8KICAgaWYgKHVwZGF0ZV9vcmlnaW5hbCkKZGlmZiAt LWdpdCBhL2djYy9vbXAtZXhwYW5kLmNjIGIvZ2NjL29tcC1leHBhbmQuY2MKaW5kZXggNWRj MGJmMTZlMTcuLmM2MzZhMTc0ZTM2IDEwMDY0NAotLS0gYS9nY2Mvb21wLWV4cGFuZC5jYwor KysgYi9nY2Mvb21wLWV4cGFuZC5jYwpAQCAtMTAwNTQsMTMgKzEwMDU0LDggQEAgZXhwYW5k X29tcF90YXJnZXQgKHN0cnVjdCBvbXBfcmVnaW9uICpyZWdpb24pCiAKICAgICAgIC8qIEhh bmRsZSB0aGUgY2FzZSB0aGF0IGFuIGlubmVyIGFuY2VzdG9yOjEgdGFyZ2V0IGlzIGNhbGxl ZCBieSBhbiBvdXRlcgogCSB0YXJnZXQgcmVnaW9uLiAqLwotICAgICAgaWYgKCFpc19hbmNl c3RvcikKLQljZ3JhcGhfbm9kZTo6Z2V0IChjaGlsZF9mbiktPmNhbGxzX2RlY2xhcmVfdmFy aWFudF9hbHQKLQkgIHw9IGNncmFwaF9ub2RlOjpnZXQgKGNmdW4tPmRlY2wpLT5jYWxsc19k ZWNsYXJlX3ZhcmlhbnRfYWx0OwotICAgICAgZWxzZSAgLyogRHVwbGljYXRlIGZ1bmN0aW9u IHRvIGNyZWF0ZSBlbXB0eSBub25ob3N0IHZhcmlhbnQuICovCisgICAgICBpZiAoaXNfYW5j ZXN0b3IpCiAJewotCSAgLyogRW5hYmxlIHBhc3Nfb21wX2RldmljZV9sb3dlciBwYXNzLiAg Ki8KLQkgIGNncmFwaF9ub2RlOjpnZXQgKGNmdW4tPmRlY2wpLT5jYWxsc19kZWNsYXJlX3Zh cmlhbnRfYWx0ID0gMTsKIAkgIGNncmFwaF9ub2RlICpmbjJfbm9kZTsKIAkgIGNoaWxkX2Zu MiA9IGJ1aWxkX2RlY2wgKERFQ0xfU09VUkNFX0xPQ0FUSU9OIChjaGlsZF9mbiksCiAJCQkJ ICBGVU5DVElPTl9ERUNMLApAQCAtMTAwNzQsNyArMTAwNjksNyBAQCBleHBhbmRfb21wX3Rh cmdldCAoc3RydWN0IG9tcF9yZWdpb24gKnJlZ2lvbikKIAkgIFRSRUVfUFVCTElDIChjaGls ZF9mbjIpID0gMDsKIAkgIERFQ0xfVU5JTkxJTkFCTEUgKGNoaWxkX2ZuMikgPSAxOwogCSAg REVDTF9FWFRFUk5BTCAoY2hpbGRfZm4yKSA9IDA7Ci0JICBERUNMX0NPTlRFWFQgKGNoaWxk X2ZuMikgPSBOVUxMX1RSRUU7CisJICBERUNMX0NPTlRFWFQgKGNoaWxkX2ZuMikgPSBERUNM X0NPTlRFWFQgKGNoaWxkX2ZuKTsKIAkgIERFQ0xfSU5JVElBTCAoY2hpbGRfZm4yKSA9IG1h a2Vfbm9kZSAoQkxPQ0spOwogCSAgQkxPQ0tfU1VQRVJDT05URVhUIChERUNMX0lOSVRJQUwg KGNoaWxkX2ZuMikpID0gY2hpbGRfZm4yOwogCSAgREVDTF9BVFRSSUJVVEVTIChjaGlsZF9m bikKQEAgLTEwMDk4LDYgKzEwMDkzLDEwIEBAIGV4cGFuZF9vbXBfdGFyZ2V0IChzdHJ1Y3Qg b21wX3JlZ2lvbiAqcmVnaW9uKQogCSAgZm4yX25vZGUtPmZvcmNlX291dHB1dCA9IDE7CiAJ ICBub2RlLT5vZmZsb2FkYWJsZSA9IDA7CiAKKwkgIC8qIEVuYWJsZSBwYXNzX29tcF9kZXZp Y2VfbG93ZXIgcGFzcy4gICovCisJICBmbjJfbm9kZSA9IGNncmFwaF9ub2RlOjpnZXQgKERF Q0xfQ09OVEVYVCAoY2hpbGRfZm4pKTsKKwkgIGZuMl9ub2RlLT5jYWxsc19kZWNsYXJlX3Zh cmlhbnRfYWx0ID0gMTsKKwogCSAgdCA9IGJ1aWxkX2RlY2wgKERFQ0xfU09VUkNFX0xPQ0FU SU9OIChjaGlsZF9mbiksCiAJCQkgIFJFU1VMVF9ERUNMLCBOVUxMX1RSRUUsIHZvaWRfdHlw ZV9ub2RlKTsKIAkgIERFQ0xfQVJUSUZJQ0lBTCAodCkgPSAxOwpkaWZmIC0tZ2l0IGEvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9nb21wL3RhcmdldC1kZXZpY2UtYW5jZXN0b3ItNi5m OTAgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2dvbXAvdGFyZ2V0LWRldmljZS1hbmNl c3Rvci02LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uODIx ZTc4NTJlODUKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L2dvbXAvdGFyZ2V0LWRldmljZS1hbmNlc3Rvci02LmY5MApAQCAtMCwwICsxLDE3IEBACish IFBSIG1pZGRsZS1lbmQvMTA3MjM2CisKKyEgRGlkIElDRSBiZWZvcmUgYmVjYXVzZSBJRk4g LkdPTVBfVEFSR0VUX1JFViB3YXMgbm90CishIHByb2Nlc3NlZCBpbiBvbXAtb2ZmbG9hZC5j Yy4KKyEgTm90ZTogVGVzdCByZXF1aXJlZCBFTkFCTEVfT0ZGTE9BRElORyBiZWluZyB0cnVl IGluc2lkZSBHQ0MuCisKK2ltcGxpY2l0IG5vbmUKKyEkb21wIHJlcXVpcmVzIHJldmVyc2Vf b2ZmbG9hZAorISRvbXAgdGFyZ2V0IHBhcmFsbGVsIG51bV90aHJlYWRzKDQpCisgICEkb21w IHRhcmdldCBkZXZpY2UoYW5jZXN0b3I6MSkKKyAgICBjYWxsIGZvbygpCisgICEkb21wIGVu ZCB0YXJnZXQgCishJG9tcCBlbmQgdGFyZ2V0IHBhcmFsbGVsCitjb250YWlucworICBzdWJy b3V0aW5lIGZvbworICBlbmQKK2VuZAo= --------------vqqVgOYTQ8olPDaE1ZBmnwZ0--