From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B8CD63855005 for ; Tue, 27 Jul 2021 17:41:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8CD63855005 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16RHbKA5106131; Tue, 27 Jul 2021 13:41:37 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 3a2nsktb79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 13:41:34 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16RHSKLn026903; Tue, 27 Jul 2021 17:38:05 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma01dal.us.ibm.com with ESMTP id 3a2362dq8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 17:38:05 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16RHc3MX34996534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 17:38:03 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 988887805C; Tue, 27 Jul 2021 17:38:03 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73FAB78068; Tue, 27 Jul 2021 17:38:03 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.91.192]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 27 Jul 2021 17:38:03 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 23/55] rs6000: Incorporate new builtins code into the build machinery To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org References: <4f27468885fd84aba5f0dc2369a284f3cffa2b34.1623941441.git.wschmidt@linux.ibm.com> <20210721185830.GK1583@gate.crashing.org> <20210727142300.GW1583@gate.crashing.org> From: Bill Schmidt Message-ID: <9e3315b7-4766-4ca6-34af-8eb7abad69f0@linux.ibm.com> Date: Tue, 27 Jul 2021 12:38:02 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210727142300.GW1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-GUID: xMqATPso-qgksxQcxgOcfl4zqzTc2F-8 X-Proofpoint-ORIG-GUID: xMqATPso-qgksxQcxgOcfl4zqzTc2F-8 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-27_10:2021-07-27, 2021-07-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 spamscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107270105 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 17:41:38 -0000 Hi Segher, On 7/27/21 9:23 AM, Segher Boessenkool wrote: > On Mon, Jul 26, 2021 at 10:26:25PM -0500, Bill Schmidt wrote: >> Right now I just make the two generated >> .h files depend on the generated .c file, which works since they are all >> generated together or none of them are generated.  That seems simple >> enough and more self-documenting to me. > It only works if you make sure the updates to the .c file are always > seen by make only after the updates to the .h files are visible. The > window in which it can race is small, but you have to make it empty :-( > > If you can guarantee that (ordering the fclose()s appropriately is > enough I believe -- and add a comment for that :-) ) this should be > fine, sure. > Good point.  I have a small race because rs6000-builtins.c isn't closed after rs6000-vecdefines.h.  I'll repair that as part of this patch and add commentary. Thanks again for the review! Bill