public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@mengyan1223.wang>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: Matthew Fortune <mfortune@gmail.com>,
	gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@gcc.gnu.org>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: committed: [PATCH] mips: Fix up mips_atomic_assign_expand_fenv [PR94780]
Date: Sat, 31 Jul 2021 02:08:19 +0800	[thread overview]
Message-ID: <9e5d7876de629b60a5404b2b33871a5d97b6d207.camel@mengyan1223.wang> (raw)
In-Reply-To: <8d76a84a712bbef5adc6d540d49f2728b98fed0a.camel@mengyan1223.wang>

On Fri, 2021-07-30 at 16:23 +0800, Xi Ruoyao via Gcc-patches wrote:
> On Fri, 2021-07-30 at 09:11 +0100, Richard Sandiford wrote:
> > Xi Ruoyao <xry111@mengyan1223.wang> writes:
> > > Ping again.
> > > 
> > > On Wed, 2021-06-23 at 11:11 +0800, Xi Ruoyao wrote:
> > > > Commit message shamelessly copied from 1777beb6b129 by jakub:
> > > > 
> > > > This function, because it is sometimes called even outside of
> > > > function
> > > > bodies, uses create_tmp_var_raw rather than create_tmp_var.  But
> > > > in
> > > > order
> > > > for that to work, when first referenced, the VAR_DECLs need to
> > > > appear
> > > > in a
> > > > TARGET_EXPR so that during gimplification the var gets the right
> > > > DECL_CONTEXT and is added to local decls.
> > > > 
> > > > Bootstrapped & regtested on mips64el-linux-gnu.  Ok for trunk
> > > > and
> > > > backport
> > > > to 11, 10, and 9?
> > 
> > OK for all, thanks.
> > 
> > Similar comments to the previous message about the appropriateness
> > of me reviewing the patch, but like you say, this is doing for MIPS
> > what we've already had to do for other targets.
> 
> Thanks for reviewing.
> 
> Will bootstrap and test it again, and commit if there is no
> regressions.

Committed to master at 20656544 and releases/gcc-11 at 7db1795a.

Will do it for gcc-10 and gcc-9 tomorrow.


  reply	other threads:[~2021-07-30 18:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  3:11 Xi Ruoyao
2021-06-28 13:50 ` PING: " Xi Ruoyao
2021-07-09  6:51   ` PING^2: " Xi Ruoyao
2021-07-16  5:53 ` PING^3: " Xi Ruoyao
2021-07-23 12:47 ` PING^4: " Xi Ruoyao
2021-07-30  4:56 ` PING^5: " Xi Ruoyao
2021-07-30  8:11   ` Richard Sandiford
2021-07-30  8:23     ` Xi Ruoyao
2021-07-30 18:08       ` Xi Ruoyao [this message]
2021-07-31 10:27         ` committed: " Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e5d7876de629b60a5404b2b33871a5d97b6d207.camel@mengyan1223.wang \
    --to=xry111@mengyan1223.wang \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@gcc.gnu.org \
    --cc=macro@orcam.me.uk \
    --cc=mfortune@gmail.com \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).