From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 20F75385840F for ; Mon, 22 Apr 2024 02:59:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20F75385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 20F75385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713754748; cv=none; b=Gt//9s05nL3p+DC+9t0cPfXyn3BHeaAu7qjVLR7A2TUU6xN4s5eE2VRLxfDmYCfm5VkqoCKHVGpE8/pAQWRQGZBqVF+AS+Fd+Ovv7VrHsfZMgZRKaAOl/EH0RipwqxIJKl2IrYWgZiA7cguEGDzxAOu7JuzQlGQFG17r5iLB9r4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713754748; c=relaxed/simple; bh=yAZuDGraDEhRkOYXc8Rt8xeMa2jc1tJpu94ON9WZtiw=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=HQPVjN99zXHmtYBWg/MaNlzEA/urq2WjRi1XkKZygTQoFDq8wTJpmHdVdNd7dBPfxec6aWk7M8nsinlF0yped36azcorvF/cLbvOSclOsjSeVsDCgFJ0UW6dnIxwtwaD+qe5dgRoX/TEckBdDI590xPAbMz9SQopd7PHSK3F2jY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713754745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=09rs3MuSypr9XBhLUtT0qL6aMVh3jzpuO4rD0n6Jcgw=; b=gA1/SAaJF52HjpmkL7cIvI2igk1fnUxR/sGvFBq1d7QphcIsE7i4fBoGe+p2xDDg6bLCVG adhRCqNuWHmtlQ1saHlEsHGpVUT8RJshplW3QF/UEw9U1xcPPizNlHDIVfeg7beh1ErQBx u0NKRlOKMNFfAUBrPraB+yK73PkBXqo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-upggUd-fMgO04SSynsgMFg-1; Sun, 21 Apr 2024 22:59:02 -0400 X-MC-Unique: upggUd-fMgO04SSynsgMFg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-434ea70629fso52177201cf.3 for ; Sun, 21 Apr 2024 19:59:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713754741; x=1714359541; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=09rs3MuSypr9XBhLUtT0qL6aMVh3jzpuO4rD0n6Jcgw=; b=PdFOFd8n0zY5M5LWiOTTq9JhypEUplwhI+I75DF7Be6l0fLcoU+IJBUGz7pcjdBWQw tNvaayrSf1ltZrQeV2GA8vclcVUHtSdLG3bWbyTuSHmyh1kEldlCmuPpeqFV9qlQs3Qb Z+THKned9v2cFe6tJ2jYycIApyz7Gu/URJAS9chkTrjEopqb6vDcl6xOYzex9lKgoaQk TpVnDNH7IeiLxSbPgdK9b5cm+hDvKtXWOkOCMF12xG7Brg0yt2YO4tIz7RkIjrdKq2y4 UwJfT+gbrV+mkPk0k9umCNKzBOqyiCtg4f9Vn5+adWPgilWGWUIeivoFG612X1HgZjza WpnQ== X-Gm-Message-State: AOJu0Ywqh1OOjL1mm0nrZdSSb2XsH02DC9tiS/IltLqr8BJY1pJUxoEu 8i6bH0lUXYEPdDWo9erkVIYQ9Y3i43UzRdSCW9u3MPKvPSRirwZaWT8Kg7ccKqD2Jijahq9AuIE kM0xVanlcCFSqtw8VPtixl1paAIZzyB3SvoQ7V/pn4VijtA7pk0kVikk= X-Received: by 2002:a0c:ef81:0:b0:69b:5410:df8d with SMTP id w1-20020a0cef81000000b0069b5410df8dmr9068033qvr.41.1713754741608; Sun, 21 Apr 2024 19:59:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5n/U29H9IxqY3nWo7L03rAu9rTuZcpn2nP/2QZi9h3+fvKq+XkCSkqoR/q4PoGhob32CiDw== X-Received: by 2002:a0c:ef81:0:b0:69b:5410:df8d with SMTP id w1-20020a0cef81000000b0069b5410df8dmr9068021qvr.41.1713754741313; Sun, 21 Apr 2024 19:59:01 -0700 (PDT) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id q2-20020a0c8cc2000000b006a04dacd0e5sm2771218qvb.86.2024.04.21.19.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 19:59:01 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Sun, 21 Apr 2024 22:59:00 -0400 (EDT) To: Nathaniel Shead cc: gcc-patches@gcc.gnu.org, Jason Merrill Subject: Re: [PATCH] c++: Fix ICE with xobj parms and maybe incomplete decl-specifiers In-Reply-To: <66237f1b.630a0220.ed3e.fd8b@mx.google.com> Message-ID: <9e62be06-2554-82ad-071b-f83f4c61b7e6@idea> References: <66237f1b.630a0220.ed3e.fd8b@mx.google.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > -- >8 -- > > This fixes a null dereference issue when decl_specifiers.type is not yet > provided. > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_parameter_declaration): Check if > decl_specifiers.type is null. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp23/explicit-obj-basic7.C: New test. LGTM > > Signed-off-by: Nathaniel Shead > --- > gcc/cp/parser.cc | 5 +++-- > gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C | 9 +++++++++ > 2 files changed, 12 insertions(+), 2 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C > > diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc > index 50d3ad35b61..97ee2650dc4 100644 > --- a/gcc/cp/parser.cc > +++ b/gcc/cp/parser.cc > @@ -25780,8 +25780,9 @@ cp_parser_parameter_declaration (cp_parser *parser, > } > > if (xobj_param_p > - && (declarator ? declarator->parameter_pack_p > - : PACK_EXPANSION_P (decl_specifiers.type))) > + && ((declarator && declarator->parameter_pack_p) > + || (decl_specifiers.type > + && PACK_EXPANSION_P (decl_specifiers.type)))) > { > location_t xobj_param > = make_location (decl_specifiers.locations[ds_this], > diff --git a/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C b/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C > new file mode 100644 > index 00000000000..a474e97fc18 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp23/explicit-obj-basic7.C > @@ -0,0 +1,9 @@ > +// { dg-do compile { target c++23 } } > + > +// Shouldn't ICE > +struct S { > + void a(this long); > + void b(this const long); > + void c(this long unsigned); > + void c(this signed); > +}; > -- > 2.43.2 > >