From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69744 invoked by alias); 13 Feb 2018 15:49:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69066 invoked by uid 89); 13 Feb 2018 15:49:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 15:49:04 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0262C065F69; Tue, 13 Feb 2018 15:49:02 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-36.rdu2.redhat.com [10.10.112.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id E04DF5C259; Tue, 13 Feb 2018 15:49:01 +0000 (UTC) Subject: Re: Fix VR_ANTI_RANGE handling in intersect_range_with_nonzero_bits (PR 84321) To: Richard Biener , GCC Patches , Richard Sandiford References: <87sha69qfc.fsf@linaro.org> From: Jeff Law Message-ID: <9e661d7f-2e3d-0390-fcbb-be662ac9f577@redhat.com> Date: Tue, 13 Feb 2018 15:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00737.txt.bz2 On 02/13/2018 08:26 AM, Richard Biener wrote: > On Mon, Feb 12, 2018 at 4:29 PM, Richard Sandiford > wrote: >> VR_ANTI_RANGE is basically a union of two ranges, and although >> intersect_range_with_nonzero_bits had code to deal with the upper >> one being empty, it didn't handle the lower one being empty. >> There were also some off-by-one errors. >> >> This patch rewrites the code in a hopefully clearer way. >> >> Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? > > Ok. And committed. jeff