From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 180933858C62 for ; Tue, 21 May 2024 17:38:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 180933858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 180933858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716313135; cv=none; b=jlFgOdRd/wsc/3OCIvl7gdWfkauM7Mbu5OYbH2wEgxrE5R1z4yTEcLS9zLX6jRspk2vXIjwGkcaJNPHPrxgaqmphc4zqFyY02AK3KpHbYNROjeLC3vEwJGcDWn8KW0yhqsZ+ZMCnR3BmRZhCLptXB2TiV1Yno7kHGrBeKRSejwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716313135; c=relaxed/simple; bh=PaPJvGTGeNQMdN4+rf9QGWtpCV0wKeaG1sqtzN0Q2b4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=v0ZwZxOdFaZEbEfeTBMC+9EDzVtxlhu02z12Lkue0t3sMy30ttiRflYGQGRb7GjbJ5xMvgnDNwXaO/XMiP3cS6WonmcNsUS5uufSduqttTWK2KOxNTbTIRY6J+IoZG/4jYiepoJS6sgF+vHf+ER8/eawLANLBxq8sjxtzoHkamM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2bd70bd741bso46595a91.1 for ; Tue, 21 May 2024 10:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716313133; x=1716917933; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wM2j6nlYzBd1zzynBQl7kEA/33RwxYUbhIPbLjdccFg=; b=OafU216AJPTfPSFCrU1jGe511hb69mzd++Lu5XjUukfCIja/tz8q1AnuLek+bObvxX h9R/0Osflq7yhxNj5nUorYkYE9O1sOyMwOLGiWda4dxurrCZX19HWBfMEKwkH3q2tZ0T z+/8g5BNxl0eREUAFiri1lN2f5VwASn3EEhEOq2ycfR2jiuSS1MjeqEG5uw2IEuDeKIt Pt65YjTbS4VHzqSEIWkOreR0fhhLSQWxmTxYwep4w4u1FDwqiIO9ls6gcQmM/+QcexOj 9Mc5rS6OuvIAoo3RvfDaxsC7rbuMN0QbHT0Az+3f8MhoErWk6WtOVRoz8YXaGHFQkjQE kZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716313133; x=1716917933; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wM2j6nlYzBd1zzynBQl7kEA/33RwxYUbhIPbLjdccFg=; b=VVLauxsq8TgjFpaPqX8iyiQzeyS+8laUFv0fY4OvtP/W6UJIeBUNUdQw97X1pzwcg5 pPJSSqg2kPMZzC9hDcE2k17bcZzwhRmAXqgU6gVWVRmNC387MlHCJTVQT23PfhNACtQi /mwxfDOi2zMQIDDhUkssJoLfEnMu4NJuocml4yw4zi/HeUKThGLc57xD5DB01q6mFd+9 dLeEHqKom6yNOydUeTXChNT8bOsxWLM38XRdQX21yhG2LdfXXwdk5pfeT8IKB46lvAfk nSzd5+FsGmrnZW7oNtemTkoxvplIY1nTnfQiwW9Ebenkgk9Tkgf6+Dup6ozuy09NIPpA UBfg== X-Forwarded-Encrypted: i=1; AJvYcCUVT5AjynNNJ0yD+Chkdl4xnqM9bpWhMlzc6DKdfd+OwSfNB/hfB+XSULpubMlHn5SX2sHqkIZmChUZ5I1g9T16XPZQMj2Mmg== X-Gm-Message-State: AOJu0YxaXjGKmBhvb3o+I6BP3ze3L7lbwmi2Q/ra0rCFWZsYLIhxn7el +F9KV6tQRbC91tf8uZWaafGy7Yso3m5EllmNCvsMYjzoiCyQ8H4H X-Google-Smtp-Source: AGHT+IEdXbh9ChjeAjYyridR2UoDxrux5hoa3/RQWqsN66umfzPSfPH7XaR7UZXxodlzDtm5lCB97g== X-Received: by 2002:a17:90a:db90:b0:2b9:a45c:dcec with SMTP id 98e67ed59e1d1-2bd6047a9a3mr13140903a91.23.1716313133060; Tue, 21 May 2024 10:38:53 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2b02329sm21004822b3a.181.2024.05.21.10.38.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 10:38:52 -0700 (PDT) Message-ID: <9e66be79-78c2-443b-a30b-47c27a43fce1@gmail.com> Date: Tue, 21 May 2024 11:38:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v3 2/2] RISC-V: avoid LUI based const mat in alloca epilogue expansion Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Palmer Dabbelt , gnu-toolchain@rivosinc.com References: <20240520233237.109269-1-vineetg@rivosinc.com> <20240520233237.109269-2-vineetg@rivosinc.com> From: Jeff Law In-Reply-To: <20240520233237.109269-2-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/20/24 5:32 PM, Vineet Gupta wrote: > This is testsuite clean however there's a dwarf quirk which I want to > run by the experts. The test that was tripping CI has following > fragment: > > Before patch | After Patch > ------------------------------------------------------ > li t0,-4096 | addi sp,s0,-2048 > addi t0,t0,560 | .cfi_def_cfa 2, 2048 <- #1 > add sp,s0,t0 | addi sp,sp,-1488 > .cfi_def_cfa 2, 3536 | .cfi_def_cfa_offset 3536 <- #2 > addi sp,sp,1504 | addi sp,sp,1504 > .cfi_def_cfa_offset 2032 | .cfi_def_cfa_offset 2032 <- #3 > > The dwarf insn #1 and #3 seem ok, however #2 seems dubious to me. > > --- > > This is continuing on the prev patch in function epilogue expansion. > > gcc/ChangeLog: > * config/riscv/riscv.cc (riscv_expand_epilogue): Handle offset > being sum of two S12. OK. jeff