From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 46439385482C for ; Fri, 13 Nov 2020 18:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 46439385482C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-gGk9yOOqOVKWnWwFsPLM0g-1; Fri, 13 Nov 2020 13:53:57 -0500 X-MC-Unique: gGk9yOOqOVKWnWwFsPLM0g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B8CEA190A3E6; Fri, 13 Nov 2020 18:53:43 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-176.phx2.redhat.com [10.3.112.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BDDC60C07; Fri, 13 Nov 2020 18:53:43 +0000 (UTC) Subject: Re: [PATCH] libiberty: Make strstr.c in libiberty ANSI compliant To: Seija Kijin , gcc-patches@gcc.gnu.org References: From: Jeff Law Message-ID: <9e7e3075-5347-ac3a-21a1-dbcd5e7a9d93@redhat.com> Date: Fri, 13 Nov 2020 11:53:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 18:54:02 -0000 On 5/1/20 6:06 PM, Seija Kijin via Gcc-patches wrote: > The original code in libiberty says "FIXME" and then says it has not been > validated to be ANSI compliant. However, this patch changes the function to > match implementations that ARE compliant, and such code is in the public > domain. > > I ran the test results, and there are no test failures. Thanks.  This seems to be the standard "simple" strstr implementation.  There's significantly faster implementations available, but I doubt it's worth the effort as the version in this file only gets used if there is no system strstr.c. I've pushed this patch to the trunk after fixing some minor formatting issues jeff