From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 84B1B3858D28 for ; Sat, 17 Jun 2023 20:39:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84B1B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-25ee8d84b4fso278119a91.0 for ; Sat, 17 Jun 2023 13:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687034343; x=1689626343; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E3HkK+kOFWY0lBu8fqTwee23FolFWC3iK7hhJeJzk6Y=; b=IM0Xmi1FZUu+ZOxRayLNkiVc8o2NVaNwIFOyG4mUTm6jhD40DO6D0IxFBh9pMUfITH 1smW0lwhf8CjewSpGp0BqtZvg04TIM1F+clKJ62vFNO9ggGZAsmJIDaKw6WKg4dutxGw aRWYeWMe00Vzz7ORETsUxW2MNnXali8lf/bie2Ru1+BvKYu29C10N4FtxrQoWOa3KyaS BtQHTpgEq8TZNo8Afg8mqKan7ya9W5uOYTru5TrxACv2k3UruSLS6gwAwsd5m1VQGJDH qwzKvE5NeC/1K6CiW24UGTpxvw1/pFn5zg3Vc+0eNXzrX6AXdGyeHw+1jRCAaVkvqkq9 1/9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687034343; x=1689626343; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E3HkK+kOFWY0lBu8fqTwee23FolFWC3iK7hhJeJzk6Y=; b=fKk5Pqxx7BA2J051QbUVjDBpKHUj9bsHUYKqrk4PzTF/0gwJz1UpH0raa/o6Kb2p87 RO/XCYIX9g9eFB9/KZhoIkcKqtEDg1nZ5XkgPg4c+MmROeBoCbIBs9X89SR1r0M9A72S lGZzKsVOvvXNgI6QPJ0HCKptA7JpvsYVoc5v4VcEU4bk7EUllBvtfI/WUxr+geajq68Y d3VOdBYMvF0aEtwr0rSP5CZobCBZpMQhv/lR2gLBYgUYCTaBqk2aU3g2FauIYyzByM7T oWF93NxF3I4sroLBrSNoZ1TT54EpyKA2tF6NGpD6n0YeXyhFvPFAwx2Zy7EQ34dL+FQf Mavw== X-Gm-Message-State: AC+VfDxl0F9HIDr9/2x1Eu1trqY0TAazHRfEDMkZoFMB32dV/xp47yjz w2FcHpAHfgbBXCyP6uEncPQ= X-Google-Smtp-Source: ACHHUZ6QDr0djLZ0jbh9vaBomWM9rdiWln/nW0/NUtf0yryoV4ar3mpvfbsnJsSw84f2emKzrYHa+A== X-Received: by 2002:a17:90a:bb85:b0:25e:7ead:3c9 with SMTP id v5-20020a17090abb8500b0025e7ead03c9mr5686433pjr.19.1687034343390; Sat, 17 Jun 2023 13:39:03 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id y16-20020a170902b49000b001a0567811fbsm17783931plr.127.2023.06.17.13.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 13:39:02 -0700 (PDT) Message-ID: <9e898232-3ba8-7595-f5a3-94a794531ca6@gmail.com> Date: Sat, 17 Jun 2023 14:39:01 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] gcc-ar: Remove code duplication. Content-Language: en-US To: Costas Argyris , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/15/23 06:10, Costas Argyris via Gcc-patches wrote: > From c3f3b2fd53291805b5d0be19df6d1a348c5889ec Mon Sep 17 00:00:00 2001 > From: Costas Argyris > Date: Thu, 15 Jun 2023 12:37:35 +0100 > Subject: [PATCH] gcc-ar: Remove code duplication. > > Preparatory refactoring that simplifies by eliminating > some duplicated code, before trying to fix 77576. > I believe this stands on its own regardless of the PR. > It also saves a nargv element when we have a plugin and > three when not. Thanks. I've commited this to the trunk after adding a suitable ChangeLog entry. jeff