From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id 13E15385840B for ; Wed, 6 Dec 2023 18:00:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13E15385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13E15385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1034 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701885601; cv=none; b=ty6tGTWeN7N+sEBebxnLHnYB/dkeiPpLHa37u7e+0IcJ5EaevNQguj4/6toOxUoLOBePSXIaw4RkmbQZxIcp9UbMNLAdboaGjGrnvK9VySnYpyEHMhh5mDfdJVp4h8kytmDK0hmnztA1YiJgd9s9M86IwTtVjnDwy7Q2Zx+wJB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701885601; c=relaxed/simple; bh=UtmpefiHeVLBBfDKhzcJMI9B7h281A3c0NdOVaAtUi4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AL2z9p1PGwaAIF118zJl7VN/gXZstwWEFLPky5tOwHjQh+U1LD8RhiR9bG3nfYQPZK6/weQWjRGe7F9zIWGy5nyCWZJIbDjY1KyRuPBH6tvvUDQmpwaIqBKjXphVlGroLHDax3Y1gdsYMtze2z/xjzNljAZgt6DpEUW++1sEjec= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-286e676ffa0so94277a91.1 for ; Wed, 06 Dec 2023 10:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701885599; x=1702490399; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ptOBIIPRiA2qYdeg+PFtACmP3oXk65cmxqweic/HX6I=; b=gAofHxKfGMTfa+jbympk2uHHqfLIFVjDIO5yQsCVnaFIJHuS2IauzTy8t/C5cZZCee 54AsGMeGH963g1YXnZYs+S6/Elx0gPZfKb6irqdEKsHaX5/BrrY/qVuWlSL4GtS1dj/C lBQgI5t+AGBY2m+tzCreZBXv3nfAKjKBYYYAkF6XIZ0/Su1xDrW++FZPuVX/fa8Z+hQ2 GSbvRYluHQGwh9tQNr1pgpex53o/QkA31HQV+Z+lQDNuk0K4BCad1ARiPI/ISEjecMkh myagPzkdw11RVYyu/0DmG3jIrDPpVh2MRthbjyQdDm98u1L0s5nRZtsdQocJ9+XKfohc 6u6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701885599; x=1702490399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ptOBIIPRiA2qYdeg+PFtACmP3oXk65cmxqweic/HX6I=; b=skRZuJBmlbZKpcRyJCtG9CX+2KMHK7sR81YgFag4kH2YZLe4NyRME8+7VCC9WTRoN8 T3aHw8EEnFcSZNuZSCTTBEV9o2skzCRqy9uJ0lbCv+OjJWH/xEzU+qy6Run+XaIvojJa Lolm+t+4MGypZA+V1FXS04xdKfc1UxeH7TP5+/EXqNDvrjCkfZyTsEsPBhf7pdCz1d0O GRTFvkZxwiuG94ijON8yq3rYdczayCuMO2dhVBUU35QZ5y0K1jEptkJ3Ckage7mCqZ/O dXM0WBb3rBBfOz/VyZup30NsgPXy6sMCkU/HI/oNMQK4rde2YFoCKhuc8A/ZZHh9gpGK lG9A== X-Gm-Message-State: AOJu0Yx0UhnlbGNphGirvOp1pB4MMVZXZkVjewS6C557zigKviv6QQ6K PMOYZ7Tyuq9auoMeirQ0z3w= X-Google-Smtp-Source: AGHT+IET9Lx2XzzPwWwMHbEqyLNILajFnxBlvQbqNNyaya0KnZtPP2+VJ5qR4YrMBJwcYc1HiV/cew== X-Received: by 2002:a17:90a:8c12:b0:286:7c64:8e60 with SMTP id a18-20020a17090a8c1200b002867c648e60mr1077864pjo.52.1701885599015; Wed, 06 Dec 2023 09:59:59 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id b4-20020a17090ae38400b002800e0b4852sm161660pjz.22.2023.12.06.09.59.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 09:59:58 -0800 (PST) Message-ID: <9ec33a97-6807-433e-95d2-25a4830ee57a@gmail.com> Date: Wed, 6 Dec 2023 10:59:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] RISC-V: Add support for XCVbitmanip extension in CV32E40P Content-Language: en-US To: Kito Cheng , Mary Bennett Cc: gcc-patches@gcc.gnu.org References: <20231109105542.4013483-1-mary.bennett@embecosm.com> <20231109105542.4013483-2-mary.bennett@embecosm.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/5/23 08:30, Kito Cheng wrote: >> index 7d7b952d817..e7d4ad1760c 100644 >> --- a/gcc/config/riscv/corev.md >> +++ b/gcc/config/riscv/corev.md >> @@ -27,6 +27,25 @@ >> >> ;;CORE-V EVENT LOAD >> UNSPECV_CV_ELW >> + >> + ;;CORE-V BITMANIP >> + UNSPEC_CV_BITMANIP_EXTRACT >> + UNSPEC_CV_BITMANIP_EXTRACT_INSN >> + UNSPEC_CV_BITMANIP_EXTRACTR_INSN >> + UNSPEC_CV_BITMANIP_EXTRACTU >> + UNSPEC_CV_BITMANIP_EXTRACTU_INSN >> + UNSPEC_CV_BITMANIP_EXTRACTUR_INSN >> + UNSPEC_CV_BITMANIP_INSERT >> + UNSPEC_CV_BITMANIP_INSERT_INSN >> + UNSPEC_CV_BITMANIP_INSERTR_INSN > > You could reference bfe, sbfx and ubfx instructions in aarch64.md > to see how to write the insert and extract bit with RTL code. > >> + UNSPEC_CV_BITMANIP_BCLR >> + UNSPEC_CV_BITMANIP_BCLR_INSN >> + UNSPEC_CV_BITMANIP_BCLRR_INSN >> + UNSPEC_CV_BITMANIP_BSET >> + UNSPEC_CV_BITMANIP_BSET_INSN >> + UNSPEC_CV_BITMANIP_BSETR_INSN > > Just use generic RTL code for bset and bclr is fine, you could > reference bitmanip.md Agreed. And as a general principle if we can reasonably express the semantics of an instruction with RTL, we generally should. Doing so gives the optimizers a chance to improve stuff. I haven't looked at the patches, but the same might apply to the extractions & insertions, though there's more complex in that there's multiple implementations and I suspect some general cleanups would likely be necessary for that to work. We started to look at it a bit, but concluded there were bigger fish to fry. jeff