From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 37A103858CDB for ; Thu, 23 Mar 2023 15:33:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37A103858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32NEk2Wp024861; Thu, 23 Mar 2023 15:33:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=SHz8hJPpiqVWOdLcwT8bdBRhVRmN1vXhpTTmwIWdC80=; b=X41FXTuu020v0tIk6eLJhfdcbh88kFFxhfStjape++CyPFlWkfugGA2xTFlOpbFuAkQq MnAETHNQOM/QUleXLqLDk7V+3uT6ZUtpURacN9jw8jt+wb9B4YBI/fjHM1bUutqL/Apb 5a8hGbZKVqtAgIU7mLV3bNUWcS6i4PE4e3Vfb4sST912RkKQnaWScks+qo9n27M5+pE9 XfqhrRXMVLwHBNI/CwFhcCl/7G3cYi92PmXPbMJkRheXeNJvwxewlu2Bg7SPzuiJeXDl IXftzdWSIZ0qt3i2wqCJIsPNLD6hFjkZvfQsk4L6zzA0EGcBlp3sfKaNy6KDr/M1Tijl nA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pgmu7g59v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 15:33:00 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 32NF6DeD004702; Thu, 23 Mar 2023 15:32:59 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pgmu7g53y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 15:32:59 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32NECR4Y015429; Thu, 23 Mar 2023 15:32:37 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3pd4x7emdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 15:32:37 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32NFWaOu10682980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Mar 2023 15:32:36 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62EB25805A; Thu, 23 Mar 2023 15:32:35 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFFC55805C; Thu, 23 Mar 2023 15:32:32 +0000 (GMT) Received: from [9.43.99.176] (unknown [9.43.99.176]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Mar 2023 15:32:32 +0000 (GMT) Message-ID: <9ec3e4be-d1e5-ac1f-9391-46557bc4daa0@linux.ibm.com> Date: Thu, 23 Mar 2023 21:02:31 +0530 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] rtl-optimization: ppc backend generates unnecessary signed extension. Content-Language: en-US To: Peter Bergner , gcc-patches Cc: Segher Boessenkool , Jeff Law , Richard Biener References: <4c0b6b4f-bbc1-8dd0-a91c-ffed028b4873@linux.ibm.com> <365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com> From: Ajit Agarwal In-Reply-To: <365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: GOie7_yakpjTeumfxMR9BotQt3u30a8Y X-Proofpoint-GUID: FUZ1Tr-AJpE-PmLhBiADR3LAqwSxkyQc Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_21,2023-03-23_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303230113 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Peter: On 23/03/23 6:08 pm, Peter Bergner wrote: > On 3/23/23 5:38 AM, Ajit Agarwal wrote: >> This patch removed unnecessary signed extension elimination in ree pass. >> Bootstrapped and regtested on powerpc64-linux-gnu. >> >> >> Thanks & Regards >> Ajit >> >> rtl-optimization: ppc backend generates unnecessary signed extension. >> >> Eliminate unnecessary redundant signed extension. >> >> 2023-03-23 Ajit Kumar Agarwal >> >> gcc/ChangeLog: >> >> * ree.cc: Modification for AND opcode support to eliminate >> unnecessary signed extension. >> * testsuite/g++.target/powerpc/sext-elim.C: New tests. > > Not a review of the patch, but we talked offline about other bugzillas > regarding unnecessary sign and zero extensions. Doing a quick scan, I > see the following bugs. Please have a look at 1) whether these are > still a problem with unpatched trunk, and if they are, 2) whether your > patch fixes them or could fix them. Thanks. > > https://gcc.gnu.org/PR41742 These are not addressed in the trunk patch, because int c is not initialized with registers and for this reason we cannot eliminate them. If we initialize int c then zero extension goes away. > https://gcc.gnu.org/PR65010 > https://gcc.gnu.org/PR82940 > https://gcc.gnu.org/PR107949 > My patch fixes these PR's which were not fixed in trunk patch. Thanks & Regards Ajit > Peter >