From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7884 invoked by alias); 23 Sep 2019 08:02:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7875 invoked by uid 89); 23 Sep 2019 08:02:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=colour X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Sep 2019 08:02:32 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7ADA4B052; Mon, 23 Sep 2019 08:02:30 +0000 (UTC) Subject: Re: [Patch 0/X] [WIP][RFC][libsanitizer] Introduce HWASAN to GCC To: Matthew Malcomson , "gcc-patches@gcc.gnu.org" Cc: "dodji@redhat.com" , nd , "kcc@google.com" , "jakub@redhat.com" , "dvyukov@google.com" References: <156778058239.16148.17480879484406897649.scripted-patch-series@arm.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <9f0727e1-1e6b-ae5f-f854-52557afe0a2b@suse.cz> Date: Mon, 23 Sep 2019 08:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <156778058239.16148.17480879484406897649.scripted-patch-series@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg01318.txt.bz2 Hi. As mentioned in the next email thread, there are main objectives that will help me to make a proper patch review: 1) Make first libsanitizer merge from trunk, it will remove the need of the backports that you made. Plus I will be able to apply the patchset on the current master. 2) I would exclude the setjmp/longjmp - these should be upstreamed first in libsanitizer. 3) I would like to see a two HWASAN options that will clearly separate the 2 supported modes: TBI without MTE and MTE. Here I would appreciate to have a compiler farm machine with TBI which we can use for testing. 4) About the BUILTIN expansion: you provided a patch for couple of them. My question is whether the list is complete? 5) I would appreciate the patch set to be split into less logical parts, e.g. libsanitizer changes; option introduction; stack variable handling (colour/uncolour/alignment); hwasan pass and other GIMPLE-related changes; RTL hooks, new RTL instructions and expansion changes. Thank you, Martin