From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id B2AA23858C5E for ; Thu, 9 Mar 2023 23:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2AA23858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,247,1673942400"; d="scan'208";a="99656429" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 09 Mar 2023 15:50:43 -0800 IronPort-SDR: RXUrA7MD1z6t2a7hrA96aU6WwH3I5KMrk3Hc/9ZXFey8sO9qSNfUT6cDJ868wEN/0kDYlHwgzf hPeyzKfUZarkYS7KUxEEKAzNX/NAp/feMDQYydGLwviDHM2jG4cnERq5VX5wDslPeoyVnMjzAw Ha8HTFwLN7aBxeGSWWX1sYHCj1qz5hH3RXhxmmOCnO0Jb08bZpe1Lo95uydRn6Hf8SxbKrR25D t9cP5UoSseG0EOopcSHag05V3c6+LhjTxbFpOc1A9uw6ZI3qmVWMeeV6uo0SdtkOXe+y/lDvg8 UU8= Message-ID: <9f5f0f31-8ea7-bf5a-c111-128933716838@codesourcery.com> Date: Thu, 9 Mar 2023 16:50:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 3/5] doc: Add @defbuiltin family of helpers, set documentlanguage Content-Language: en-US To: =?UTF-8?Q?Arsen_Arsenovi=c4=87?= , CC: Gerald Pfeifer , Joseph Myers References: <20230223102714.3606058-1-arsen@aarsen.me> <20230223102714.3606058-4-arsen@aarsen.me> From: Sandra Loosemore In-Reply-To: <20230223102714.3606058-4-arsen@aarsen.me> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-10.mgc.mentorg.com (147.34.90.210) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/23/23 03:27, Arsen Arsenović via Gcc-patches wrote: > The @defbuiltin{,x} macros are convenience macros for the often-repeated > task of defining a built-in function in extend.texi. Usage of this > macro should lead to a higher degree of consistency across pieces of > text written by different people, and provide a better reading > experience, as they prevent easy-to-make errors, like forgetting index > entries for these functions. > > The documentlanguage omission was spotted by one of the people I asked > to "test drive" the updated manual, and so, it was added accordingly. > > gcc/ChangeLog: > > * doc/gcc.texi: Set document language to en_US. > (@copying): Wrap cover tests @quotation, move description of > manual in. > * doc/include/gcc-common.texi: Add @defbuiltin(x), @enddefbuiltin > for defining built-in functions. > * doc/extend.texi: Fix copyright notice comment, switch to using > @defbuiltin for built-in function definitions. > (Object Size Checking): Add subsubsection for formatted output > function (printf et al.) checking. This is OK, but I would like to see it split into two separate commits, one for the @defbuiltin parts and one for the other miscellaneous tweaks. -Sandra