From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 7FDCF3858D35 for ; Tue, 27 Dec 2022 15:33:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FDCF3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12e.google.com with SMTP id m15so6883748ilq.2 for ; Tue, 27 Dec 2022 07:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7zWvhJTVo1FYNP+SxHaTb+ndUAwr+OzpKRPoPQkFLng=; b=P+dAUSnh8lHlIv2m8X+vmwnRN0p1XpoE6xRw5BC/u0g+mZoq00c8gIhHZYuTOQqJgt oZL1vKackQDvZ6IwYaxislkTWQCY0ssODngN0nMStiUcf+FHlkSxVzhw979M+6ibB4WK O4UJDeUNfGvWDV5KU+rHb+QbpY3MNoJ7GH5gDrEeVyLkHbYKYxRr0wR8Km/ufL3MK8R5 BFaHVwahJvmDQcm5coJVlRjENSYCXz1zR0jih3WBVXXWKiKnArQJxSUQWx6c6CjE4H+W wy+aTztTLDquutikgkGstiXQ9QJus7JW5JzXMTWceGcQx537T2x63RuEaSrYqQST4Enx SoZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7zWvhJTVo1FYNP+SxHaTb+ndUAwr+OzpKRPoPQkFLng=; b=esndOy3GV5vJyGLlfLefO1VDQOfKTMUyBV0g/rOE7QB3ITAkOYOn3P46JAeb0ZlLPL Ya1Rt/J21ud1A4qzXsx5/Yk+OXWjhWIiEj6XP/I30XvtqSO7wlmKd6+1QHFXes5+7AFS d3M3qCUPuqqhdBZDf3cMVSRfso9UJHf2YbehcPStrQzE/e1SUJxULWLUd785M0DT9qw1 pOwWiP5eKD5X72Bm3rVgARRGDn76V9L4L6fXIGiB7BZOkWOsx12UFJp60wYmihw51jjS OVbW2Jy9WKngBWoZt/3H0Y+Mf+LRe9NV7ZjWDgMQHsfSxB0f8k1sOScAZsoXYHsHqhoH z9Cw== X-Gm-Message-State: AFqh2kqRcJ61nXyMksxVp9wHGtT5YNO6f+0STIWjiS1+Esww8Eg2IuvS 6DS5BSbkyn4tbdqPcx25BUs= X-Google-Smtp-Source: AMrXdXs1G/pNgdQ+fMNI2HeNnyeGYXHrGVzFXfjSYjN2Gkh5af54QwrTd9K9v2FjXjylDVPXTOw60A== X-Received: by 2002:a92:d0d1:0:b0:302:dd83:68d8 with SMTP id y17-20020a92d0d1000000b00302dd8368d8mr13415981ila.8.1672155226735; Tue, 27 Dec 2022 07:33:46 -0800 (PST) Received: from [172.31.1.18] (65-130-81-249.slkc.qwest.net. [65.130.81.249]) by smtp.gmail.com with ESMTPSA id q26-20020a05663810da00b0036c8a246f54sm4441318jad.142.2022.12.27.07.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 07:33:46 -0800 (PST) Message-ID: <9f969824-dc72-404c-13a4-182b13702cec@gmail.com> Date: Tue, 27 Dec 2022 08:33:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [11/13] ada: don't map NULL decl to locus Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Arnaud Charlet , Eric Botcazou , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Pierre-Marie de Rodat References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/26/22 21:38, Alexandre Oliva via Gcc-patches wrote: > > When decl is NULL, don't record its mapping in the > decl_to_instance_map. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/ada/ChangeLog > > * gcc-interface/trans.cc (Sloc_to_locus): Don't map NULL decl. OK assuming that a NULL "decl" is valid -- you're in a much better position than me to assess validity of a NULL "decl" here. jeff