From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E45383858D39 for ; Wed, 19 Oct 2022 06:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E45383858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29J6tHnj011221 for ; Wed, 19 Oct 2022 06:57:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=7RxHJQKF5FsLpi37VmPy2o0iki/E57OEflROUJEBb6A=; b=CwqOwev8PAVK2nP6J7KJeMXsqpQx5CwF5KtAuWYIlNyyGXmJNlwel34QhJ5p5SUkXDc6 jYPIBosox/O4e4ne+Zn7uNjEJKbq0NmFpJSi3/V7Gfu62WkZhPJAK+fFCmCGA3HtweZp lXOUQSePfq1XmiEwmgdbyBpSVanXnindae68zoKFB8RhK8vGLm9P+IRvXG0NRfAtHKbD eLac4BzUHGgu/GgoWI0mOoFr0UFaQkE/r5OJi560eKGz6AqBkk9llF017d2NKWn3+PxH D2FOlnng0Bg0ddx7dU8e0/rVZR/fgl0Qn5Wc/eKtF9/lTWwmkCun62CrJ2BDrawGsr3b yA== Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kaccv016m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Oct 2022 06:57:44 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29J6qWiX014550 for ; Wed, 19 Oct 2022 06:57:42 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 3k7mg9503j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Oct 2022 06:57:42 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29J6vcj565929708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Oct 2022 06:57:38 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F372AE051; Wed, 19 Oct 2022 06:57:38 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65845AE04D; Wed, 19 Oct 2022 06:57:38 +0000 (GMT) Received: from [9.171.19.235] (unknown [9.171.19.235]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 19 Oct 2022 06:57:38 +0000 (GMT) Message-ID: <9fd42a52-f4ae-9476-784c-1b73b820da66@linux.ibm.com> Date: Wed, 19 Oct 2022 08:57:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] IBM zSystems: Fix function_ok_for_sibcall [PR106355] Content-Language: en-US To: Stefan Schulze Frielinghaus , gcc-patches@gcc.gnu.org References: <20220817115044.1853371-1-stefansf@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20220817115044.1853371-1-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: CFGcH-Jfid0HD7DCa5xAfwfe6C7yhvef X-Proofpoint-GUID: CFGcH-Jfid0HD7DCa5xAfwfe6C7yhvef X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-19_02,2022-10-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210190035 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/17/22 13:50, Stefan Schulze Frielinghaus wrote: > For a parameter with BLKmode we cannot use REG_NREGS in order to > determine the number of consecutive registers. Streamlined this with > the implementation of s390_function_arg. > > Fix some indentation whitespace, too. > > Assuming bootstrap and regtest are ok for mainline and gcc-{10,11,12}, > ok to install for all of those? > > PR target/106355 > > gcc/ChangeLog: > > * config/s390/s390.cc (s390_call_saved_register_used): For a > parameter with BLKmode fix determining number of consecutive > registers. > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/pr106355.h: Common code for new tests. > * gcc.target/s390/pr106355-1.c: New test. > * gcc.target/s390/pr106355-2.c: New test. > * gcc.target/s390/pr106355-3.c: New test. Ok for all those branches. Please check if the branches are currently open before committing. GCC 11 and 12 appear to be but I'm not sure if GCC 10 has been re-opened again. There should be a final 10.5 release some day though. Thanks! Andreas