From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 68B49385E020 for ; Fri, 14 Oct 2022 08:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 68B49385E020 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wm1-x333.google.com with SMTP id t4so2645555wmj.5 for ; Fri, 14 Oct 2022 01:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zOv9LXfqFuO0GSnE57tkN7jjyJxg/XrVlIMsTTGWaDA=; b=Xikma322zU9np1yknCDS5x38jiOPdVg9kmMu8uZIwK1GYnRPbqkl2pJlEhxuSuVmR0 mXpkqIWfzgYJFZ7o7U9KY/Q1L8D8TYEX+pXQfJjfE3TvfS+1vprD31L53Noi4wqo+XQn P/9dxXe6n2NvrGQ+ez0pxTdwOMVp/KDJ+ujSHbLELxw/RvcXP9rWq7uXsl4lhs/9GS3E /x5Am2h21Dth8zC3ur/V46N4twKNZvU1rdkeltnXNov6OoODEpkip7Ese0ZBCHK44UBs NOygUvqM/wzbbXP2pYNys8tH/0Lx/ZoG2ccfQYgR+nYlp5/3+sgk2mRvY8P6wlR6FYAG Mwfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zOv9LXfqFuO0GSnE57tkN7jjyJxg/XrVlIMsTTGWaDA=; b=C4xYD1FonpcMLV/g2Vf74zPmD2L8ijO8biD8AlgF201NRvpmT9Hr/kPfR2vppmo5QY R9UzYRJMViFXcEAd7xsv5/02wT10+h+r65w6tJK1PMqieEvUAh7kfAvF8OsV/Yjtnzm7 /hJyVn2sAmU369gssjO5nSlwNfw1RJNFgYaMx25AQMY59ZytXZZlSWvNvxxIK9iXzOdM /9cCHOA8IaYnieJyIEVuQb3J2SDxLcmgU0wBBFHlNaEwnCMeiguF39IjTYMP7Z8s57m+ Trnz6ovNKRMfXESXTQ9x9lchspSZQ9zSSp6V8qB+Rq1nQSHxiXd0j7RHhcU4aFtVCl63 4w6A== X-Gm-Message-State: ACrzQf1mrWe7CCnQcLnh0Y3Kgo82fj5Z7Q0zO1Uglb31+PDVVMXE9be3 c0dSwZn7O0B/70+qEWbQqs8= X-Google-Smtp-Source: AMsMyM7OTzBbU+rmV+DSfwX0KM6/Qhe3MpEIz13Dc8LkCnS83r5yA0YgcWdGmtNPUFdGMEGlgNgD8Q== X-Received: by 2002:a05:600c:5028:b0:3bd:48dc:4e4b with SMTP id n40-20020a05600c502800b003bd48dc4e4bmr9469996wmr.22.1665736613731; Fri, 14 Oct 2022 01:36:53 -0700 (PDT) Received: from [192.168.1.95] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id q65-20020a1c4344000000b003a8434530bbsm6536060wma.13.2022.10.14.01.36.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2022 01:36:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions From: Iain Sandoe In-Reply-To: Date: Fri, 14 Oct 2022 09:36:52 +0100 Cc: "Lu, Hongjiu" , Haochen Jiang , hongtao.liu@intel.com, GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <20221014075445.7938-1-haochen.jiang@intel.com> To: Hongtao Liu X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 14 Oct 2022, at 09:30, Hongtao Liu wrote: >=20 > On Fri, Oct 14, 2022 at 4:24 PM Iain Sandoe = wrote: >>=20 >>=20 >>=20 >>> On 14 Oct 2022, at 09:20, Hongtao Liu wrote: >>>=20 >>> On Fri, Oct 14, 2022 at 4:14 PM Iain Sandoe via Gcc-patches >>> wrote: >>>>=20 >>>> Hi Haochen >>>>=20 >>>>> On 14 Oct 2022, at 08:54, Haochen Jiang via Gcc-patches = wrote: >>>>>=20 >>>>=20 >>>>> These six patches aimed to add Intel Sierra Forest instructions, = including >>>>> AVX-IFMA, AVX-VNNI0INT8, AVX-NE-CONVERT, CMPccXADD. We also added = intrinsic >>>>> for vector __bf16 in this series of patch and Sierra Forest = Support. >>>>>=20 >>>>> The information is based on newly released >>>>> Intel Architecture Instruction Set Extensions and Future Features. >>>>>=20 >>>>> The document comes following: >>>>> = https://www.intel.com/content/www/us/en/develop/download/intel-architectur= e-instruction-set-extensions-programming-reference.html >>>>>=20 >>>>> Regtested on x86_64-pc-linux-gnu. Ok for trunk? >>>>=20 >>>> Have you tested that the testcases work on older platforms that do = not have support >>>> for the new instructions in their assemblers? >>>>=20 >>>> I could not see any target-requires changes in the testcases .. = hence my question. >>>>=20 >>> Guess you are looking at compile tests? >>=20 >> yes, compile tests would need support from the assembler. oops, not enough coffee - I=E2=80=99m talking rubbish here - assembler = output should be fine, >>> For runtime test, we have add assembler check(target-requires = changed) >>> plus runtime check(builtin_cpu_supports) >>> .i.e. >>>=20 >>> +++ b/gcc/testsuite/gcc.target/i386/avx-ifma-vpmaddhuq-2.c >>> @@ -0,0 +1,72 @@ >>> +/* { dg-do run } */ >>> +/* { dg-options "-O2 -mavxifma" } */ >>> +/* { dg-require-effective-target avxifma } */ >>>=20 >>> Do I miss some? >>=20 >> I would need to look at the sources after patching (perhaps they = already have >> suitable target-requires that did not show up in the patch). >>=20 >> Do you have this series as a branch somewhere that I can try on one = of the >> like affected platforms? >=20 > Not yet. > Do we have any external place to put those patches so folks from the > community can validate before it's committed, HJ? I=E2=80=99d still like to be able to test if that can be done - I=E2=80=99= ve already got a large number of fails from new testcases in earlier additions. Iain=