From: Tristan Gingold <gingold@adacore.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Janne Blomqvist <blomqvist.janne@gmail.com>,
Tobias Burnus <tobias.burnus@physik.fu-berlin.de>,
GCC Patches <gcc-patches@gcc.gnu.org>,
fortran@gcc.gnu.org
Subject: Re: [Patch V2] libgfortran: do not assume libm
Date: Mon, 02 Apr 2012 07:47:00 -0000 [thread overview]
Message-ID: <A189390C-3DB3-438E-B4C8-F4BF00F4021F@adacore.com> (raw)
In-Reply-To: <4F75A984.2090605@redhat.com>
On Mar 30, 2012, at 2:39 PM, Paolo Bonzini wrote:
> Il 30/03/2012 12:22, Tristan Gingold ha scritto:
>>
>> On Mar 27, 2012, at 10:38 AM, Janne Blomqvist wrote:
>>
>>> On Tue, Mar 27, 2012 at 11:01, Tristan Gingold <gingold@adacore.com> wrote:
>>>> Hi,
>>>>
>>>> this patch fixes this issue. Is it OK ?
>>>
>>> Ok.
>>>
>>>> Maybe we should include the AC_DEFINE action within GCC_CHECK_MATH_FUNC. Will try to do that.
>>>
>>> That looks like a cleaner solution, yes, and less chance for typos to sneak in.
>>
>> Hi,
>>
>> here is the 'cleaner solution': now GCC_CHECK_MATH_FUNC automatically define the HAVE_xxx variable.
>>
>> The description is now: Define to 1 if you have the `xxx' function. As a consequence, libgfortran/config.h.in was regenerated (with differences like:
>>
>> -/* acos is available */
>> +/* Define to 1 if you have the `acos' function. */
>> #undef HAVE_ACOS
>>
>> )
>>
>> Tested by rebuild libgfortran for ia64-hp-openvms and visual inspection of differences.
>>
>> I have CC: Paolo as he approved the first version of math.m4.
>>
>> Ok for trunk ?
>
> Yes.
Thanks, committed.
Tristan.
prev parent reply other threads:[~2012-04-02 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 9:49 [Patch] " Tobias Burnus
2012-03-20 9:57 ` Tristan Gingold
2012-03-22 8:30 ` [Patch V2] " Tristan Gingold
2012-03-22 10:07 ` Paolo Bonzini
2012-03-22 20:57 ` Tobias Burnus
2012-03-26 8:44 ` Tristan Gingold
2012-03-26 21:43 ` Janne Blomqvist
2012-03-27 7:51 ` Tristan Gingold
2012-03-27 8:01 ` Tristan Gingold
2012-03-27 8:39 ` Janne Blomqvist
2012-03-27 9:29 ` Tristan Gingold
2012-03-30 10:22 ` Tristan Gingold
2012-03-30 12:40 ` Paolo Bonzini
2012-04-02 7:47 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A189390C-3DB3-438E-B4C8-F4BF00F4021F@adacore.com \
--to=gingold@adacore.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=pbonzini@redhat.com \
--cc=tobias.burnus@physik.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).