From: Iain Sandoe <iains.gcc@gmail.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: GCC Patches <GCC-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Andrew Stubbs <ams@codesourcery.com>
Subject: Re: [PATCH] configury : Fix LEB128 support for non-GNU assemblers.
Date: Thu, 26 Nov 2020 21:43:17 +0000 [thread overview]
Message-ID: <A2B57442-3EB6-479F-998B-FF4029CB4F7B@gmail.com> (raw)
In-Reply-To: <ydd4klb94sr.fsf@CeBiTec.Uni-Bielefeld.DE>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>>
>> maybe this is enough to cover all bases without having to do any version
>> or
>> target checks. (untested)
>>
>> objdump is not available on quite a few Darwin versions with perfectly
>> functional
>> uleb128 - so I don’t want to punt on those for absence of it. We already
>> check for
>> otool elsewhere.
>>
>> thoughts?
>
> LGTM, with one nit:
>
>> [[
>> if test "x$gcc_cv_objdump" != x; then
>> if $gcc_cv_objdump --full-contents conftest.o 2>/dev/null \
>
> I'd use $gcc_cv_objdump -s here (maybe adding -j .data), matching the
> other equivalent objdump invocations in gcc/configure.
OK - I need to check on compatibility between GNU objdump and LLVM objdump.
(since newer Darwin and GCN will be using the latter).
-s might work OK since we only have one section, but -j is problematic wit
different section naming conventions.
corollary: one should not assume that other invocations of objdump in
configure
are working as expected if the objdump is the LLVM one.
cheers
Iain
next prev parent reply other threads:[~2020-11-26 21:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 9:49 Iain Sandoe
2020-11-25 10:37 ` Rainer Orth
2020-11-26 13:08 ` Rainer Orth
2020-11-26 13:17 ` Iain Sandoe
2020-11-26 13:26 ` Rainer Orth
2020-11-26 13:30 ` Jakub Jelinek
2020-11-26 15:07 ` Rainer Orth
2020-11-26 20:28 ` Iain Sandoe
2020-11-26 21:39 ` Rainer Orth
2020-11-26 21:43 ` Iain Sandoe [this message]
2020-11-27 10:29 ` [PATCH v2] " Iain Sandoe
2020-11-27 10:37 ` Jakub Jelinek
2020-11-26 14:48 ` [PATCH] " Iain Sandoe
2020-11-26 14:52 ` Andrew Stubbs
2020-11-25 17:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2B57442-3EB6-479F-998B-FF4029CB4F7B@gmail.com \
--to=iains.gcc@gmail.com \
--cc=GCC-patches@gcc.gnu.org \
--cc=ams@codesourcery.com \
--cc=jakub@redhat.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).