From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id D44F9397242D for ; Thu, 26 Nov 2020 21:43:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D44F9397242D Received: by mail-wm1-x336.google.com with SMTP id u10so607998wmm.0 for ; Thu, 26 Nov 2020 13:43:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Wlp+tCFres1KSkoehuLWWgAlZVUYVs5KVRnN6y1+CYU=; b=oERM99iiXJg4zYtgcWzszUQjVWfDvt9YeTLpFMsyeY39z172vCtX3fcooBkWJUPux0 uE2N5XJJdisgSyKkKRZcQVdYN9HzXi5goyeMgCXnxa9DiuXZ9Aq1GdPO6P70bVfrwDWN gDI1xlQE1UnmMZZbL7KgOFSZwYxeguUGxfBin9Yjww20uJaeZzaz7CrHP1Hp6laSbkTJ UW7x1WJeR05VFjSiMu03iUGifJoPs+Vahp/xzHqrc7+JiiHt8Gda9LFFqE6VoVyUT8Nj VzGga4680TjGecpfxZbYFew7DCpbwXOSae+uBUJoakPQB/KSXKCWLpPz4b2MPRsfyU4j qYYg== X-Gm-Message-State: AOAM532osT7oE+SbQVyTnE5csZ87nUnp+ZGIeu+xJUZYkSpl6nv6MK9Y VwsFk/3iTxB5jecLElyMNsE= X-Google-Smtp-Source: ABdhPJygyj3Nn7mh5+1P8y6WlCICvPY7ZP3br2BUBkf4EzpKUw8/SHTzB+OtOpTvcVTP/Dy2l33JZg== X-Received: by 2002:a7b:c154:: with SMTP id z20mr5321217wmi.160.1606426999016; Thu, 26 Nov 2020 13:43:19 -0800 (PST) Received: from [192.168.1.212] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id 64sm9865549wmd.12.2020.11.26.13.43.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Nov 2020 13:43:18 -0800 (PST) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] configury : Fix LEB128 support for non-GNU assemblers. From: Iain Sandoe In-Reply-To: Date: Thu, 26 Nov 2020 21:43:17 +0000 Cc: GCC Patches , Jakub Jelinek , Andrew Stubbs Content-Transfer-Encoding: 8bit Message-Id: References: <0099CE62-D849-40BA-BCBD-1AD3882AA9AD@sandoe.co.uk> <20201126133052.GX3788@tucnak> <67EFBE24-057F-4BB2-A91A-D9C4A60F01A4@sandoe.co.uk> To: Rainer Orth X-Mailer: Apple Mail (2.3273) X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 21:43:21 -0000 Rainer Orth wrote: >> >> maybe this is enough to cover all bases without having to do any version >> or >> target checks. (untested) >> >> objdump is not available on quite a few Darwin versions with perfectly >> functional >> uleb128 - so I don’t want to punt on those for absence of it. We already >> check for >> otool elsewhere. >> >> thoughts? > > LGTM, with one nit: > >> [[ >> if test "x$gcc_cv_objdump" != x; then >> if $gcc_cv_objdump --full-contents conftest.o 2>/dev/null \ > > I'd use $gcc_cv_objdump -s here (maybe adding -j .data), matching the > other equivalent objdump invocations in gcc/configure. OK - I need to check on compatibility between GNU objdump and LLVM objdump. (since newer Darwin and GCN will be using the latter). -s might work OK since we only have one section, but -j is problematic wit different section naming conventions. corollary: one should not assume that other invocations of objdump in configure are working as expected if the objdump is the LLVM one. cheers Iain