* [PATCH] Fix PR64855
@ 2015-01-30 0:15 Jack Howarth
2015-01-30 0:36 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Jack Howarth @ 2015-01-30 0:15 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
The attached patch fixes PR64855 by not setting targetabis on
darwin in testsuite/lib/libffi.exp as suggested by Iain Sandoe.
Confirmed on x86_64-apple-darwin14 to eliminate the libffi regressions
at -m32/-m64. Okay for gcc trunk?
Jack
[-- Attachment #2: PR64855.diff --]
[-- Type: text/plain, Size: 772 bytes --]
2015-01-29 Jack Howarth <howarth.at.gcc@gmail.com>
PR libffi/64855
* testsuite/lib/libffi.exp: Don't set targetabis on darwin.
Index: libffi/testsuite/lib/libffi.exp
===================================================================
--- libffi/testsuite/lib/libffi.exp (revision 220263)
+++ libffi/testsuite/lib/libffi.exp (working copy)
@@ -310,7 +310,7 @@ proc run-many-tests { testcases extra_fl
set targetabis { "" }
if [string match $compiler_vendor "gnu"] {
if { ([istarget "i?86-*-*"] || [istarget "x86_64-*-*"])
- && [is-effective-target ia32] } {
+ && [is-effective-target ia32] && ![istarget "*-*-darwin*"] } {
set targetabis {
""
"-DABI_NUM=FFI_STDCALL -DABI_ATTR=__STDCALL__"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix PR64855
2015-01-30 0:15 [PATCH] Fix PR64855 Jack Howarth
@ 2015-01-30 0:36 ` Richard Henderson
2015-01-30 1:16 ` Mike Stump
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2015-01-30 0:36 UTC (permalink / raw)
To: Jack Howarth, GCC Patches
On 01/29/2015 01:53 PM, Jack Howarth wrote:
> PR libffi/64855
> * testsuite/lib/libffi.exp: Don't set targetabis on darwin.
Ok.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix PR64855
2015-01-30 0:36 ` Richard Henderson
@ 2015-01-30 1:16 ` Mike Stump
0 siblings, 0 replies; 3+ messages in thread
From: Mike Stump @ 2015-01-30 1:16 UTC (permalink / raw)
To: Jack Howarth; +Cc: GCC Patches
On Jan 29, 2015, at 1:56 PM, Richard Henderson <rth@redhat.com> wrote:
> On 01/29/2015 01:53 PM, Jack Howarth wrote:
>> PR libffi/64855
>> * testsuite/lib/libffi.exp: Don't set targetabis on darwin.
>
> Ok.
Committed revision 220264.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-29 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-30 0:15 [PATCH] Fix PR64855 Jack Howarth
2015-01-30 0:36 ` Richard Henderson
2015-01-30 1:16 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).