From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20766 invoked by alias); 4 Dec 2007 06:52:24 -0000 Received: (qmail 20758 invoked by uid 22791); 4 Dec 2007 06:52:23 -0000 X-Spam-Check-By: sourceware.org Received: from qmta05.westchester.pa.mail.comcast.net (HELO QMTA05.westchester.pa.mail.comcast.net) (76.96.62.48) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 06:52:12 +0000 Received: from OMTA02.westchester.pa.mail.comcast.net ([76.96.62.19]) by QMTA05.westchester.pa.mail.comcast.net with comcast id LV8j1Y0010QuhwU0504o00; Tue, 04 Dec 2007 06:52:09 +0000 Received: from [10.69.69.129] ([76.21.111.239]) by OMTA02.westchester.pa.mail.comcast.net with comcast id LWs71Y00659xNwC0300000; Tue, 04 Dec 2007 06:52:09 +0000 X-Authority-Analysis: v=1.0 c=1 a=dAuusOrILkkA:10 a=mDV3o1hIAAAA:8 a=Tdeef_YmouygAviYaMcA:9 a=IPtHlcyYowrLtM4YVg6qewmaNIwA:4 a=v0J4qu1yN_kA:10 a=WuK_CZDBSqoA:10 a=-tXRAxsaAAAA:8 a=_uTtykOtvC3s1Tw52s4A:9 a=ylXY6gBhQ7M4ETaKqP6BfjKeoW8A:4 a=qhBkzvJwW6AA:10 Cc: Rask Ingemann Lambertsen , GCC Patches Message-Id: From: Geoff Keating To: Hans-Peter Nilsson In-Reply-To: <20071203172219.I18316@dair.pair.com> Content-Type: multipart/signed; boundary=Apple-Mail-4--599405174; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v915) Subject: Re: btest-gcc.sh patch ping and Re: Link tests after GCC_NO_EXECUTABLES Date: Tue, 04 Dec 2007 06:52:00 -0000 References: <474C8FA4.2040603@codesourcery.com> <474C95BA.1060807@t-online.de> <474C96C1.7010208@codesourcery.com> <474C98AA.50105@t-online.de> <474C9A65.2060902@codesourcery.com> <474C9B33.8060503@t-online.de> <474C9CBD.2070708@codesourcery.com> <87fxyqdc45.fsf@firetop.home> <474D943C.4030106@codesourcery.com> <877ik0aerh.fsf@firetop.home> <20071130022132.GL17368@sygehus.dk> <20071203092630.N17510@dair.pair.com> <5B2201B7-4859-46E3-8994-FB1B1EF20A2A@geoffk.org> <20071203172219.I18316@dair.pair.com> X-Mailer: Apple Mail (2.915) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00095.txt.bz2 --Apple-Mail-4--599405174 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Content-length: 2883 On 03/12/2007, at 2:39 PM, Hans-Peter Nilsson wrote: > On Mon, 3 Dec 2007, Geoff Keating wrote: >> On Dec 3, 2007, at 6:40 AM, Hans-Peter Nilsson >> wrote: >>> 2 - btest-gcc.sh isn't updated to cover fortran. >>> Patch at >> msg01710.html>. Ping! >> >> Rejected; I do not think this script needs to be configurable in >> this fashion. > > But *I* do. As it doesn't affect the default functionality or > the integrity of the result (everything still listed in > build_log), and doesn't take away or add redundant > functionality, I don't really understand your rejection. Part of the integrity of the result is that the same things are tested in every run of the script on a particular platform. The script was specifically intended to not be configurable in the manner you want, because that would allow for the possibility that a misconfigured tester might miss some tests that ought to be run. >> If there's a log missing, and you think the underlying >> functionality is stable >> and well supported by GCC contributors on all platforms where it is >> enabled, >> propose a patch to add it. > > The fortran tests are stable where it works, or so it seems. > Whether it works is port-specific (build issue on *-elf being > covered in this thread), and the patch above was a way to add > the functionality per-platform. It would also allow e.g. > tracking gas or ld results in a combined tree. The patch does not accomplish this. It instead adds the functionality *per-tester*. That's different to per-platform. > I just need a regtest-script I can point to, such that people can > see how I build and regtest and possibly repeat it. I would not go look at the scripts if I was trying to reproduce the results of my tester. I would instead look at the build log which shows the exact 'configure' and 'make' commands used, with no need to do shell variable substitution in my head. > Your btest-gcc.sh mostly fits, but not covering all gcc-related > tests that run by "make check" is really an issue. The patch does not implement this, either, but it might be a good idea. The reason the script doesn't cover all tests is because some parts of the testsuite were too unreliable to be used in an automated fashion. That was some time ago and it may be that today it should simply look at all the testsuite. Or, not. If you have some data that points either way it would be very helpful. > I guess I could solve that by adding a variant of that script in > contrib/ though I do prefer improving the existing one. Why? I can't imagine you're saving an enormous amount of time in maintenance. Nor is this script more conveniently located than a script you maintain in your own tree. You could put your script on a web server and point people at that. --Apple-Mail-4--599405174 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 Content-length: 3335 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIGUTCCAwowggJzoAMCAQICDwYJqWEAFyqX8447TdsXEDANBgkqhkiG 9w0BAQUFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1 bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZy ZWVtYWlsIElzc3VpbmcgQ0EwHhcNMDcwNDEyMDQ1NjU4WhcNMDgwNDExMDQ1 NjU4WjByMRAwDgYDVQQEEwdLZWF0aW5nMRkwFwYDVQQqExBHZW9mZnJleSBG cmFuY2lzMSEwHwYDVQQDExhHZW9mZnJleSBGcmFuY2lzIEtlYXRpbmcxIDAe BgkqhkiG9w0BCQEWEWdlb2Zma0BnZW9mZmsub3JnMIIBIjANBgkqhkiG9w0B AQEFAAOCAQ8AMIIBCgKCAQEA2gRVDpAS4m2z5ieV+tEe3/ZCh4OMt6GFdb6z VrBUVzKMsAzjGSM9IYY/b1s3zSbZUfJQOnrYxWSHNAiVBGLBXHFYV8W2GM4G CxgJkvgAbS5BVmCE5b+JBeXf0mVMvwwZD3Jv46wCRRJA627aRLLbinuHAAK/ n5qxRLI0g8fwCZ5r5esYD717qS4qRNKL1MSsW43Ip6pqnsgwMjwiWXwe9F6U /BzoVjUUPryC2msrSYpPfyrDOG97vOAYNT//l1PFs2tUycjycsEIKPqWefA3 sBCX09SBIFVXdrPC+uDiZps9Mv4wRo44XeM20DvS8hDSUW0yrDHvKJ69dTnH td9h7wIDAQABoy4wLDAcBgNVHREEFTATgRFnZW9mZmtAZ2VvZmZrLm9yZzAM BgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAL40IC2ISa+Z6JL27+UH 6AOVcReTvGGbQE14W2xZha1O4x4QhCfmIREoMGVl6wH8JNeGffN0VAkKtGNo 6C/jfhSqP5N+c8amxFenyxAP7BtycpxivOzKI2dQ0nylsbbS0J4bsFWjLxC+ OrlMXWsxrJ2qRn8CYXefy0vjJwCGCFulMIIDPzCCAqigAwIBAgIBDTANBgkq hkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4g Q2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29u c3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZp c2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSsw KQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4X DTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNV BAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0G CSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbL rzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9I BH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1Ro YXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1Ud EQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG 9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+q LZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3d qZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/ XV9lTzGCAw0wggMJAgEBMHUwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRo YXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAg8GCalhABcql/OOO03bFxAw CQYFKw4DAhoFAKCCAW0wGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkq hkiG9w0BCQUxDxcNMDcxMjA0MDY1MjA3WjAjBgkqhkiG9w0BCQQxFgQUPIx5 QORr6DZGtPU4Fsa0yLPBy18wgYQGCSsGAQQBgjcQBDF3MHUwYjELMAkGA1UE BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENB Ag8GCalhABcql/OOO03bFxAwgYYGCyqGSIb3DQEJEAILMXegdTBiMQswCQYD VQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRk LjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3Vpbmcg Q0ECDwYJqWEAFyqX8447TdsXEDANBgkqhkiG9w0BAQEFAASCAQAjtH0qFSfk EXtAk6XAqTihuDnt13gH2sX0jK+CsKZoiXxeia0PtLkvE5hvUVEkBCmVZxm+ QSGix8mmG2G0QkZ9AHIS0N8fIRDZDs4gFJ3Eg8GsDjo3XPETRBGlNhwjfUv2 q1huAshLIA5LQWMk+bpTpFgQ90z2MXQ8sf/g3zuf9yFAczEvWKPuseTVjehX yKxfy8mJkE6b0LnajFpjK1I6wM8X0shOWYVS6D44Q469YizribyjMnMYyr/q jr/iO+KGwrI/NGk+oD1zSgfHKXg2HjKqekUXNcGYFnEhD6uPdlJcWgozFuaF 9TWeRy+acRvYGQPZ9mrpvF04/Elx5OoQAAAAAAAA --Apple-Mail-4--599405174--