public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Nicolas Roche <roche@adacore.com>
Subject: [patch] propagate INSTALL Makefile variables down from gcc/
Date: Thu, 21 Aug 2014 15:50:00 -0000	[thread overview]
Message-ID: <A32C1082-F2CD-4596-B76B-E02B6C1DA135@adacore.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hello,

Experiments with custom install programs exposed that the INSTALL series of
Makefile variables aren't propagated down from the gcc subdir.

This patch fixes this. Checked that it addressed the unexpected behavior we
were observing + bootstrapped & regtested on x86_64-linux-gnu.

OK to commit ?

Thanks in advance for your feedback,

With Kind Regards,

Olivier


2014-08-21  Nicolas Roche <roche@adacore.com>

        * Makefile.in (FLAGS_TO_PASS): Propagate INSTALL, INSTALL_DATA,
	INSTALL_SCRIPT and INSTALL_PROGRAM as well.

[see attached file: propagate-install.diff]

[-- Attachment #2: propagate-install.diff --]
[-- Type: application/octet-stream, Size: 428 bytes --]

diff --git gcc/Makefile.in gcc/Makefile.in
index 56f4c84..e67d176 100644
--- gcc/Makefile.in
+++ gcc/Makefile.in
@@ -1096,6 +1096,10 @@ FLAGS_TO_PASS = \
 	"LDFLAGS=$(LDFLAGS)" \
 	"FLEX=$(FLEX)" \
 	"FLEXFLAGS=$(FLEXFLAGS)" \
+	"INSTALL=$(INSTALL)" \
+	"INSTALL_DATA=$(INSTALL_DATA)" \
+	"INSTALL_PROGRAM=$(INSTALL_PROGRAM)" \
+	"INSTALL_SCRIPT=$(INSTALL_SCRIPT)" \
 	"LN=$(LN)" \
 	"LN_S=$(LN_S)" \
 	"MAKEINFO=$(MAKEINFO)" \

             reply	other threads:[~2014-08-21 15:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 15:50 Olivier Hainque [this message]
2014-08-30  6:36 ` Jeff Law
2014-09-01  8:44   ` Olivier Hainque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A32C1082-F2CD-4596-B76B-E02B6C1DA135@adacore.com \
    --to=hainque@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=roche@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).