public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: libiberty TAGS
Date: Thu, 18 Jun 2015 22:48:00 -0000	[thread overview]
Message-ID: <A66644EF-2C0B-4669-B210-6AA5916303A7@comcast.net> (raw)
In-Reply-To: <874mm4bvq7.fsf@igel.home>

On Jun 18, 2015, at 1:35 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Mike Stump <mikestump@comcast.net> writes:
> 
>> +       cd $(srcdir) && etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
> 
> This doesn't work with a relative $(srcdir).

Sure it does.  I had tested with:

srcdir = ../../gcc/libiberty

which is a pretty typical relative srcdir, is it not?

Anyway, I see your point.  How about:

diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in
index f06cc69..11e5ce6 100644
--- a/libiberty/Makefile.in
+++ b/libiberty/Makefile.in
@@ -409,8 +409,9 @@ stamp-noasandir:
 
 etags tags: TAGS etags-subdir
 
+VPATH = @srcdir@
 TAGS: $(CFILES)
-       etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
+       cd $(srcdir) && etags $(CFILES)
 
 # The standalone demangler (c++filt) has been moved to binutils.
 # But make this target work anyway for demangler hacking.

Ok?

  reply	other threads:[~2015-06-18 20:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 20:35 Mike Stump
2015-06-18 20:55 ` Andreas Schwab
2015-06-18 22:48   ` Mike Stump [this message]
2015-11-12 19:25 Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A66644EF-2C0B-4669-B210-6AA5916303A7@comcast.net \
    --to=mikestump@comcast.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).