public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Fix testsuite/g++.old-deja/g++.mike/p658.C build failure on VxWorks RTP
@ 2020-12-22 21:45 Alexandre Oliva
  2020-12-29 18:48 ` Mike Stump
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2020-12-22 21:45 UTC (permalink / raw)
  To: gcc-patches; +Cc: Jerome Lambourg


The conflicting definition of OK is present in VxWorks RTP headers too.

Regstrapped on x86_64-linux-gnu, and tested with -x-arm-wrs-vxworks7r2.
Ok to install?


from Jerome Lambourg <lambourg@adacore.com>
for  gcc/testsuite/ChangeLog

        * g++.old-deja/g++.mike/p658.C: Also undefine OK on VxWorks RTP.
---
 gcc/testsuite/g++.old-deja/g++.mike/p658.C |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/g++.old-deja/g++.mike/p658.C b/gcc/testsuite/g++.old-deja/g++.mike/p658.C
index 8fc7cd51b2be3..a6268a36fd76b 100644
--- a/gcc/testsuite/g++.old-deja/g++.mike/p658.C
+++ b/gcc/testsuite/g++.old-deja/g++.mike/p658.C
@@ -12,9 +12,9 @@
 #define TRUE true
 #endif
 
-// The VxWorks kernel-mode headers define a macro named "OK", which is not
+// The VxWorks headers define a macro named "OK", which is not
 // ISO-compliant, but is part of the VxWorks API.
-#if defined __vxworks && !defined __RTP__
+#if defined __vxworks
 #undef OK
 #endif
 


-- 
Alexandre Oliva, happy hacker  https://FSFLA.org/blogs/lxo/
   Free Software Activist         GNU Toolchain Engineer
        Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix testsuite/g++.old-deja/g++.mike/p658.C build failure on VxWorks RTP
  2020-12-22 21:45 Fix testsuite/g++.old-deja/g++.mike/p658.C build failure on VxWorks RTP Alexandre Oliva
@ 2020-12-29 18:48 ` Mike Stump
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2020-12-29 18:48 UTC (permalink / raw)
  To: Alexandre Oliva; +Cc: gcc-patches, Jerome Lambourg

On Dec 22, 2020, at 1:45 PM, Alexandre Oliva <oliva@adacore.com> wrote:
> 
> The conflicting definition of OK is present in VxWorks RTP headers too.
> 
> Regstrapped on x86_64-linux-gnu, and tested with -x-arm-wrs-vxworks7r2.
> Ok to install?

Ok.

Ok to stylize all the #undef in the same way.  This is one happens to use a slightly different stye then the others as I recall.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-29 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 21:45 Fix testsuite/g++.old-deja/g++.mike/p658.C build failure on VxWorks RTP Alexandre Oliva
2020-12-29 18:48 ` Mike Stump

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).