* [patch] prepend vxworks-dummy.h to tm_file for powerp
@ 2018-09-20 14:05 Olivier Hainque
2018-09-20 15:49 ` Segher Boessenkool
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Hainque @ 2018-09-20 14:05 UTC (permalink / raw)
To: GCC Patches; +Cc: Segher Boessenkool
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
Hello,
vxworks-dummy.h is intended to be included in the list of
target header files for every CPU for which we have at least
one VxWorks port.
It essentially provides default values for common VxWorks
markers (typically, macros conveying if we are configured for
such or such VxWorks variant), so they can be referenced
consistently in other files of the port.
This was missing for powerpc* and this patch just fixes that,
which will help further vxworks related patches to come.
This should really be a noop for non VxWorks ports.
Checked on a gcc-8 based source tree that I can still
build functional compilers passing Ada ACATS for VxWorks
6.9 and 7.0.
Bootstrapped and reg tested on mainline for x86_64-linux.
With Kind Regards,
Olivier
2018-09-20 Olivier Hainque <hainque@adacore.com>
* config.gcc (powerpc*-*-*): Prepend vxworks-dummy.h to tm_file.
[-- Attachment #2: 0001-config.gcc-add-vxworks-dummy.h-to-tmfiles-for-powerp.patch --]
[-- Type: application/octet-stream, Size: 334 bytes --]
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -621,7 +621,7 @@ arm*-*-*)
tm_p_file="arm/arm-flags.h ${tm_p_file} arm/aarch-common-protos.h"
tm_file="vxworks-dummy.h ${tm_file}"
;;
-mips*-*-* | sh*-*-* | sparc*-*-*)
+mips*-*-* | powerpc*-*-* | sh*-*-* | sparc*-*-*)
tm_file="vxworks-dummy.h ${tm_file}"
;;
esac
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] prepend vxworks-dummy.h to tm_file for powerp
2018-09-20 14:05 [patch] prepend vxworks-dummy.h to tm_file for powerp Olivier Hainque
@ 2018-09-20 15:49 ` Segher Boessenkool
2018-09-20 15:53 ` [patch] prepend vxworks-dummy.h to tm_file for powerpc Olivier Hainque
0 siblings, 1 reply; 3+ messages in thread
From: Segher Boessenkool @ 2018-09-20 15:49 UTC (permalink / raw)
To: Olivier Hainque; +Cc: GCC Patches
Hi Olivier,
On Thu, Sep 20, 2018 at 04:04:51PM +0200, Olivier Hainque wrote:
> vxworks-dummy.h is intended to be included in the list of
> target header files for every CPU for which we have at least
> one VxWorks port.
>
> It essentially provides default values for common VxWorks
> markers (typically, macros conveying if we are configured for
> such or such VxWorks variant), so they can be referenced
> consistently in other files of the port.
>
> This was missing for powerpc* and this patch just fixes that,
> which will help further vxworks related patches to come.
>
> This should really be a noop for non VxWorks ports.
>
> Checked on a gcc-8 based source tree that I can still
> build functional compilers passing Ada ACATS for VxWorks
> 6.9 and 7.0.
>
> Bootstrapped and reg tested on mainline for x86_64-linux.
Looks fine to me (for all branches). Thanks,
Segher
> 2018-09-20 Olivier Hainque <hainque@adacore.com>
>
> * config.gcc (powerpc*-*-*): Prepend vxworks-dummy.h to tm_file.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] prepend vxworks-dummy.h to tm_file for powerpc
2018-09-20 15:49 ` Segher Boessenkool
@ 2018-09-20 15:53 ` Olivier Hainque
0 siblings, 0 replies; 3+ messages in thread
From: Olivier Hainque @ 2018-09-20 15:53 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: GCC Patches
Hi Segher,
> On 20 Sep 2018, at 17:44, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
> Looks fine to me (for all branches). Thanks,
Great :-) Thanks for your prompt feedabck !
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-20 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 14:05 [patch] prepend vxworks-dummy.h to tm_file for powerp Olivier Hainque
2018-09-20 15:49 ` Segher Boessenkool
2018-09-20 15:53 ` [patch] prepend vxworks-dummy.h to tm_file for powerpc Olivier Hainque
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).