From: FX <fxcoudert@gmail.com>
To: gfortran List <fortran@gcc.gnu.org>,
gcc-patches@gcc.gnu.org,
Janne Blomqvist <blomqvist.janne@gmail.com>,
Steve Kargl <sgk@troutmask.apl.washington.edu>
Subject: Re: [Patch, libfortran] PR 48931 Async-signal-safety of backtrace signal handler
Date: Sun, 22 May 2011 21:50:00 -0000 [thread overview]
Message-ID: <A91991CE-AF3B-4B02-9108-AB970EC58D12@gmail.com> (raw)
Dear Janne,
Sorry I'm a bit late on this, but since async-signal-safe code is so hard to get right (at least for me), I wanted to help review your new code. It's very nice to have this instead of my initial ugly implementation, and I have only spotted on issue: AFAICT, execvp() is not safe to use here; only execle() and execve() are.
Cheers!
FX
next reply other threads:[~2011-05-22 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 21:50 FX [this message]
2011-05-24 11:38 ` Janne Blomqvist
2011-05-24 11:42 ` FX
2011-05-24 13:19 ` N.M. Maclaren
-- strict thread matches above, loose matches on Subject: below --
2011-05-15 11:13 Janne Blomqvist
2011-05-15 17:43 ` Janne Blomqvist
2011-05-15 20:46 ` Janne Blomqvist
2011-05-20 16:15 ` Janne Blomqvist
2011-05-21 22:01 ` Steve Kargl
2011-05-18 1:11 ` Toon Moene
2011-05-18 6:03 ` Toon Moene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A91991CE-AF3B-4B02-9108-AB970EC58D12@gmail.com \
--to=fxcoudert@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).