From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-c1p-023462.sys.comcast.net (resqmta-c1p-023462.sys.comcast.net [IPv6:2001:558:fd00:56::2]) by sourceware.org (Postfix) with ESMTPS id 995BD3858D37 for ; Fri, 28 Apr 2023 13:17:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 995BD3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net Received: from resomta-c1p-023267.sys.comcast.net ([96.102.18.232]) by resqmta-c1p-023462.sys.comcast.net with ESMTP id sNfrpAtqzkfIwsNz4pUdc9; Fri, 28 Apr 2023 13:17:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1682687878; bh=sOTTwSvu2QuLW1I1bd3wGhUqW9wjAuWcgCyMfWLQxgo=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=p8BKtWdbLidKITYMuf1wwuj+0ZFLDIL/aqV6USJYEwz4v/oKdMYKxWmwAJi+JpfiR zf1IRJYJSR6PCYwExZ4IXPdMGpql8/9aIdxP0O6rm79lohjXPEJLmYfrQRvsQhpJ7z qv1apkCuRiHomIB/d68JreAH0yQ3r8yIYkkDUJKWOAUSwpxrdfE9EW72sBeNhq4MFX jhh+l4CgADun2sptCcjM8GtMR8dCs1a09YFoLd48EOd2nmVUEkzzNhomuteKlovT9I VrS2jsvXTGp2PZrQ7I+ctwHCXHcnTU3o6kcaKgnENp6FVp2Ag3jwceRsMuZT6s0AhJ PtaKIsa7XmnEw== Received: from smtpclient.apple ([73.60.223.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-c1p-023267.sys.comcast.net with ESMTPSA id sNz2p8o2ptXQvsNz3pxB8W; Fri, 28 Apr 2023 13:17:58 +0000 X-Xfinity-VAAS: gggruggvucftvghtrhhoucdtuddrgedvhedrfedukedgieefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuvehomhgtrghsthdqtfgvshhipdfqfgfvpdfpqffurfetoffkrfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpefrrghulhcumfhonhhinhhguceophgruhhlkhhonhhinhhgsegtohhmtggrshhtrdhnvghtqeenucggtffrrghtthgvrhhnpeevkeevleffleeigfeiudefheegjedthfegudejheeukeeitdfgteffvefggffgvdenucfkphepjeefrdeitddrvddvfedruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpihhnvghtpeejfedriedtrddvvdefrddutddupdhmrghilhhfrhhomhepphgruhhlkhhonhhinhhgsegtohhmtggrshhtrdhnvghtpdhnsggprhgtphhtthhopeehpdhrtghpthhtohepthgrmhgrrhdrtghhrhhishhtihhnrgesrghrmhdrtghomhdprhgtphhtthhopehgtggtqdhprghttghhvghssehgtggtrdhgnhhurdhorhhgpdhrtghpthhtohepnhgusegrrhhmrdgtohhmpdhrtghpthhtoheprhhguhgvnhhthhgvrhesshhushgvrdguvgdprhgtphhtthhopehjlhgrfiesvhgvnhhtrghnrghmihgtrhhordgtohhm X-Xfinity-VMeta: sc=-100.00;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: [PATCH 2/5] match.pd: Remove commented out line pragmas unless -vv is used. From: Paul Koning In-Reply-To: Date: Fri, 28 Apr 2023 09:17:56 -0400 Cc: Hans-Peter Nilsson via Gcc-patches , nd@arm.com, rguenther@suse.de, jlaw@ventanamicro.com Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Tamar Christina X-Mailer: Apple Mail (2.3696.120.41.1.3) X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On the check for verbose=3D=3D2, should that be verbose >=3D 2 ? paul > On Apr 28, 2023, at 6:38 AM, Tamar Christina via Gcc-patches = wrote: >=20 > Hi All, >=20 > genmatch currently outputs commented out line directives that have no = effect > but the compiler still has to parse only to discard. >=20 > They are however handy when debugging genmatch output. As such this = moves them > behind the -vv flag. >=20 > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. >=20 > Ok for master? >=20 > Thanks, > Tamar >=20 > gcc/ChangeLog: >=20 > PR bootstrap/84402 > * genmatch.cc (output_line_directive): Only emit commented = directive > when -vv. > (main): Initialize verbose. >=20 > --- inline copy of patch --=20 > diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc > index = 638606b2502f640e59527fc5a0b23fa3bedd0cee..6d62cdea2082d92e5ecc1102c8020511= 5a4e3040 100644 > --- a/gcc/genmatch.cc > +++ b/gcc/genmatch.cc > @@ -209,7 +209,7 @@ output_line_directive (FILE *f, location_t = location, > else > fprintf (f, "%s:%d", file, loc.line); > } > - else > + else if (verbose =3D=3D 2) > /* Other gen programs really output line directives here, at least = for > development it's right now more convenient to have line = information > from the generated file. Still keep the directives as comment = for now > @@ -5221,6 +5221,7 @@ main (int argc, char **argv) > return 1; >=20 > bool gimple =3D true; > + verbose =3D 0; > char *input =3D argv[argc-1]; > for (int i =3D 1; i < argc - 1; ++i) > { >=20 >=20 >=20 >=20 > --=20 >