From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64696 invoked by alias); 23 Jul 2015 18:24:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64672 invoked by uid 89); 23 Jul 2015 18:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: resqmta-po-12v.sys.comcast.net Received: from resqmta-po-12v.sys.comcast.net (HELO resqmta-po-12v.sys.comcast.net) (96.114.154.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 23 Jul 2015 18:24:44 +0000 Received: from resomta-po-06v.sys.comcast.net ([96.114.154.230]) by resqmta-po-12v.sys.comcast.net with comcast id vuQd1q0054yXVJQ01uQhjz; Thu, 23 Jul 2015 18:24:41 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-06v.sys.comcast.net with comcast id vuQf1q0082ztT3H01uQgLz; Thu, 23 Jul 2015 18:24:41 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] fix in-tree-binutils builds From: Mike Stump In-Reply-To: Date: Thu, 23 Jul 2015 18:56:00 -0000 Cc: Jan Beulich , GCC Patches , Binutils Content-Transfer-Encoding: quoted-printable Message-Id: References: <55A62FD90200007800091184@mail.emea.novell.com> <27496A41-4C23-49C5-93B7-9387FDB8BF8C@mrs.kithrup.com> To: "H.J. Lu" X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01970.txt.bz2 On Jul 23, 2015, at 7:47 AM, H.J. Lu wrote: > On Fri, Jul 17, 2015 at 7:43 AM, H.J. Lu wrote: >> On Wed, Jul 15, 2015 at 9:47 AM, Mike Stump wrote: >>> On Jul 15, 2015, at 9:07 AM, H.J. Lu wrote: >>>> On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich wrote: >>>>>=20 >>>>> - $gcc_cv_as_gas_srcdir/configure.in \ >>>>> + $gcc_cv_as_gas_srcdir/configure.[ai][cn] \ >>>>> $gcc_cv_as_gas_srcdir/Makefile.in ; do >>>>> gcc_cv_gas_version=3D`sed -n -e 's/^[[ ]]*VERSION=3D[[^0-9A-= Za-z_]]*\([[0-9]]*\.[[0-9]]*.*\)/VERSION=3D\1/p' < $f` >>>>=20 >>>> How portable is [ai][cn]? >>>=20 >>> Should be portable enough. >>=20 >> Are there any objections to this patch? >=20 > Can we check in this patch? I=92m not a build system nor a global reviewer so i have no more authority = to say yes than you. Seems kinda obvious and trivial to me. The goal of fixing in-tree binutils= builds seems reasonable to me.