public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eugene Rozenfeld <Eugene.Rozenfeld@microsoft.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Jason Merrill <jason@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [EXTERNAL] Re: [PATCH] Set discriminators for call stmts on the same line within the same basic block
Date: Tue, 11 Oct 2022 01:11:46 +0000	[thread overview]
Message-ID: <A9D51E13-6A73-43F2-84D4-42645A5EBCC9@microsoft.com> (raw)
In-Reply-To: <CAGWvny=e-=ho1eZTq6s5tJVXTvLFbBJzL7pmUfPGEsODbdpKGQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

I sent a patch that fixes a bug introduced by this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603203.html

What you are seeing could have been caused by the same bug since it involves an uninitialized variable.

Eugene


On Oct 10, 2022, at 5:54 PM, David Edelsohn <dje.gcc@gmail.com> wrote:


This patch causes a bootstrap comparison failure on AIX.  It apparently does not cause a failure on PPC64BE Linux with the same ABI, so I suspect that the failure may be related to the way that function aliases are implemented on AIX, which doesn't have ELF symbol alias semantics.

"This change will also simplify call site lookups since now location with discriminator will uniquely identify the call site (no callee function name is needed)."

I will open a PR with more information about the comparison difference now that I have a work-around to bring AIX back to a bootstrappable state.  Any thoughts about what could be going wrong?

Thanks, David



      reply	other threads:[~2022-10-11  1:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  0:54 David Edelsohn
2022-10-11  1:11 ` Eugene Rozenfeld [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A9D51E13-6A73-43F2-84D4-42645A5EBCC9@microsoft.com \
    --to=eugene.rozenfeld@microsoft.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).