From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id B9CD83844072 for ; Thu, 17 Nov 2022 06:33:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9CD83844072 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3566F21D10; Thu, 17 Nov 2022 06:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668666838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4R12K7aXu1zqHAEDoBAAyKSaRWrtjkqIfB3OoJIbPY=; b=Tp95Dy+ra3OEbKzekCZYerg5ejYbJ5YJIh7o5eMUMSb1Z0FalXenl1+DywSUm8jVic6ER6 YWfEfdxfzfKuS6Mw1S3tnzESYjXryezClegq4JVYht3/kqSUu7pnmvRm8SOZlpM4SeqdYe shMS7SCEY/vsW2/faGQORUEWb9PijLE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668666838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4R12K7aXu1zqHAEDoBAAyKSaRWrtjkqIfB3OoJIbPY=; b=RWrOoQO7TdZTC3p2rTiVbo7xpZ6Is4rYgoCUSJfV9MIMbGy5grSLZ4q3zXKbWcc/BBRlu7 HoT8UXCmguDheCCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CC1313A12; Thu, 17 Nov 2022 06:33:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ObZ0BtbVdWMZHAAAMHmgww (envelope-from ); Thu, 17 Nov 2022 06:33:58 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH]middle-end: ensure that VEC_PERM operands get lowered to the same SSA_NAME. [PR107717] Date: Thu, 17 Nov 2022 07:33:47 +0100 Message-Id: References: Cc: gcc-patches@gcc.gnu.org, nd@arm.com, jlaw@ventanamicro.com In-Reply-To: To: Tamar Christina X-Mailer: iPhone Mail (20B101) X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 17.11.2022 um 05:10 schrieb Tamar Christina via Gcc-patches : >=20 > =EF=BB=BFHi All, >=20 > At the moment when the VEC_PERMs generated by this match.pd rule is genera= ted > it creates two different SSA_NAMEs for the folded operand. Because of thi= s it > the permute switches from a single operand permute to a two operand permut= e and > the target may no longer support a permute for this. >=20 > This fixes it by ensuring we generate the same SSA_NAME for both operands.= >=20 > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. >=20 > Ok for master? >=20 Ok. Richard=20 > Thanks, > Tamar >=20 > gcc/ChangeLog: >=20 > PR tree-optimization/107717 > * match.pd: Ensure same SSA_NAME. >=20 > gcc/testsuite/ChangeLog: >=20 > PR tree-optimization/107717 > * gcc.target/aarch64/sve2/pr107717.c: New test. >=20 > --- inline copy of patch --=20 > diff --git a/gcc/match.pd b/gcc/match.pd > index 82f05bbc912e4f80f3984d930c4a8dcb010136e1..cd510d80d409a7c52ba2a78e2f= d7df0fc85cab2b 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -8317,7 +8317,7 @@ and, > (simplify > (op (vec_perm @0 @0 @2) (vec_perm @1 @1 @2)) > (if (VECTOR_INTEGER_TYPE_P (type)) > - (vec_perm (op @0 @1) (op @0 @1) @2)))) > + (vec_perm (op@3 @0 @1) @3 @2)))) >=20 > /* Similar for float arithmetic when permutation constant covers > all vector elements. */ > @@ -8356,4 +8356,4 @@ and, > } > } > (if (full_perm_p) > - (vec_perm (op @0 @1) (op @0 @1) @2)))))) > + (vec_perm (op@3 @0 @1) @3 @2)))))) >=20 >=20 >=20 >=20 > --=20 >