* Fix libtool.m4 for Darwin >= 10.10
@ 2014-11-11 9:06 FX
2014-11-11 9:08 ` Jakub Jelinek
2014-11-11 19:34 ` [patch, v2] " FX
0 siblings, 2 replies; 19+ messages in thread
From: FX @ 2014-11-11 9:06 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
libtool.m4 has a globbing pattern that assumes Mac OS version numbers 10.x are one digit for x. That’s unfortunate, especially now that Mac OS 10.10 was released :)
libtool has released a new version to fix this bug. The attached patch, bootstrapped and regtested on x86_64-apple-darwin14 (Mac OS 10.10), incorporates this fix into our libtool.m4 and regenerates the configures under our control.
OK to commit? This touches so many area it probably needs a build maintainer or global maintainer to approve it.
FX
PS: Let me know what the procedure is for the toplevel files (libtool.m4 and configure).
[-- Attachment #2: libtool.ChangeLog --]
[-- Type: application/octet-stream, Size: 2095 bytes --]
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libtool.m4: Fix globbing of darwin versions.
* configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* boehm-gc/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* gcc/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libatomic/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libbacktrace/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libcc1/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libcc1/plugin.cc:
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libcilkrts/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libffi/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libgomp/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libitm/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libobjc/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libquadmath/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libsanitizer/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libssp/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libstdc++-v3/configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libvtv/configure (else):
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* lto-plugin/configure: Regenerate.
[-- Attachment #3: libtool.diff --]
[-- Type: application/octet-stream, Size: 17022 bytes --]
Index: boehm-gc/configure
===================================================================
--- boehm-gc/configure (revision 217317)
+++ boehm-gc/configure (working copy)
@@ -7508,7 +7508,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: gcc/cfgexpand.c
===================================================================
--- gcc/cfgexpand.c (revision 217317)
+++ gcc/cfgexpand.c (working copy)
@@ -1721,6 +1721,8 @@ expand_used_vars (void)
clear_tree_used (DECL_INITIAL (current_function_decl));
init_vars_expansion ();
+ if (targetm.use_pseudo_pic_reg ())
+ pic_offset_table_rtx = gen_reg_rtx (Pmode);
hash_map<tree, tree> ssa_name_decls;
for (i = 0; i < SA.map->num_partitions; i++)
Index: gcc/configure
===================================================================
--- gcc/configure (revision 217317)
+++ gcc/configure (working copy)
@@ -14546,7 +14546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: gcc/function.c
===================================================================
--- gcc/function.c (revision 217317)
+++ gcc/function.c (working copy)
@@ -3674,11 +3674,6 @@ assign_parms (tree fndecl)
fnargs.release ();
- /* Initialize pic_offset_table_rtx with a pseudo register
- if required. */
- if (targetm.use_pseudo_pic_reg ())
- pic_offset_table_rtx = gen_reg_rtx (Pmode);
-
/* Output all parameter conversion instructions (possibly including calls)
now that all parameters have been copied out of hard registers. */
emit_insn (all.first_conversion_insn);
Index: gcc/ipa-chkp.c
===================================================================
--- gcc/ipa-chkp.c (revision 217317)
+++ gcc/ipa-chkp.c (working copy)
@@ -41,7 +41,6 @@ along with GCC; see the file COPYING3.
#include "cgraph.h"
#include "tree-chkp.h"
#include "ipa-chkp.h"
-#include <string>
/* Pointer Bounds Checker has two IPA passes to support code instrumentation.
Index: gcc/ipa-icf.c
===================================================================
--- gcc/ipa-icf.c (revision 217317)
+++ gcc/ipa-icf.c (working copy)
@@ -191,6 +191,18 @@ sem_item::dump (void)
}
}
+/* Return true if target supports aliasing. */
+
+bool
+sem_item::target_supports_aliasing_p (void)
+{
+#if !defined (ASM_OUTPUT_DEF) || (!defined(ASM_OUTPUT_WEAK_ALIAS) && !defined (ASM_WEAKEN_DECL))
+ return false;
+#else
+ return true;
+#endif
+}
+
/* Semantic function constructor that uses STACK as bitmap memory stack. */
sem_function::sem_function (bitmap_obstack *stack): sem_item (FUNC, stack),
@@ -589,7 +601,8 @@ sem_function::merge (sem_item *alias_ite
redirect_callers = false;
}
- if (create_alias && DECL_COMDAT_GROUP (alias->decl))
+ if (create_alias && (DECL_COMDAT_GROUP (alias->decl)
+ || !sem_item::target_supports_aliasing_p ()))
{
create_alias = false;
create_thunk = true;
@@ -649,7 +662,7 @@ sem_function::merge (sem_item *alias_ite
alias->resolve_alias (original);
/* Workaround for PR63566 that forces equal calling convention
- to be used. */
+ to be used. */
alias->local.local = false;
original->local.local = false;
@@ -1155,6 +1168,13 @@ sem_variable::merge (sem_item *alias_ite
{
gcc_assert (alias_item->type == VAR);
+ if (!sem_item::target_supports_aliasing_p ())
+ {
+ if (dump_file)
+ fprintf (dump_file, "Aliasing is not supported by target\n\n");
+ return false;
+ }
+
sem_variable *alias_var = static_cast<sem_variable *> (alias_item);
varpool_node *original = get_node ();
@@ -1239,6 +1259,7 @@ sem_variable::dump_to_file (FILE *file)
fprintf (file, "\n\n");
}
+
/* Iterates though a constructor and identifies tree references
we are interested in semantic function equality. */
Index: gcc/ipa-icf.h
===================================================================
--- gcc/ipa-icf.h (revision 217317)
+++ gcc/ipa-icf.h (working copy)
@@ -138,9 +138,11 @@ public:
/* Return base tree that can be used for compatible_types_p and
contains_polymorphic_type_p comparison. */
-
static bool get_base_types (tree *t1, tree *t2);
+ /* Return true if target supports aliasing. */
+ static bool target_supports_aliasing_p (void);
+
/* Item type. */
sem_item_type type;
Index: gcc/system.h
===================================================================
--- gcc/system.h (revision 217317)
+++ gcc/system.h (working copy)
@@ -194,6 +194,13 @@ extern int fprintf_unlocked (FILE *, con
#undef fread_unlocked
#undef fwrite_unlocked
+/* Include <string> before "safe-ctype.h" to avoid GCC poisoning
+ the ctype macros through safe-ctype.h */
+
+#ifdef __cplusplus
+# include <string>
+#endif
+
/* There are an extraordinary number of issues with <ctype.h>.
The last straw is that it varies with the locale. Use libiberty's
replacement instead. */
Index: gcc/wide-int.h
===================================================================
--- gcc/wide-int.h (revision 217317)
+++ gcc/wide-int.h (working copy)
@@ -2129,7 +2129,7 @@ template <typename T1, typename T2>
inline WI_BINARY_RESULT (T1, T2)
wi::smin (const T1 &x, const T2 &y)
{
- return min (x, y, SIGNED);
+ return wi::min (x, y, SIGNED);
}
/* Return the minimum of X and Y, treating both as unsigned values. */
@@ -2137,7 +2137,7 @@ template <typename T1, typename T2>
inline WI_BINARY_RESULT (T1, T2)
wi::umin (const T1 &x, const T2 &y)
{
- return min (x, y, UNSIGNED);
+ return wi::min (x, y, UNSIGNED);
}
/* Return the maxinum of X and Y, treating them both as having
@@ -2160,7 +2160,7 @@ template <typename T1, typename T2>
inline WI_BINARY_RESULT (T1, T2)
wi::smax (const T1 &x, const T2 &y)
{
- return max (x, y, SIGNED);
+ return wi::max (x, y, SIGNED);
}
/* Return the maximum of X and Y, treating both as unsigned values. */
@@ -2168,7 +2168,7 @@ template <typename T1, typename T2>
inline WI_BINARY_RESULT (T1, T2)
wi::umax (const T1 &x, const T2 &y)
{
- return max (x, y, UNSIGNED);
+ return wi::max (x, y, UNSIGNED);
}
/* Return X & Y. */
Index: libatomic/configure
===================================================================
--- libatomic/configure (revision 217317)
+++ libatomic/configure (working copy)
@@ -7329,7 +7329,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libbacktrace/configure
===================================================================
--- libbacktrace/configure (revision 217317)
+++ libbacktrace/configure (working copy)
@@ -7576,7 +7576,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcc1/configure
===================================================================
--- libcc1/configure (revision 217317)
+++ libcc1/configure (working copy)
@@ -7023,7 +7023,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcc1/plugin.cc
===================================================================
--- libcc1/plugin.cc (revision 217317)
+++ libcc1/plugin.cc (working copy)
@@ -55,8 +55,6 @@
#include "connection.hh"
#include "rpc.hh"
-#include <string>
-
#ifdef __GNUC__
#pragma GCC visibility push(default)
#endif
Index: libcilkrts/configure
===================================================================
--- libcilkrts/configure (revision 217317)
+++ libcilkrts/configure (working copy)
@@ -7546,7 +7546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libffi/configure
===================================================================
--- libffi/configure (revision 217317)
+++ libffi/configure (working copy)
@@ -7125,7 +7125,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgfortran/configure
===================================================================
--- libgfortran/configure (revision 217317)
+++ libgfortran/configure (working copy)
@@ -8816,7 +8816,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgomp/configure
===================================================================
--- libgomp/configure (revision 217317)
+++ libgomp/configure (working copy)
@@ -7312,7 +7312,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libitm/configure
===================================================================
--- libitm/configure (revision 217317)
+++ libitm/configure (working copy)
@@ -8002,7 +8002,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libobjc/configure
===================================================================
--- libobjc/configure (revision 217317)
+++ libobjc/configure (working copy)
@@ -6794,7 +6794,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libquadmath/configure
===================================================================
--- libquadmath/configure (revision 217317)
+++ libquadmath/configure (working copy)
@@ -6986,7 +6986,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libsanitizer/configure
===================================================================
--- libsanitizer/configure (revision 217317)
+++ libsanitizer/configure (working copy)
@@ -8506,7 +8506,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libssp/configure
===================================================================
--- libssp/configure (revision 217317)
+++ libssp/configure (working copy)
@@ -7123,7 +7123,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libstdc++-v3/configure
===================================================================
--- libstdc++-v3/configure (revision 217317)
+++ libstdc++-v3/configure (working copy)
@@ -7861,7 +7861,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libtool.m4
===================================================================
--- libtool.m4 (revision 217317)
+++ libtool.m4 (working copy)
@@ -1006,7 +1006,7 @@ _LT_EOF
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[[012]]*)
+ 10.[[012]][[,.]]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libvtv/configure
===================================================================
--- libvtv/configure (revision 217317)
+++ libvtv/configure (working copy)
@@ -8614,7 +8614,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
@@ -12127,7 +12127,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12099 "configure"
+#line 12130 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -12233,7 +12233,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12205 "configure"
+#line 12236 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
Index: lto-plugin/configure
===================================================================
--- lto-plugin/configure (revision 217317)
+++ lto-plugin/configure (working copy)
@@ -6825,7 +6825,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 9:06 Fix libtool.m4 for Darwin >= 10.10 FX
@ 2014-11-11 9:08 ` Jakub Jelinek
2014-11-11 9:21 ` FX
2014-11-11 19:34 ` [patch, v2] " FX
1 sibling, 1 reply; 19+ messages in thread
From: Jakub Jelinek @ 2014-11-11 9:08 UTC (permalink / raw)
To: FX; +Cc: GCC Patches
On Tue, Nov 11, 2014 at 09:58:45AM +0100, FX wrote:
> libtool.m4 has a globbing pattern that assumes Mac OS version numbers 10.x are one digit for x. That’s unfortunate, especially now that Mac OS 10.10 was released :)
>
> libtool has released a new version to fix this bug. The attached patch, bootstrapped and regtested on x86_64-apple-darwin14 (Mac OS 10.10), incorporates this fix into our libtool.m4 and regenerates the configures under our control.
>
> OK to commit? This touches so many area it probably needs a build maintainer or global maintainer to approve it.
>
> FX
>
> PS: Let me know what the procedure is for the toplevel files (libtool.m4 and configure).
Your patch contains lots of other changes, not just the libtool.m4
change. Please filter those out.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* boehm-gc/configure: Regenerate.
boehm-gc/ etc. have their own ChangeLog files, so the
entries should say just * configure: Regenerate.
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libcc1/plugin.cc:
???
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libvtv/configure (else):
??
Jakub
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 9:08 ` Jakub Jelinek
@ 2014-11-11 9:21 ` FX
2014-11-11 14:41 ` Jack Howarth
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-11 9:21 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
> Your patch contains lots of other changes, not just the libtool.m4
> change. Please filter those out.
Sorry about that. The patch attached should be clean, and the ChangeLog entries formatted as they should.
OK to commit? This touches so many area it probably needs a build maintainer or global maintainer to approve it.
FX
[-- Attachment #2: libtool.diff --]
[-- Type: application/octet-stream, Size: 11057 bytes --]
Index: boehm-gc/configure
===================================================================
--- boehm-gc/configure (revision 217317)
+++ boehm-gc/configure (working copy)
@@ -7508,7 +7508,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: gcc/configure
===================================================================
--- gcc/configure (revision 217317)
+++ gcc/configure (working copy)
@@ -14546,7 +14546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libatomic/configure
===================================================================
--- libatomic/configure (revision 217317)
+++ libatomic/configure (working copy)
@@ -7329,7 +7329,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libbacktrace/configure
===================================================================
--- libbacktrace/configure (revision 217317)
+++ libbacktrace/configure (working copy)
@@ -7576,7 +7576,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcc1/configure
===================================================================
--- libcc1/configure (revision 217317)
+++ libcc1/configure (working copy)
@@ -7023,7 +7023,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcilkrts/configure
===================================================================
--- libcilkrts/configure (revision 217317)
+++ libcilkrts/configure (working copy)
@@ -7546,7 +7546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libffi/configure
===================================================================
--- libffi/configure (revision 217317)
+++ libffi/configure (working copy)
@@ -7125,7 +7125,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgfortran/configure
===================================================================
--- libgfortran/configure (revision 217317)
+++ libgfortran/configure (working copy)
@@ -8816,7 +8816,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgomp/configure
===================================================================
--- libgomp/configure (revision 217317)
+++ libgomp/configure (working copy)
@@ -7312,7 +7312,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libitm/configure
===================================================================
--- libitm/configure (revision 217317)
+++ libitm/configure (working copy)
@@ -8002,7 +8002,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libobjc/configure
===================================================================
--- libobjc/configure (revision 217317)
+++ libobjc/configure (working copy)
@@ -6794,7 +6794,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libquadmath/configure
===================================================================
--- libquadmath/configure (revision 217317)
+++ libquadmath/configure (working copy)
@@ -6986,7 +6986,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libsanitizer/configure
===================================================================
--- libsanitizer/configure (revision 217317)
+++ libsanitizer/configure (working copy)
@@ -8506,7 +8506,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libssp/configure
===================================================================
--- libssp/configure (revision 217317)
+++ libssp/configure (working copy)
@@ -7123,7 +7123,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libstdc++-v3/configure
===================================================================
--- libstdc++-v3/configure (revision 217317)
+++ libstdc++-v3/configure (working copy)
@@ -7861,7 +7861,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libtool.m4
===================================================================
--- libtool.m4 (revision 217317)
+++ libtool.m4 (working copy)
@@ -1006,7 +1006,7 @@ _LT_EOF
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[[012]]*)
+ 10.[[012]][[,.]]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libvtv/configure
===================================================================
--- libvtv/configure (revision 217317)
+++ libvtv/configure (working copy)
@@ -8614,7 +8614,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
@@ -12127,7 +12127,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12099 "configure"
+#line 12130 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -12233,7 +12233,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12205 "configure"
+#line 12236 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
Index: lto-plugin/configure
===================================================================
--- lto-plugin/configure (revision 217317)
+++ lto-plugin/configure (working copy)
@@ -6825,7 +6825,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
[-- Attachment #3: libtool.ChangeLog --]
[-- Type: application/octet-stream, Size: 2002 bytes --]
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libtool.m4: Fix globbing of darwin versions.
* configure: Regenerate.
boehm-gc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
gcc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libatomic/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libbacktrace/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libcc1/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libcilkrts/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libffi/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libgomp/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libitm/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libobjc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libquadmath/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libsanitizer/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libssp/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libstdc++-v3/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libvtv/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure:
lto-plugin/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 9:21 ` FX
@ 2014-11-11 14:41 ` Jack Howarth
2014-11-11 14:46 ` FX
0 siblings, 1 reply; 19+ messages in thread
From: Jack Howarth @ 2014-11-11 14:41 UTC (permalink / raw)
To: FX; +Cc: Jakub Jelinek, GCC Patches
FX,
It looks like you missed patching a few configure files...
libjava/classpath/configure
libjava/configure
are definitely needed while....
libgo/configure
zlib/configure
should be added for completeness.
Jack
On Tue, Nov 11, 2014 at 4:15 AM, FX <fxcoudert@gmail.com> wrote:
>> Your patch contains lots of other changes, not just the libtool.m4
>> change. Please filter those out.
>
> Sorry about that. The patch attached should be clean, and the ChangeLog entries formatted as they should.
>
> OK to commit? This touches so many area it probably needs a build maintainer or global maintainer to approve it.
>
> FX
>
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 14:41 ` Jack Howarth
@ 2014-11-11 14:46 ` FX
2014-11-11 14:56 ` Jack Howarth
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-11 14:46 UTC (permalink / raw)
To: Jack Howarth; +Cc: Jakub Jelinek, GCC Patches
> It looks like you missed patching a few configure files...
>
> libjava/classpath/configure
> libjava/configure
Aren’t those under external control? i.e. maintained out of GCC tree?
> libgo/configure
> zlib/configure
Those are maintained upstream, and we import them directly. I’ve filed a bug for libgo (https://code.google.com/p/go/issues/detail?id=9089).
FX
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 14:46 ` FX
@ 2014-11-11 14:56 ` Jack Howarth
2014-11-11 15:01 ` FX
0 siblings, 1 reply; 19+ messages in thread
From: Jack Howarth @ 2014-11-11 14:56 UTC (permalink / raw)
To: FX; +Cc: Jakub Jelinek, GCC Patches
On Tue, Nov 11, 2014 at 9:45 AM, FX <fxcoudert@gmail.com> wrote:
>> It looks like you missed patching a few configure files...
>>
>> libjava/classpath/configure
>> libjava/configure
>
> Aren’t those under external control? i.e. maintained out of GCC tree?
However these are maintained, the libjava configure files still need
to be patched to prevent their associated shared libraries from being
inappropriately linked with -flat_namespace on darwin14 and later.
Since you are simply patching all the configure files, the question
seems academic unless you switch to properly regenerating all of the
configure files using a fixed libtool.m4.
Jack
>
>
>> libgo/configure
>> zlib/configure
>
> Those are maintained upstream, and we import them directly. I’ve filed a bug for libgo (https://code.google.com/p/go/issues/detail?id=9089).
>
> FX
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 14:56 ` Jack Howarth
@ 2014-11-11 15:01 ` FX
2014-11-11 15:03 ` Jakub Jelinek
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-11 15:01 UTC (permalink / raw)
To: Jack Howarth; +Cc: Jakub Jelinek, GCC Patches
> Since you are simply patching all the configure files, the question
> seems academic unless you switch to properly regenerating all of the
> configure files using a fixed libtool.m4.
I am actually proposing to fix libtool.m4 and regenerate the configure scripts (which gives the same result as patching, as expected).
> However these are maintained, the libjava configure files still need
> to be patched to prevent their associated shared libraries from being
> inappropriately linked with -flat_namespace on darwin14 and later.
Yes, but I don’t know whether libjava and classpath should be patched in GCC, or whether I should report them to be patched somewhere else (like libgo and zlib, for example). It’s important to do it properly, otherwise codebases diverge and maintance becomes difficult.
FX
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Fix libtool.m4 for Darwin >= 10.10
2014-11-11 15:01 ` FX
@ 2014-11-11 15:03 ` Jakub Jelinek
0 siblings, 0 replies; 19+ messages in thread
From: Jakub Jelinek @ 2014-11-11 15:03 UTC (permalink / raw)
To: FX; +Cc: Jack Howarth, GCC Patches
On Tue, Nov 11, 2014 at 03:59:03PM +0100, FX wrote:
>
> > Since you are simply patching all the configure files, the question
> > seems academic unless you switch to properly regenerating all of the
> > configure files using a fixed libtool.m4.
>
> I am actually proposing to fix libtool.m4 and regenerate the configure scripts (which gives the same result as patching, as expected).
>
>
> > However these are maintained, the libjava configure files still need
> > to be patched to prevent their associated shared libraries from being
> > inappropriately linked with -flat_namespace on darwin14 and later.
>
> Yes, but I don’t know whether libjava and classpath should be patched in
> GCC, or whether I should report them to be patched somewhere else (like
> libgo and zlib, for example). It’s important to do it properly, otherwise
> codebases diverge and maintance becomes difficult.
libjava is maintained in GCC, libjava/classpath, while imported
occassionally from upstream, would upon merge result in regenerating the
generated files and thus should be patched too. For the latter,
you should put it into libjava/classpath/ChangeLog.gcj.
Jakub
^ permalink raw reply [flat|nested] 19+ messages in thread
* [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 9:06 Fix libtool.m4 for Darwin >= 10.10 FX
2014-11-11 9:08 ` Jakub Jelinek
@ 2014-11-11 19:34 ` FX
2014-11-11 19:47 ` Mike Stump
1 sibling, 1 reply; 19+ messages in thread
From: FX @ 2014-11-11 19:34 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Here’s v2 of the patch, including libjava/configure and libjava/classpath/configure, as well as zlib/configure (since it has some adaptations from upstream, documented in zlib/ChangeLog.gcj).
OK to commit? Bootstrapped with all supported languages on x86_64-apple-darwin14.
FX
------
libtool.m4 has a globbing pattern that assumes Mac OS version numbers 10.x are one digit for x. That’s unfortunate, especially now that Mac OS 10.10 was released :)
libtool has released a new version to fix this bug. The attached patch, bootstrapped and regtested on x86_64-apple-darwin14 (Mac OS 10.10), incorporates this fix into our libtool.m4 and regenerates the configures under our control.
OK to commit? This touches so many area it probably needs a build maintainer or global maintainer to approve it.
FX
[-- Attachment #2: libtool.diff --]
[-- Type: application/octet-stream, Size: 12836 bytes --]
Index: boehm-gc/configure
===================================================================
--- boehm-gc/configure (revision 217355)
+++ boehm-gc/configure (working copy)
@@ -7508,7 +7508,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: gcc/configure
===================================================================
--- gcc/configure (revision 217355)
+++ gcc/configure (working copy)
@@ -14546,7 +14546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libatomic/configure
===================================================================
--- libatomic/configure (revision 217355)
+++ libatomic/configure (working copy)
@@ -7329,7 +7329,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libbacktrace/configure
===================================================================
--- libbacktrace/configure (revision 217355)
+++ libbacktrace/configure (working copy)
@@ -7576,7 +7576,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcc1/configure
===================================================================
--- libcc1/configure (revision 217355)
+++ libcc1/configure (working copy)
@@ -7023,7 +7023,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libcilkrts/configure
===================================================================
--- libcilkrts/configure (revision 217355)
+++ libcilkrts/configure (working copy)
@@ -7546,7 +7546,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libffi/configure
===================================================================
--- libffi/configure (revision 217355)
+++ libffi/configure (working copy)
@@ -7125,7 +7125,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgfortran/configure
===================================================================
--- libgfortran/configure (revision 217355)
+++ libgfortran/configure (working copy)
@@ -8816,7 +8816,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libgomp/configure
===================================================================
--- libgomp/configure (revision 217355)
+++ libgomp/configure (working copy)
@@ -7312,7 +7312,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libitm/configure
===================================================================
--- libitm/configure (revision 217355)
+++ libitm/configure (working copy)
@@ -8002,7 +8002,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libjava/classpath/configure
===================================================================
--- libjava/classpath/configure (revision 217358)
+++ libjava/classpath/configure (working copy)
@@ -8368,7 +8368,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libjava/configure
===================================================================
--- libjava/configure (revision 217358)
+++ libjava/configure (working copy)
@@ -9580,7 +9580,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libobjc/configure
===================================================================
--- libobjc/configure (revision 217355)
+++ libobjc/configure (working copy)
@@ -6794,7 +6794,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libquadmath/configure
===================================================================
--- libquadmath/configure (revision 217355)
+++ libquadmath/configure (working copy)
@@ -6986,7 +6986,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libsanitizer/configure
===================================================================
--- libsanitizer/configure (revision 217355)
+++ libsanitizer/configure (working copy)
@@ -8506,7 +8506,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libssp/configure
===================================================================
--- libssp/configure (revision 217355)
+++ libssp/configure (working copy)
@@ -7123,7 +7123,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libstdc++-v3/configure
===================================================================
--- libstdc++-v3/configure (revision 217355)
+++ libstdc++-v3/configure (working copy)
@@ -7861,7 +7861,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libtool.m4
===================================================================
--- libtool.m4 (revision 217355)
+++ libtool.m4 (working copy)
@@ -1006,7 +1006,7 @@ _LT_EOF
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[[012]]*)
+ 10.[[012]][[,.]]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: libvtv/configure
===================================================================
--- libvtv/configure (revision 217355)
+++ libvtv/configure (working copy)
@@ -8614,7 +8614,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
@@ -12127,7 +12127,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12099 "configure"
+#line 12130 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -12233,7 +12233,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 12205 "configure"
+#line 12236 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
Index: lto-plugin/configure
===================================================================
--- lto-plugin/configure (revision 217355)
+++ lto-plugin/configure (working copy)
@@ -6825,7 +6825,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
Index: zlib/configure
===================================================================
--- zlib/configure (revision 217355)
+++ zlib/configure (working copy)
@@ -6594,7 +6594,7 @@ $as_echo "$lt_cv_ld_force_load" >&6; }
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[91]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[012]*)
+ 10.[012][,.]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}suppress' ;;
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
[-- Attachment #3: libtool.ChangeLog --]
[-- Type: application/octet-stream, Size: 2483 bytes --]
toplevel:
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* libtool.m4: Fix globbing of darwin versions.
* configure: Regenerate.
boehm-gc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
gcc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libatomic/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libbacktrace/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libcc1/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libcilkrts/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libffi/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libgfortran/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libgomp/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libitm/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libobjc/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libquadmath/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libsanitizer/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libssp/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libstdc++-v3/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libvtv/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure:
lto-plugin/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libjava/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
libjava/classpath/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
zlib/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure: Regenerate.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:34 ` [patch, v2] " FX
@ 2014-11-11 19:47 ` Mike Stump
2014-11-11 19:48 ` Jeff Law
2014-11-11 19:50 ` [patch, v2] Fix libtool.m4 for Darwin >= 10.10 Jack Howarth
0 siblings, 2 replies; 19+ messages in thread
From: Mike Stump @ 2014-11-11 19:47 UTC (permalink / raw)
To: FX; +Cc: GCC Patches
On Nov 11, 2014, at 11:06 AM, FX <fxcoudert@gmail.com> wrote:
> Here’s v2 of the patch
> OK to commit?
Ok with comments:
libvtv:
libvtv/
2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
PR target/63610
* configure:
Missing Regenerate.
> OK to commit?
Ok.
> This touches so many area it probably needs a build maintainer or global maintainer to approve it.
Only darwin is affected, and unlikely anyone else cares much about it. I’m fine approving it. Arguably, imports from libtool upstream are trivial anyway.
If someone else wants to import all of libtool, we welcome their contribution.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:47 ` Mike Stump
@ 2014-11-11 19:48 ` Jeff Law
2014-11-11 20:38 ` FX
2014-11-11 19:50 ` [patch, v2] Fix libtool.m4 for Darwin >= 10.10 Jack Howarth
1 sibling, 1 reply; 19+ messages in thread
From: Jeff Law @ 2014-11-11 19:48 UTC (permalink / raw)
To: Mike Stump, FX; +Cc: GCC Patches
On 11/11/14 12:38, Mike Stump wrote:
> 2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
>
> PR target/63610 * configure:
>
> Missing Regenerate.
>
>> OK to commit?
>
> Ok.
>
>> This touches so many area it probably needs a build maintainer or
>> global maintainer to approve it.
>
> Only darwin is affected, and unlikely anyone else cares much about
> it. IÂ’m fine approving it. Arguably, imports from libtool upstream
> are trivial anyway.
Totally agree with Mike here. If you look at the patch it's clear it's
just hitting Darwin and it's absolutely safe.
>
> If someone else wants to import all of libtool, we welcome their
> contribution.
Similarly.
jeff
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:47 ` Mike Stump
2014-11-11 19:48 ` Jeff Law
@ 2014-11-11 19:50 ` Jack Howarth
2014-11-11 19:55 ` FX
2014-11-11 21:23 ` Mike Stump
1 sibling, 2 replies; 19+ messages in thread
From: Jack Howarth @ 2014-11-11 19:50 UTC (permalink / raw)
To: Mike Stump; +Cc: FX, GCC Patches
Mike,
The only problem with this fix for the broken libtool.m4 is that
it will require constant tending as other patches regenerate these
various configure files. For example,
https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just
committed would have removed the proposed change had it been committed
earlier today.
Jack
On Tue, Nov 11, 2014 at 2:38 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Nov 11, 2014, at 11:06 AM, FX <fxcoudert@gmail.com> wrote:
>> Here’s v2 of the patch
>
>> OK to commit?
>
> Ok with comments:
>
> libvtv:
>
> libvtv/
> 2014-11-11 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
>
> PR target/63610
> * configure:
>
> Missing Regenerate.
>
>> OK to commit?
>
> Ok.
>
>> This touches so many area it probably needs a build maintainer or global maintainer to approve it.
>
> Only darwin is affected, and unlikely anyone else cares much about it. I’m fine approving it. Arguably, imports from libtool upstream are trivial anyway.
>
> If someone else wants to import all of libtool, we welcome their contribution.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:50 ` [patch, v2] Fix libtool.m4 for Darwin >= 10.10 Jack Howarth
@ 2014-11-11 19:55 ` FX
2014-11-11 21:23 ` Mike Stump
1 sibling, 0 replies; 19+ messages in thread
From: FX @ 2014-11-11 19:55 UTC (permalink / raw)
To: Jack Howarth; +Cc: Mike Stump, GCC Patches
Hi Jack,
> The only problem with this fix for the broken libtool.m4 is that
> it will require constant tending as other patches regenerate these
> various configure files.
As I explained in an earlier email today, you are mistaken about the patch. It does fix libtool.m4, which means that all further invocations of autoconf to regenerate configure files will lead to any regression.
FX
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:48 ` Jeff Law
@ 2014-11-11 20:38 ` FX
2014-11-12 12:34 ` FX
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-11 20:38 UTC (permalink / raw)
To: Jeff Law; +Cc: Mike Stump, GCC Patches
> Totally agree with Mike here. If you look at the patch it's clear it's just hitting Darwin and it's absolutely safe.
Thanks everyone for the comments and review.
Committed as r217366
FX
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 19:50 ` [patch, v2] Fix libtool.m4 for Darwin >= 10.10 Jack Howarth
2014-11-11 19:55 ` FX
@ 2014-11-11 21:23 ` Mike Stump
1 sibling, 0 replies; 19+ messages in thread
From: Mike Stump @ 2014-11-11 21:23 UTC (permalink / raw)
To: Jack Howarth; +Cc: FX, GCC Patches
On Nov 11, 2014, at 11:48 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
> The only problem with this fix for the broken libtool.m4 is that
> it will require constant tending as other patches regenerate these
> various configure files. For example,
> https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just
> committed would have removed the proposed change had it been committed
> earlier today.
So, give it a try, and see if you can make it fail. Since he changed the source, is should not be possible that it fails during a regeneration. People can’t check in regenerations without actually regenerating at the time of an up to date commit. If not up-to-date, then have to pull down new sources, and then regenerate again.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10
2014-11-11 20:38 ` FX
@ 2014-11-12 12:34 ` FX
2014-11-24 17:17 ` Pushing recent libtool fix to binutils-gdb and newlib/libgloss FX
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-12 12:34 UTC (permalink / raw)
To: Jeff Law, Mike Stump, GCC Patches
> Thanks everyone for the comments and review.
> Committed as r217366
I cannot push the change to binutils-gdb as I don’t have write access there.
Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.
Could someone do it for me?
Thanks,
FX
commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
Author: FX <fxcoudert@gmail.com>
Date: Wed Nov 12 13:26:06 2014 +0100
* libtool.m4: Fix globbing of darwin versions.
diff --git a/ChangeLog b/ChangeLog
index 32b3c15..5ed8242 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2014-11-12 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
+
+ * libtool.m4: Fix globbing of darwin versions.
+
2014-10-15 Tristan Gingold <gingold@adacore.com>
* src-release.sh (do_proto_toplev): Configure with --target.
diff --git a/libtool.m4 b/libtool.m4
index 797468f..c96d80c 100644
--- a/libtool.m4
+++ b/libtool.m4
@@ -1006,7 +1006,7 @@ _LT_EOF
case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
- 10.[[012]]*)
+ 10.[[012]][[,.]]*)
_lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
10.*)
_lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
^ permalink raw reply [flat|nested] 19+ messages in thread
* Pushing recent libtool fix to binutils-gdb and newlib/libgloss
2014-11-12 12:34 ` FX
@ 2014-11-24 17:17 ` FX
2014-11-24 17:50 ` H.J. Lu
0 siblings, 1 reply; 19+ messages in thread
From: FX @ 2014-11-24 17:17 UTC (permalink / raw)
To: gcc-patches, GCC Development; +Cc: Jeff Law, Mike Stump
*ping*
Didn’t get any response to my question so far…
>> Thanks everyone for the comments and review.
>> Committed as r217366
>
> I cannot push the change to binutils-gdb as I don’t have write access there.
> Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.
>
> Could someone do it for me?
>
> Thanks,
> FX
>
>
>
>
> commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
> Author: FX <fxcoudert@gmail.com>
> Date: Wed Nov 12 13:26:06 2014 +0100
>
> * libtool.m4: Fix globbing of darwin versions.
>
> diff --git a/ChangeLog b/ChangeLog
> index 32b3c15..5ed8242 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-11-12 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
> +
> + * libtool.m4: Fix globbing of darwin versions.
> +
> 2014-10-15 Tristan Gingold <gingold@adacore.com>
>
> * src-release.sh (do_proto_toplev): Configure with --target.
> diff --git a/libtool.m4 b/libtool.m4
> index 797468f..c96d80c 100644
> --- a/libtool.m4
> +++ b/libtool.m4
> @@ -1006,7 +1006,7 @@ _LT_EOF
> case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
> 10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
> _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
> - 10.[[012]]*)
> + 10.[[012]][[,.]]*)
> _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
> 10.*)
> _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Pushing recent libtool fix to binutils-gdb and newlib/libgloss
2014-11-24 17:17 ` Pushing recent libtool fix to binutils-gdb and newlib/libgloss FX
@ 2014-11-24 17:50 ` H.J. Lu
2014-11-24 18:23 ` FX
0 siblings, 1 reply; 19+ messages in thread
From: H.J. Lu @ 2014-11-24 17:50 UTC (permalink / raw)
To: FX; +Cc: gcc-patches, GCC Development, Jeff Law, Mike Stump
Done:
https://sourceware.org/ml/binutils/2014-11/msg00318.html
On Mon, Nov 24, 2014 at 9:04 AM, FX <fxcoudert@gmail.com> wrote:
> *ping*
>
> Didn’t get any response to my question so far…
>
>
>>> Thanks everyone for the comments and review.
>>> Committed as r217366
>>
>> I cannot push the change to binutils-gdb as I don’t have write access there.
>> Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.
>>
>> Could someone do it for me?
>>
>> Thanks,
>> FX
>>
>>
>>
>>
>> commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
>> Author: FX <fxcoudert@gmail.com>
>> Date: Wed Nov 12 13:26:06 2014 +0100
>>
>> * libtool.m4: Fix globbing of darwin versions.
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 32b3c15..5ed8242 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2014-11-12 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
>> +
>> + * libtool.m4: Fix globbing of darwin versions.
>> +
>> 2014-10-15 Tristan Gingold <gingold@adacore.com>
>>
>> * src-release.sh (do_proto_toplev): Configure with --target.
>> diff --git a/libtool.m4 b/libtool.m4
>> index 797468f..c96d80c 100644
>> --- a/libtool.m4
>> +++ b/libtool.m4
>> @@ -1006,7 +1006,7 @@ _LT_EOF
>> case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
>> 10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
>> _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>> - 10.[[012]]*)
>> + 10.[[012]][[,.]]*)
>> _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
>> 10.*)
>> _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>>
>
--
H.J.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Pushing recent libtool fix to binutils-gdb and newlib/libgloss
2014-11-24 17:50 ` H.J. Lu
@ 2014-11-24 18:23 ` FX
0 siblings, 0 replies; 19+ messages in thread
From: FX @ 2014-11-24 18:23 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches, GCC Development, Jeff Law, Mike Stump
> Done:
> https://sourceware.org/ml/binutils/2014-11/msg00318.html
Thanks!
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2014-11-24 17:55 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-11 9:06 Fix libtool.m4 for Darwin >= 10.10 FX
2014-11-11 9:08 ` Jakub Jelinek
2014-11-11 9:21 ` FX
2014-11-11 14:41 ` Jack Howarth
2014-11-11 14:46 ` FX
2014-11-11 14:56 ` Jack Howarth
2014-11-11 15:01 ` FX
2014-11-11 15:03 ` Jakub Jelinek
2014-11-11 19:34 ` [patch, v2] " FX
2014-11-11 19:47 ` Mike Stump
2014-11-11 19:48 ` Jeff Law
2014-11-11 20:38 ` FX
2014-11-12 12:34 ` FX
2014-11-24 17:17 ` Pushing recent libtool fix to binutils-gdb and newlib/libgloss FX
2014-11-24 17:50 ` H.J. Lu
2014-11-24 18:23 ` FX
2014-11-11 19:50 ` [patch, v2] Fix libtool.m4 for Darwin >= 10.10 Jack Howarth
2014-11-11 19:55 ` FX
2014-11-11 21:23 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).