From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-273578-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16138 invoked by alias); 23 Sep 2010 14:17:00 -0000
Received: (qmail 16122 invoked by uid 22791); 23 Sep 2010 14:16:59 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Sep 2010 14:16:54 +0000
Received: by iwn2 with SMTP id 2so1642106iwn.20        for <gcc-patches@gcc.gnu.org>; Thu, 23 Sep 2010 07:16:52 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.10.141 with SMTP id p13mr1913974ibp.183.1285251412519; Thu, 23 Sep 2010 07:16:52 -0700 (PDT)
Received: by 10.231.17.130 with HTTP; Thu, 23 Sep 2010 07:16:52 -0700 (PDT)
In-Reply-To: <AANLkTi=MFUPd7+EURtRDJL8AKH8iifQg-qATNtpFejUb@mail.gmail.com>
References: <20100921210301.d92889be.basile@starynkevitch.net>	<20100921210829.5f2ea8b0.basile@starynkevitch.net>	<20100921211217.df1ef337.basile@starynkevitch.net>	<20100921211628.969ed469.basile@starynkevitch.net>	<20100921212431.f07dad12.basile@starynkevitch.net>	<AANLkTi=HitrGueHhPmCRgm7DNg5iEwCJFWgBTSFU6ptq@mail.gmail.com>	<20100923140756.GB20811@hector.lesours>	<AANLkTi=MFUPd7+EURtRDJL8AKH8iifQg-qATNtpFejUb@mail.gmail.com>
Date: Thu, 23 Sep 2010 19:39:00 -0000
Message-ID: <AANLkTi=4kZ+h5p1bjZTc0peFU5k_qwi1tMKM8gytiWvv@mail.gmail.com>
Subject: Re: gengtype improvements for plugins, thirdround! patch 5/7 [typedopt]
From: Richard Guenther <richard.guenther@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Basile Starynkevitch <basile@starynkevitch.net>, 	Laurynas Biveinis <laurynas.biveinis@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-09/txt/msg01900.txt.bz2

On Thu, Sep 23, 2010 at 4:14 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Thu, Sep 23, 2010 at 10:07, Basile Starynkevitch
> <basile@starynkevitch.net> wrote:
>
>> However, I believe that gengtype is misindented from the start, and
>> this explains most of my indentation issues. Please read
>> http://gcc.gnu.org/ml/gcc/2010-09/msg00448.html for details.
>
> If gengtype is misindented, please submit a separate patch fixing
> indentation issues. =A0Don't mix the two things in one patch. =A0Your
> changes are sufficiently big already.

And note that using GNU indent is not going to produce something
that is free of indentation issues.

Usual practice is to fix indentation issues in the code snippets you
are changing anyway.

Richard.