From: Richard Guenther <richard.guenther@gmail.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Bernd Schmidt <bernds@codesourcery.com>,
Jeff Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <rearnsha@arm.com>
Subject: Re: Combiner fixes
Date: Wed, 04 Aug 2010 08:36:00 -0000 [thread overview]
Message-ID: <AANLkTi=9=YT9aB_OLXd8OSahZfyoFX58ZerFAHgoL8V9@mail.gmail.com> (raw)
In-Reply-To: <4C584536.5010703@gnu.org>
On Tue, Aug 3, 2010 at 6:35 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
> On 08/03/2010 06:08 PM, Richard Guenther wrote:
>>
>> On Tue, Aug 3, 2010 at 6:06 PM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>>
>>> On Tue, Aug 3, 2010 at 6:01 PM, Bernd Schmidt<bernds@codesourcery.com>
>>> wrote:
>>>>
>>>> On 08/03/2010 05:44 PM, Richard Guenther wrote:
>>>>>
>>>>> It's not safe on RTL, please do not add FP reassociation there.
>>>>> (config/i386/i386.c:ix86_expand_{round,trunc,...} would start
>>>>> to break).
>>>>
>>>> Not a problem (I guess a !FLOAT_MODE_P || flag_associative_math test is
>>>> needed), but I guess I don't understand how things would break - I see
>>>> no multiply operations in these i386 functions. Can you elaborate?
>>>
>>> It was just a general comment to re-associations of FP on RTL,
>>> but more important is that we not start doing constant folding,
>>> re-associating should be fine as long as they are valid without
>>> any fancy math flags.
>>
>> Btw, doing more elaborate re-association on RTL would need
>> carrying PAREN_EXPR support down to RTL, which is an
>> explicit re-association barrier (dropped during expansion because
>> we do not re-associate FP on RTL - sofar).
>
> Looks like a bad idea... If someone ever introduces some world-shaking
> transform on RTL that requires reassociation he/she'll have to live with
> requiring -ffast-math or whatnot.
No, the point is that even with -ffast-math reassociating over
PAREN_EXPR is invalid.
Richard.
> Paolo
>
next prev parent reply other threads:[~2010-08-04 8:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 20:38 Bernd Schmidt
2010-08-03 7:24 ` Paolo Bonzini
2010-08-03 14:47 ` Bernd Schmidt
2010-08-03 15:01 ` Jeff Law
2010-08-03 15:11 ` Bernd Schmidt
2010-08-03 15:15 ` Richard Earnshaw
2010-08-03 15:16 ` Jeff Law
2010-08-03 15:28 ` Paolo Bonzini
2010-08-03 15:34 ` Bernd Schmidt
2010-08-03 15:45 ` Richard Guenther
2010-08-03 16:02 ` Bernd Schmidt
2010-08-03 16:06 ` Richard Guenther
2010-08-03 16:09 ` Richard Guenther
2010-08-03 16:35 ` Paolo Bonzini
2010-08-04 8:36 ` Richard Guenther [this message]
2010-08-03 16:12 ` Bernd Schmidt
2010-08-03 16:25 ` Richard Guenther
2010-08-04 15:39 ` H.J. Lu
2010-08-04 16:30 ` Bernd Schmidt
2010-08-04 17:45 ` H.J. Lu
2010-08-04 17:49 ` Bernd Schmidt
2010-08-04 18:00 ` H.J. Lu
2010-08-04 18:02 ` Bernd Schmidt
2010-08-04 18:08 ` H.J. Lu
2010-08-04 21:11 ` Bernd Schmidt
2010-08-07 13:14 ` Richard Guenther
2010-08-03 16:05 ` Richard Henderson
2010-08-03 16:09 ` Bernd Schmidt
2010-08-03 16:27 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=9=YT9aB_OLXd8OSahZfyoFX58ZerFAHgoL8V9@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=bernds@codesourcery.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).