public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: gcc-patches@gcc.gnu.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] [PATCH] Report LTO phase in lto1 process name v2
Date: Wed, 06 Oct 2010 17:32:00 -0000	[thread overview]
Message-ID: <AANLkTi==-bm-DmFsxFVt+vS-Vv0UN9X1sVt=JeT9Wt1t@mail.gmail.com> (raw)
In-Reply-To: <1286380179-5916-1-git-send-email-andi@firstfloor.org>

On Wed, Oct 6, 2010 at 8:49 AM, Andi Kleen <andi@firstfloor.org> wrote:

> +void
> +setproctitle (const char *name, ...)
> +{
> +  (void) name;
> +
> +#ifdef HAVE_PRCTL_SET_NAME
> +  /* On Linux this sets the top visible "comm", but not necessarily
> +     the name visible in ps. */
> +  prctl (PR_SET_NAME, name);
> +#endif
> +}

Why not use ATTRIBUTE_UNUSED instead of "(void)name;" ?  I also don't
like this idea really because it causes some folks not to understand
what the actual executable it is.

Thanks,
Andrew Pinski

  parent reply	other threads:[~2010-10-06 17:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 15:49 Andi Kleen
2010-10-06 15:51 ` Diego Novillo
2010-10-06 17:32 ` Andrew Pinski [this message]
2010-10-06 17:42   ` Andi Kleen
2010-10-06 17:47     ` Richard Henderson
2010-10-06 17:49 ` DJ Delorie
2010-10-06 17:51   ` Andi Kleen
2010-10-06 20:06     ` DJ Delorie
2010-10-06 21:41       ` Andi Kleen
2010-10-06 22:07         ` DJ Delorie
2010-10-07  3:17 ` Ryan Mansfield
2010-10-07  6:32   ` Andi Kleen
2010-10-07  6:40     ` DJ Delorie
2010-10-07  7:23       ` Andi Kleen
2010-10-07  9:32         ` Andi Kleen
2010-10-07 10:03         ` Ryan Mansfield
2010-11-18 21:33 green
2010-11-18 23:46 ` Andi Kleen
2010-11-19  9:15   ` Anthony Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi==-bm-DmFsxFVt+vS-Vv0UN9X1sVt=JeT9Wt1t@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).