From: Richard Guenther <richard.guenther@gmail.com>
To: Sebastian Pop <sebpop@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/3] Add -ftree-loop-distribute-patterns.
Date: Sun, 01 Aug 2010 12:06:00 -0000 [thread overview]
Message-ID: <AANLkTi=HWJS=Er_TxMXWKjoXbewvypNv1Mwu+enhThXM@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikw=YLtynuuzJ6muL9EKk_O1-Tad+N1YiO_LsdH@mail.gmail.com>
On Sat, Jul 31, 2010 at 5:30 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> I forgot this part in the patch below:
I thought of renaming -ftree-loop-distribute-memset-zero to
-ftree-loop-distribute-patterns, not adding an unused option.
Richard.
> diff --git a/gcc/tree-loop-distribution.c b/gcc/tree-loop-distribution.c
> index c677ecb..34d6e21 100644
> --- a/gcc/tree-loop-distribution.c
> +++ b/gcc/tree-loop-distribution.c
> @@ -1237,7 +1237,8 @@ static bool
> gate_tree_loop_distribution (void)
> {
> return flag_tree_loop_distribution
> - || flag_tree_loop_distribute_memset_zero;
> + || flag_tree_loop_distribute_memset_zero
> + || flag_tree_loop_distribute_patterns;
> }
>
> struct gimple_opt_pass pass_loop_distribution =
>
>
> On Sat, Jul 31, 2010 at 10:27, Sebastian Pop <sebpop@gmail.com> wrote:
>> ---
>> gcc/common.opt | 4 ++++
>> gcc/doc/invoke.texi | 5 +++++
>> gcc/tree-loop-distribution.c | 3 ++-
>> 3 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git a/gcc/common.opt b/gcc/common.opt
>> index 77cf58e..a9fcdd2 100644
>> --- a/gcc/common.opt
>> +++ b/gcc/common.opt
>> @@ -1341,6 +1341,10 @@ ftree-loop-distribute-memset-zero
>> Common Report Var(flag_tree_loop_distribute_memset_zero) Optimization
>> Enable loop distribution of initialization loops using memset zero
>>
>> +ftree-loop-distribute-patterns
>> +Common Report Var(flag_tree_loop_distribute_patterns) Optimization
>> +Enable loop distribution of patterns code generated with calls to a library
>> +
>> ftree-loop-im
>> Common Report Var(flag_tree_loop_im) Init(1) Optimization
>> Enable loop invariant motion on trees
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index ca3238c..b9b8b22 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -385,6 +385,7 @@ Objective-C and Objective-C++ Dialects}.
>> -ftree-copyrename -ftree-dce -ftree-dominator-opts -ftree-dse @gol
>> -ftree-forwprop -ftree-fre -ftree-loop-if-convert -ftree-loop-im @gol
>> -ftree-phiprop -ftree-loop-distribution -ftree-loop-distribute-memset-zero @gol
>> +-ftree-loop-distribute-patterns @gol
>> -ftree-loop-ivcanon -ftree-loop-linear -ftree-loop-optimize @gol
>> -ftree-parallelize-loops=@var{n} -ftree-pre -ftree-pta -ftree-reassoc @gol
>> -ftree-sink -ftree-sra -ftree-switch-conversion @gol
>> @@ -6946,6 +6947,10 @@ ENDDO
>> and the initialization loop is transformed into a call to memset zero.
>> This flag is enabled by default at @option{-O3}.
>>
>> +@item -ftree-loop-distribute-patterns
>> +Perform loop distribution of patterns that can be code generated with
>> +calls to a library. This enables @option{-ftree-loop-distribute-memset-zero}.
>> +
>> @item -ftree-loop-im
>> @opindex ftree-loop-im
>> Perform loop invariant motion on trees. This pass moves only invariants that
>> diff --git a/gcc/tree-loop-distribution.c b/gcc/tree-loop-distribution.c
>> index 920f744..c677ecb 100644
>> --- a/gcc/tree-loop-distribution.c
>> +++ b/gcc/tree-loop-distribution.c
>> @@ -1187,7 +1187,8 @@ tree_loop_distribution (void)
>> /* If both flag_tree_loop_distribute_memset_zero and
>> flag_tree_loop_distribution are set, then only memset_zero is
>> executed. */
>> - if (flag_tree_loop_distribute_memset_zero)
>> + if (flag_tree_loop_distribute_memset_zero
>> + || flag_tree_loop_distribute_patterns)
>> {
>> /* With the following working list, we're asking
>> distribute_loop to separate from the rest of the loop the
>> --
>> 1.7.0.4
>>
>>
>
next prev parent reply other threads:[~2010-08-01 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 20:41 [PATCH 0/2] Loop distribution for memset zero Sebastian Pop
2010-07-30 20:43 ` [PATCH 2/2] Enable flag_tree_loop_distribute_memset_zero at -O3 Sebastian Pop
2010-07-30 20:52 ` [PATCH 1/2] Add pass_loop_distribute_memset_zero Sebastian Pop
2010-07-31 11:35 ` [PATCH 0/2] Loop distribution for memset zero Richard Guenther
2010-07-31 15:28 ` Sebastian Pop
2010-07-31 15:28 ` Sebastian Pop
2010-07-31 15:28 ` [PATCH 1/3] Add pass_loop_distribute_memset_zero Sebastian Pop
2010-07-31 15:31 ` [PATCH 3/3] Add -ftree-loop-distribute-patterns Sebastian Pop
2010-07-31 15:45 ` Sebastian Pop
2010-08-01 12:06 ` Richard Guenther [this message]
2010-08-02 9:21 ` Richard Guenther
2010-08-02 15:26 ` [PATCH] Add -ftree-loop-distribute-patterns enabled at -O3 Sebastian Pop
2010-08-07 17:49 ` Gerald Pfeifer
2010-10-21 0:30 ` H.J. Lu
2010-12-18 17:48 ` H.J. Lu
2010-08-02 16:22 ` [PATCH 3/3] Add -ftree-loop-distribute-patterns Sebastian Pop
2010-07-31 15:34 ` [PATCH 2/3] Enable flag_tree_loop_distribute_memset_zero at -O3 Sebastian Pop
2010-07-31 17:21 ` [PATCH 0/2] Loop distribution for memset zero Michael Matz
2010-07-31 17:36 ` Sebastian Pop
2010-08-01 12:10 ` Richard Guenther
2010-07-31 20:01 ` Joseph S. Myers
2010-08-01 16:19 ` Michael Matz
2010-08-01 12:19 ` Richard Guenther
2010-08-01 15:21 ` Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=HWJS=Er_TxMXWKjoXbewvypNv1Mwu+enhThXM@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).