From: Richard Guenther <richard.guenther@gmail.com>
To: Sebastian Pop <sebpop@gmail.com>
Cc: Richard Guenther <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/3] Loop flattening on loop-SSA.
Date: Mon, 15 Nov 2010 23:30:00 -0000 [thread overview]
Message-ID: <AANLkTi=eqkAkTnPU8Ltg=1Ky+6irhz6m1Tc1XhR1wqxr@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinFO511=ftfJsvQUK=+pvaYjmAUB5CpDZuE7C7_@mail.gmail.com>
On Mon, Nov 15, 2010 at 11:57 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> On Mon, Nov 15, 2010 at 16:49, Sebastian Pop <sebpop@gmail.com> wrote:
>>> Thus, I think you should restrict your self to LI_ONLY_INNERMOST.
>>
>> That's debatable.
>
> I just happened looking at the definition of
>
> LI_ONLY_INNERMOST = 4 /* Iterate only over innermost loops. */
>
> It makes no sense to call loop flattening on the innermost loop:
> innermost loops contain zero inner loops, so there is nothing to flatten...
Oh, so you're not removing the loop you are applying to (flattening it to its
superloop) but flattening all subloops in loop.
Well. Then there's indeed no suitable order for you (there's no
LI_FROM_OUTERMOST which would then make sense).
Which means that IMHO it makes sense to only apply flattening
to parents of innermost loops (which is what I tried to suggest).
Any benchmark results yet?
Thanks,
Richard.
> Sebastian
>
next prev parent reply other threads:[~2010-11-15 23:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 3:11 [PATCH 0/6] Loop flattening and improved if-conversion Sebastian Pop
2010-10-29 3:11 ` [PATCH 1/6] Loop flattening on loop-SSA Sebastian Pop
2010-10-29 3:46 ` [PATCH 4/6] if-convert even when the data dependences cannot be computed Sebastian Pop
2010-10-29 3:57 ` [PATCH 5/6] Call if-conversion from loop flattening Sebastian Pop
2010-10-29 4:07 ` [PATCH 3/6] Fix PR46029: reimplement if-convert stores Sebastian Pop
2010-10-29 4:13 ` [PATCH 2/6] Remove ifcvt_memrefs_wont_trap analysis Sebastian Pop
2010-10-29 5:58 ` [PATCH 6/6] Move loop flattening and SLP vectorization at the end of loop transforms Sebastian Pop
2010-10-29 13:44 ` Richard Guenther
2010-10-30 0:23 ` Sebastian Pop
2010-10-30 8:01 ` Richard Guenther
2010-11-03 15:18 ` [PATCH 0/6] Loop flattening and improved if-conversion Richard Guenther
2010-11-03 15:53 ` [PATCH 1/3] Fix PR46029: reimplement if-convert stores Sebastian Pop
2010-11-05 12:08 ` Richard Guenther
2010-11-05 16:13 ` Sebastian Pop
2010-11-10 23:24 ` Sebastian Pop
2010-11-11 10:04 ` Richard Guenther
2010-11-15 22:39 ` Sebastian Pop
2010-11-16 14:45 ` Richard Guenther
2010-11-16 15:01 ` Richard Guenther
2011-01-03 21:39 ` Sebastian Pop
2011-01-03 21:52 ` Richard Guenther
2011-01-03 23:19 ` Sebastian Pop
2010-11-03 15:53 ` [PATCH 2/3] if-convert even when the data dependences cannot be computed Sebastian Pop
2010-11-03 20:47 ` Richard Guenther
2010-11-03 20:52 ` Sebastian Pop
2010-11-03 15:54 ` [PATCH 3/3] Loop flattening on loop-SSA Sebastian Pop
2010-11-03 16:57 ` Nathan Froyd
2010-11-03 17:29 ` Sebastian Pop
2010-11-05 13:05 ` Richard Guenther
2010-11-05 16:57 ` Sebastian Pop
2010-11-08 16:14 ` Richard Guenther
2010-11-15 23:05 ` Sebastian Pop
2010-11-15 23:17 ` Richard Guenther
2010-11-15 23:35 ` Sebastian Pop
2010-11-16 0:32 ` Richard Guenther
2010-11-15 23:08 ` Sebastian Pop
2010-11-15 23:10 ` Sebastian Pop
2010-11-15 23:30 ` Richard Guenther [this message]
2010-11-15 23:53 ` Sebastian Pop
2010-11-16 22:47 ` Sebastian Pop
2010-11-16 23:56 ` Sebastian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=eqkAkTnPU8Ltg=1Ky+6irhz6m1Tc1XhR1wqxr@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).