From: "H.J. Lu" <hjl.tools@gmail.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: Andrew Haley <aph@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch java]: Intialize va_list_type_node to avoid segfault for x86_64 targets in respect for alignment
Date: Fri, 07 Jan 2011 19:53:00 -0000 [thread overview]
Message-ID: <AANLkTi=giM-EetQeDWNENAGkQYhMvP5a_co+6+8UO7rK@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi==Y8=AxmzSFNBP+4Wad1ZfN2OWwV670rA+QudH@mail.gmail.com>
On Fri, Jan 7, 2011 at 11:20 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2011/1/7 H.J. Lu <hjl.tools@gmail.com>:
>> On Fri, Jan 7, 2011 at 5:51 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>>> 2011/1/7 Andrew Haley <aph@redhat.com>:
>>>> On 01/07/2011 11:42 AM, Kai Tietz wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> we noticed that java doesn't initialize in decl.c
>>>>> (java_init_decl_processing) the va_list_type_node. This leads to
>>>>> issues in some architectures for wrong checks and/or ICE (as for
>>>>> x86_64 one in i386.c (ix86_local_alignment)).
>>>>>
>>>>> ChangeLog
>>>>>
>>>>> 2011-01-07 Kai Tietz
>>>>>
>>>>> * decl.c (java_init_decl_processing): Setup va_list_type_node.
>>>>>
>>>>> Tested for i686-pc-cygwin and x86_64-w64-mingw32. Ok for apply?
>>>>
>>>> Sure.
>>>>
>>>> Andrew.
>>>>
>>>
>>> Ok, applied to trunk at revision 168569. Is this patch ok for 4.5 branch, too?
>>>
>>>
>>
>> This caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47215
>>
>>
>>
>> --
>> H.J.
>>
>
> Hmm, I see that java doesn't initialize unsigned_type_node. HJ does it
> solve the issue if you add 'unsigned_type_node = make_unsigned_type
> (INT_TYPE_SIZE);' before the target hook in java/decl.c 't =
> targetm.build_builtin_va_list ();' is called?
>
Please send me a proper patch.
Thanks.
--
H.J.
next prev parent reply other threads:[~2011-01-07 19:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 12:26 Kai Tietz
2011-01-07 14:01 ` Andrew Haley
2011-01-07 14:03 ` Kai Tietz
2011-01-07 18:34 ` H.J. Lu
2011-01-07 19:31 ` Kai Tietz
2011-01-07 19:53 ` H.J. Lu [this message]
2011-01-07 20:35 ` Kai Tietz
2011-01-07 20:50 ` Dave Korn
2011-01-07 20:57 ` Kai Tietz
2011-01-07 21:10 ` H.J. Lu
2011-01-07 21:16 ` Tom Tromey
2011-01-07 21:19 ` Kai Tietz
2011-01-11 15:02 ` Andreas Schwab
2011-01-11 15:21 ` Kai Tietz
2011-01-11 15:39 ` Kai Tietz
2011-01-11 16:09 ` Andreas Schwab
2011-01-11 16:12 ` Kai Tietz
2011-01-11 16:23 ` Andreas Schwab
2011-01-11 16:31 ` Richard Guenther
2011-01-11 19:55 ` Kai Tietz
2011-01-11 20:28 ` Andreas Schwab
2011-01-11 20:38 ` Kai Tietz
2011-01-11 20:51 ` Andreas Schwab
2011-01-12 10:11 ` Richard Guenther
2011-01-16 10:40 ` Kai Tietz
2011-01-17 14:56 ` Tom Tromey
2011-01-19 16:22 ` Jakub Jelinek
2011-01-21 4:14 ` Richard Henderson
2011-01-21 10:26 ` Kai Tietz
2011-01-17 14:46 ` Tom Tromey
2011-01-17 15:18 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=giM-EetQeDWNENAGkQYhMvP5a_co+6+8UO7rK@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=aph@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).