From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-277672-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 9877 invoked by alias); 8 Nov 2010 16:25:25 -0000
Received: (qmail 9853 invoked by uid 22791); 8 Nov 2010 16:25:21 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_ZJ
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Nov 2010 16:25:16 +0000
Received: by ewy2 with SMTP id 2so2772218ewy.20        for <gcc-patches@gcc.gnu.org>; Mon, 08 Nov 2010 08:25:14 -0800 (PST)
MIME-Version: 1.0
Received: by 10.213.16.69 with SMTP id n5mr4366179eba.26.1289233514371; Mon, 08 Nov 2010 08:25:14 -0800 (PST)
Received: by 10.220.182.10 with HTTP; Mon, 8 Nov 2010 08:25:14 -0800 (PST)
In-Reply-To: <yddbp5z4xsl.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
References: <yddk4kr7dpo.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<AANLkTikCbLaH6sH7BseefmF3aAbume2=o3ZyVOmJf-E4@mail.gmail.com>	<yddbp5z4xsl.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Date: Mon, 08 Nov 2010 16:27:00 -0000
Message-ID: <AANLkTi=uVSrFiebipMfdNGrgwNFzXH_fj6dXpf-8vnU9@mail.gmail.com>
Subject: Re: [testsuite] Add -msse to all i386 vector tests (PR target/46280)
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: Uros Bizjak <ubizjak@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-11/txt/msg00754.txt.bz2

On Mon, Nov 8, 2010 at 7:53 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> w=
rote:
> Uros Bizjak <ubizjak@gmail.com> writes:
>
>> On Fri, Nov 5, 2010 at 8:49 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de=
> wrote:
>>
>>> gcc.target/i386/vect-args.c still fails because the testcase is cycled
>>> through several options and only passes with -msse2. =A0Adding -msse
>>> obviously doesn't help. =A0I'm not sure what the best way to handle this
>>> is.
>>
>> IMO, you should add -Wno-psabi to dg-options. The test is already
>> compiled with -w, so we are not interested in complier warnings or
>> notes here.
>
> Ok. =A0Here's the patch I've come up with. =A0It includes the fixed wordi=
ng
> in the ABI warning message, an updated testcase to reflect this, and
> omits the sse effective-target keyword from the compile tests where it
> is unnecessary.
>
> Bootstrapped without regressions on i386-pc-solaris2.8 (with the sse
> keyword still included) and i386-pc-solaris2.11.
>

I agree with Uros.  We should add -Wno-psabi since we already use
-w.

--=20
H.J.