From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31390 invoked by alias); 21 Dec 2010 23:02:54 -0000 Received: (qmail 31378 invoked by uid 22791); 21 Dec 2010 23:02:53 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Dec 2010 23:02:46 +0000 Received: by wwe15 with SMTP id 15so4439930wwe.8 for ; Tue, 21 Dec 2010 15:02:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.16.21 with SMTP id g21mr4866234weg.6.1292972564492; Tue, 21 Dec 2010 15:02:44 -0800 (PST) Received: by 10.216.160.131 with HTTP; Tue, 21 Dec 2010 15:02:44 -0800 (PST) In-Reply-To: References: <4D10DE3A.2070706@oracle.com> Date: Wed, 22 Dec 2010 00:06:00 -0000 Message-ID: Subject: Re: [patch] fix c++/18016 - warn about self-initialization in constructor init-list From: Jonathan Wakely To: gcc-patches Content-Type: multipart/mixed; boundary=0015176f16f66936d60497f3a2cf Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01660.txt.bz2 --0015176f16f66936d60497f3a2cf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 408 On 21 December 2010 17:11, Jonathan Wakely wrote: > On 21 December 2010 17:04, Paolo Carlini wrote: >> Hi, >> >> + =A0if (warn_uninitialized && init && init !=3D NULL_TREE >> >> I think the last check in this line is redundant. > > Thanks, Paolo. I should have checked the definition of NULL_TREE. > > I'm re-testing with that change, but it shouldn't affect the results. Updated patch, tested x86_64-linux --0015176f16f66936d60497f3a2cf Content-Type: text/plain; charset=US-ASCII; name="18016-2.txt" Content-Disposition: attachment; filename="18016-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ghzeg0650 Content-length: 1696 SW5kZXg6IGNwL2luaXQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBj cC9pbml0LmMJKHJldmlzaW9uIDE2ODAyMykKKysrIGNwL2luaXQuYwkod29y a2luZyBjb3B5KQpAQCAtNDQ5LDYgKzQ0OSwxNyBAQCBwZXJmb3JtX21lbWJl cl9pbml0ICh0cmVlIG1lbWJlciwgdHJlZSBpCiAgIGlmIChkZWNsID09IGVy cm9yX21hcmtfbm9kZSkKICAgICByZXR1cm47CiAKKyAgaWYgKHdhcm5fdW5p bml0aWFsaXplZCAmJiBpbml0ICYmIFRSRUVfQ09ERSAoaW5pdCkgPT0gVFJF RV9MSVNUCisgICAgICAmJiBUUkVFX0NIQUlOIChpbml0KSA9PSBOVUxMX1RS RUUpCisgICAgeworICAgICAgdHJlZSB2YWwgPSBUUkVFX1ZBTFVFIChpbml0 KTsKKyAgICAgIGlmIChUUkVFX0NPREUgKHZhbCkgPT0gQ09NUE9ORU5UX1JF RiAmJiBUUkVFX09QRVJBTkQgKHZhbCwgMSkgPT0gbWVtYmVyCisJICAmJiBU UkVFX09QRVJBTkQgKHZhbCwgMCkgPT0gY3VycmVudF9jbGFzc19yZWYpCisJ d2FybmluZ19hdCAoREVDTF9TT1VSQ0VfTE9DQVRJT04gKGN1cnJlbnRfZnVu Y3Rpb25fZGVjbCksCisJICAgICAgICAgICAgT1BUX1d1bmluaXRpYWxpemVk LCAiJXFEIGlzIGluaXRpYWxpemVkIHdpdGggaXRzZWxmIiwKKwkJICAgIG1l bWJlcik7CisgICAgfQorCiAgIGlmIChpbml0ID09IHZvaWRfdHlwZV9ub2Rl KQogICAgIHsKICAgICAgIC8qIG1lbSgpIG1lYW5zIHZhbHVlLWluaXRpYWxp emF0aW9uLiAgKi8KSW5kZXg6IHRlc3RzdWl0ZS9nKysuZGcvd2Fybi9wcjE4 MDE2LkMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGVzdHN1aXRlL2cr Ky5kZy93YXJuL3ByMTgwMTYuQwkocmV2aXNpb24gMCkKKysrIHRlc3RzdWl0 ZS9nKysuZGcvd2Fybi9wcjE4MDE2LkMJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTEgQEAKKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9w dGlvbnMgIi1XdW5pbml0aWFsaXplZCIgfSAqLworCitjbGFzcyBYIHsKKyAg aW50IGk7CisgIFgoKSA6IGkoaSkgeyB9ICAgLy8geyBkZy13YXJuaW5nICJp bml0aWFsaXplZCB3aXRoIGl0c2VsZiIgfQorICBYKGludCBpKSA6IGkoaSkg eyB9CisgIFgoY29uc3QgWCYgeCkgOiBpKHguaSkgeyB9Cit9OworCisvLyB7 IGRnLXBydW5lLW91dHB1dCAiSW4gY29uc3RydWN0b3IiIH0K --0015176f16f66936d60497f3a2cf--